From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 6FB4A4C95 for ; Thu, 25 Oct 2018 23:16:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2018 14:16:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,425,1534834800"; d="scan'208";a="275664013" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2018 14:16:25 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.248]) by IRSMSX106.ger.corp.intel.com ([169.254.8.45]) with mapi id 14.03.0319.002; Thu, 25 Oct 2018 22:16:25 +0100 From: "Richardson, Bruce" To: Thomas Monjalon CC: "Laatz, Kevin" , "dev@dpdk.org" , "Van Haaren, Harry" , "stephen@networkplumber.org" , "gaetan.rivet@6wind.com" , "shreyansh.jain@nxp.com" , "mattias.ronnblom@ericsson.com" , Ciara Power , "Brian Archbold" Thread-Topic: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets Thread-Index: AQHUa7MdWegKBB/WL0S6MMnPSoZaWKUwWqwAgAADfICAABF4AP//8K2AgAAYHrA= Date: Thu, 25 Oct 2018 21:16:24 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B0726BFB95@IRSMSX103.ger.corp.intel.com> References: <20181024132725.5142-1-kevin.laatz@intel.com> <3330387.zQnsHCFWfj@xps> <20181025204424.GA4552@bricha3-MOBL.ger.corp.intel.com> <1823463.pdHNGopkkG@xps> In-Reply-To: <1823463.pdHNGopkkG@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2VlZjBlZDItNzFmYy00Y2VlLWE0YTktYTI4Y2Y0NzljNTEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNGNsN3JIZDNMUVQzOTVhRkFVOWdReWNRdVRPU3ZTeTJONVB4OVN1Ujl5U3djSGlCYjVQQ3Y3VW12U1BcL2RpWDcifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 21:16:30 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, October 25, 2018 9:50 PM > To: Richardson, Bruce > Cc: Laatz, Kevin ; dev@dpdk.org; Van Haaren, Harry > ; stephen@networkplumber.org; > gaetan.rivet@6wind.com; shreyansh.jain@nxp.com; > mattias.ronnblom@ericsson.com; Ciara Power ; Brian > Archbold > Subject: Re: [dpdk-dev] [PATCH v8 05/13] telemetry: add client feature an= d > sockets >=20 > 25/10/2018 22:44, Bruce Richardson: > > On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote: > > > 25/10/2018 22:29, Thomas Monjalon: > > > > 24/10/2018 18:03, Kevin Laatz: > > > > > --- a/lib/librte_telemetry/meson.build > > > > > +++ b/lib/librte_telemetry/meson.build > > > > > @@ -5,3 +5,5 @@ sources =3D files('rte_telemetry.c') headers =3D > > > > > files('rte_telemetry.h', 'rte_telemetry_internal.h') deps +=3D > > > > > ['metrics', 'ethdev'] cflags +=3D '-DALLOW_EXPERIMENTAL_API' > > > > > +jansson =3D cc.find_library('jansson', required: true) ext_deps > > > > > ++=3D jansson > > > > > > > > I just discovered an issue when trying to compile for arm64 (with > > > > devtools/test-meson-builds.sh): > > > > > > > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux- > gnu/bin/ld: > > > > cannot find -ljansson > > > > > > > > I am worried because it is a real blocker. > > > > > > The dependency must be optional. > > > Should we disable the library if jansson is not found? > > > > > Yes, it should be. > > > > Needs: > > > > jansson =3D cc.find_library('jansson', required: false) > > build =3D jansson.found() >=20 > And for the makefile? >=20 > It has been introduced (too early) in patch 3: > LDLIBS +=3D -ljansson > I think we must use pkg-config to check if jansson is found. >=20 I didn't look at the makefile, because you never asked! :-)