From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D13A55398 for ; Wed, 6 Mar 2019 12:52:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 03:52:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,447,1544515200"; d="scan'208";a="121447037" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga006.jf.intel.com with ESMTP; 06 Mar 2019 03:52:15 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.199]) by IRSMSX104.ger.corp.intel.com ([169.254.5.56]) with mapi id 14.03.0415.000; Wed, 6 Mar 2019 11:52:08 +0000 From: "Richardson, Bruce" To: Thomas Monjalon CC: "dev@dpdk.org" , "Rawat, Anand" , "Kadam, Pallavi" , "Menon, Ranjit" , "Shaw, Jeffrey B" Thread-Topic: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support Thread-Index: AQHU09N5Vg5J2OQBiE+h1SQor/LOPaX+YAQAgAAVbgCAAASNgIAAAspQ Date: Wed, 6 Mar 2019 11:52:08 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B072749EA4@IRSMSX103.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <37871127.gZq9nUeyVu@xps> <20190306112006.GA134252@bricha3-MOBL.ger.corp.intel.com> <1806536.Q1iGtk73nC@xps> In-Reply-To: <1806536.Q1iGtk73nC@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWM2MDk3ZjktZTNmNS00ZmVhLWE2NzItZDNiZGY0NzNiOTg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYmJWYjdxYitDeTlHNEVwWmVsS1BzSndTbUNEcUxFM3JFcjRCRnpUWmV1VE1IaDNDRUxSU2dnZFNuQzlXMDBxTyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 11:52:17 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, March 6, 2019 11:36 AM > To: Richardson, Bruce > Cc: dev@dpdk.org; Rawat, Anand ; Kadam, Pallavi > ; Menon, Ranjit ; Shaw, > Jeffrey B > Subject: Re: [dpdk-dev] [PATCH v2 1/6] eal: eal stub to add windows > support >=20 > 06/03/2019 12:20, Bruce Richardson: > > On Wed, Mar 06, 2019 at 11:03:24AM +0100, Thomas Monjalon wrote: > > > Hi, > > > > > > 06/03/2019 05:16, Anand Rawat: > > > > -# some libs depend on maths lib > > > > -add_project_link_arguments('-lm', language: 'c') > > > > -dpdk_extra_ldflags +=3D '-lm' > > > > +if cc.find_library('lm', required : false).found() > > > > + # some libs depend on maths lib > > > > + add_project_link_arguments('-lm', language: 'c') > > > > + dpdk_extra_ldflags +=3D '-lm' > > > > +endif > > > > > > Either libmath is required or not. > > > I don't think it can be optional. > > > Why is it changed? > > > > > > > I think these come as part of libc, it's just on Linux they are not in > > the main libc library but need to be linked in separately. > > > > https://en.wikipedia.org/wiki/C_mathematical_functions#libm > > > > Therefore, this looks the best way of dealing with this. >=20 > If it's the only solution, at least it deserves a comment. Yes. I'd suggest changing the existing comment rather than adding a new one= . Update it to point out that on some OS's the maths functions are in a sep= arate library. >=20 > > > > +if host_machine.system() !=3D 'windows' > > > > + common_sources =3D files( > > > > > > The definitive solution should be to compile all common EAL files. > > > Please explain what are the issues in the common files. > > > I think we should not remove them and fix them one by one. > > > You could provide a separate patch to skip some files for making > > > helloworld working. > > > > > > > I believe that is exactly what this patch is trying to do - it's > > skipping the files unneeded to get helloworld working, and the > > intention is to fix them one by one and add them back in later. > > Perhaps this sort of change should be a separate (precursor) patch > > where the cover letter can call this out explicitly? > > > > > > -deps +=3D 'kvargs' > > > > +if host_machine.system() !=3D 'windows' > > > > + deps +=3D 'kvargs' > > > > +endif > > > > > > Why kvargs is removed? > > > > Again, I believe these actions are to disable the parts of DPDK that > > are not needed to enable helloworld, allowing later patches to come in > > and fix them. >=20 > They are workarounds to build helloworld. > It is good to have progress in the draft tree, but I see no point in > merging this in master. > I think we should separate patches which are doing definitive changes fro= m > temporary workaround patches disabling some files. > It is not an issue to merge some patches for Windows which are not > compiling. >=20