From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAFFAA051A; Fri, 17 Jan 2020 14:29:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DEE329D6; Fri, 17 Jan 2020 14:29:07 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4524A28F3; Fri, 17 Jan 2020 14:29:06 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jan 2020 05:29:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,330,1574150400"; d="scan'208";a="257801724" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 17 Jan 2020 05:29:04 -0800 Received: from irsmsx111.ger.corp.intel.com (10.108.20.4) by irsmsx110.ger.corp.intel.com (163.33.3.25) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jan 2020 13:29:03 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.164]) by irsmsx111.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0439.000; Fri, 17 Jan 2020 13:29:03 +0000 From: "Richardson, Bruce" To: "Yigit, Ferruh" , "web@dpdk.org" , dev CC: Thomas Monjalon , David Marchand Thread-Topic: [dpdk-web] [PATCH] add build system update as nice to have Thread-Index: AQHVzTi+uYxi4jjUU0WmUCFNr6AuR6fu17Vg Date: Fri, 17 Jan 2020 13:29:03 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B097556730@IRSMSX103.ger.corp.intel.com> References: <20200117131913.72621-1-ferruh.yigit@intel.com> In-Reply-To: <20200117131913.72621-1-ferruh.yigit@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-web] [PATCH] add build system update as nice to have X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2 thoughts on this, and adding dev list to discussion. 1) This would only apply to make builds, I think. Any internal headers shou= ld not be passed to the "headers =3D " line in meson which tracks headers f= or installation only (all headers are found at build time in their original= source locations, not by being copied to a central location, so internal-o= nly headers need no action). 2) Not having some of these headers precludes the development of other out-= of-tree drivers without the full DPDK source tree. This is probably not a m= ajor concern, but is there a use-case where we want to allow people to rebu= ild their own private drivers just using an installed DPDK instance? Based = on that, I see three categories - regular public headers, headers for drive= r APIs (maybe for a dev package), and purely internal headers. Regards, /Bruce > -----Original Message----- > From: web On Behalf Of Ferruh Yigit > Sent: Friday, January 17, 2020 1:19 PM > To: web@dpdk.org > Cc: Thomas Monjalon ; David Marchand > > Subject: [dpdk-web] [PATCH] add build system update as nice to have >=20 > Some headers in DPDK needs to be shared between various libraries, these > are treated as public header by build system and put into same folder, > other libraries can consume the header from this folder. > But this cause a side affect that internal headers exposed to the > application. >=20 > A simple sample of this is 'rte_cryptodev_pmd.h', it is provided by > 'cryptodev' library and used by crypto PMDs, but this headers shouldn't b= e > used by applications. >=20 > A solution can be using two different interim folders, one for public > headers and other for DPDK wide headers. DPDK components can look both > folders but only ones in the public header folder will be installed to > system folders. >=20 > Cc: David Marchand >=20 > Signed-off-by: Ferruh Yigit > --- > content/roadmap/_index.md | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/content/roadmap/_index.md b/content/roadmap/_index.md index > 6cb2e68..ea920bb 100644 > --- a/content/roadmap/_index.md > +++ b/content/roadmap/_index.md > @@ -49,6 +49,7 @@ This list is obviously neither complete nor guaranteed. > - default configuration from files > - generic white/blacklisting > - libedit integration > +- don't expose DPDK wide header to public, like rte_cryptodev_pmd.h >=20 > ### Cycle model {#cycle} > ---- > -- > 2.24.1