From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E383430BE; Mon, 21 Aug 2023 10:03:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 027B040EE3; Mon, 21 Aug 2023 10:03:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BF5F340A7D for ; Mon, 21 Aug 2023 10:03:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692604997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EeMMis3hfZfck1Miffzlj0NHGT8NjPYH1oDb2X3bmAk=; b=Vbo+NIJruwFwd+ZUwtWI8tOOir2hd3x28EHwqbjbJv8qBIUibhJlegR3o1laqX2pDAymKB HTUXblR9WxnaliVSizWi7+u3JBzaE9mxJ7Vgb+XMMHsxYTFCvzk9WmixuZe/M/Ai4RY2fZ fJT+qr2LKLW4uukqzpUn+6aWgCNhlDg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-4aOTvtTYORqqFLUymoEWDA-1; Mon, 21 Aug 2023 04:03:16 -0400 X-MC-Unique: 4aOTvtTYORqqFLUymoEWDA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-94a34a0b75eso189956466b.1 for ; Mon, 21 Aug 2023 01:03:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692604994; x=1693209794; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EeMMis3hfZfck1Miffzlj0NHGT8NjPYH1oDb2X3bmAk=; b=U1fiKS/yMG6cvqAc4Uco4GkRC8RTjTSrUD+NCx3zGA7rKOcc1r9YeKSMv96G8F2buj Geot4+rmQZKnxfz9amA4D4gjsDWi9r9mWch+5XYzLumg13mTdEyK05fmWv19t/hTV4HU vID/qNGaXLJynSUM0yvo0w0dDL0onr4Be52+bZkHM1nryRUF8qXkDHQEhRCiSgwRte9Q Cssr90crtp9AmSN1cLxbUsNA6nKWQMwWqf4zDUIZpsB4Q+qYdt/sRzX39TfSz+eDqZMN rl0E6YsUutSUalJoBJ737fQEMLfa9zlXn0PwvyY92glr9oYaJHZ5ZeNLiKWPwVS48Mki B7mw== X-Gm-Message-State: AOJu0Yzreru//beWJcHTHzaFn5gsFuAmOCkml2oQrL5jHEaVhiioBqtt wa5/MY6rCEo1jfpyJmPNoNJmI9KvDSLayi/P9qeYhI8wSkAD5OJhfEBb6OXXUu/UBNbLp0fzrUa S+SaqqQxEJdQ= X-Received: by 2002:a17:906:20d7:b0:994:54fd:31aa with SMTP id c23-20020a17090620d700b0099454fd31aamr4378018ejc.15.1692604994634; Mon, 21 Aug 2023 01:03:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQURgB/GO321okUxe6AeHXRT54pTBy1b+erd1AhvNeTpCkwQ4d33NfRFPmR7O2alY2TPyZJg== X-Received: by 2002:a17:906:20d7:b0:994:54fd:31aa with SMTP id c23-20020a17090620d700b0099454fd31aamr4377992ejc.15.1692604994219; Mon, 21 Aug 2023 01:03:14 -0700 (PDT) Received: from [10.39.193.64] (5920ab7b.static.cust.trined.nl. [89.32.171.123]) by smtp.gmail.com with ESMTPSA id le26-20020a170907171a00b0099316c56db9sm6077746ejc.127.2023.08.21.01.03.12 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Aug 2023 01:03:13 -0700 (PDT) From: Eelco Chaudron To: David Marchand Cc: dev@dpdk.org, mkp@redhat.com, stable@dpdk.org, Jingjing Wu , Beilei Xing , Declan Doherty , Abhijit Sinha , Radu Nicolau Subject: Re: [PATCH] net/iavf: fix checksum offloading Date: Mon, 21 Aug 2023 10:03:11 +0200 X-Mailer: MailMate (1.14r5964) Message-ID: <59C4371C-6702-4704-ACAA-048794EA3A42@redhat.com> In-Reply-To: <20230818090351.2402519-1-david.marchand@redhat.com> References: <20230818090351.2402519-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 18 Aug 2023, at 11:03, David Marchand wrote: > The only presence of RTE_MBUF_F_TX_IPV4 can't be used as an indicator > that a checksum offload has been requested by an application. > Check that RTE_MBUF_F_TX_IP_CKSUM or others flags have been set. > > Fixes: 1e728b01120c ("net/iavf: rework Tx path") > Cc: stable@dpdk.org Thanks for fixing this David! I tested and reviewed this change and it works now. Tested-by: Eelco Chaudron Acked-by: Eelco Chaudron > Signed-off-by: David Marchand > --- > drivers/net/iavf/iavf_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c > index f7df4665d1..b9e2879764 100644 > --- a/drivers/net/iavf/iavf_rxtx.c > +++ b/drivers/net/iavf/iavf_rxtx.c > @@ -2652,6 +2652,9 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, > offset |= (m->l2_len >> 1) > << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT; > > + if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0) > + goto skip_cksum; > + > /* Enable L3 checksum offloading inner */ > if (m->ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { > if (m->ol_flags & RTE_MBUF_F_TX_IPV4) { > @@ -2702,6 +2705,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile uint64_t *qw1, > break; > } > > +skip_cksum: > *qw1 = rte_cpu_to_le_64((((uint64_t)command << > IAVF_TXD_DATA_QW1_CMD_SHIFT) & IAVF_TXD_DATA_QW1_CMD_MASK) | > (((uint64_t)offset << IAVF_TXD_DATA_QW1_OFFSET_SHIFT) & > -- > 2.41.0