Re: [PATCH v8 3/5] ethdev: format module EEPROM for SFF-8079

[Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>]

Consider: "support SFF-8079 module information telemetry"
(if it fits in required number of symbols)

On 5/25/22 06:14, Robin Zhang wrote:
> This patch implements format module EEPROM information for
> SFF-8079 Rev 1.7

Add support for module EEPROM information format defined in
SFF-8079 Rev 1.7.

> diff --git a/lib/ethdev/sff_8079.c b/lib/ethdev/sff_8079.c
> new file mode 100644
> index 0000000000..cfa20bd3cb
> --- /dev/null
> +++ b/lib/ethdev/sff_8079.c
> @@ -0,0 +1,406 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + *
> + * Implements SFF-8079 optics diagnostics.
> + *

Please, remove extra empty line.

> + */
> +
> +#include <stdio.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_flow.h>
> +#include "sff_common.h"
> +#include "ethdev_sff_telemetry.h"

Please, separate system, other DPDK and local headers.
Use double quotes for local headers.
Remove unnecessary includes.

> +	if (data[3] & (1 << 7))

Use RTE_BIT32 here and in similar cases below

> +	if (data[65] & (1 << 1))

Use RTE_BIT32 here as well.

> +		ssf_add_dict_string(d, name, "RX_LOS implemented");