DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luka Jankovic <luka.jankovic@ericsson.com>
To: "hofors@lysator.liu.se" <hofors@lysator.liu.se>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [RFC] eventdev: add atomic queue to test-eventdev app
Date: Mon, 16 Dec 2024 09:14:55 +0000	[thread overview]
Message-ID: <59e8bb8e38806364ccfb58831eed2e21574cc0f2.camel@ericsson.com> (raw)
In-Reply-To: <ecafb182-55ad-49b3-ab87-91f21937f4a0@lysator.liu.se>

Thank you for the feedback. I will re-implement the test by not checking port-flow-queue combination and generally clean-up the code based on your comments.

On Tue, 2024-12-10 at 11:37 +0100, Mattias Rönnblom wrote:
> 
> > +{
> > +       struct rte_event_dev_info dev_info;
> > +
> > +       rte_event_dev_info_get(dev_id, &dev_info);
> > +       return (dev_info.event_dev_cap & RTE_EVENT_DEV_CAP_MAINTENANCE_FREE) ?
> > +                       true : false;
> 
> return dev_info.event_dev_cap & RTE_EVENT_DEV_CAP_MAINTENANCE_FREE;
> 
> will work fine.
> 
> 
I decided against it in order to maintain consistent styling with similar functions in the file.

> 
> > +static int
> > +worker_wrapper(void *arg)
> 
> Delete "wrapper".

All other eventdev-tests name their equivalent functions "worker_wrapper", so I picked it to be consistent with the other tests.

> 
> > +
> > +       /* setup one port per worker, linking to all queues */
> > +       ret = order_event_dev_port_setup(test, opt, nb_workers, NB_QUEUES);
> 
> "order"?

This function is declared in test_order_common.h and is used in all tests. It is not specific for "ordered" ports, so I thought it was OK to use.


> > +
> > +static void
> > +atomic_queue_opt_dump(struct evt_options *opt)
> > +{
> > +       order_opt_dump(opt);
> 
> "order"?

Same thing here.


  reply	other threads:[~2024-12-16  9:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-05 13:29 Luka Jankovic
2024-12-10 10:37 ` Mattias Rönnblom
2024-12-16  9:14   ` Luka Jankovic [this message]
2024-12-19 13:24   ` Luka Jankovic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59e8bb8e38806364ccfb58831eed2e21574cc0f2.camel@ericsson.com \
    --to=luka.jankovic@ericsson.com \
    --cc=dev@dpdk.org \
    --cc=hofors@lysator.liu.se \
    --cc=mattias.ronnblom@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).