From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 38442AADE for <dev@dpdk.org>; Mon, 16 Apr 2018 17:41:24 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 4D36294008E; Mon, 16 Apr 2018 15:41:23 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Mon, 16 Apr 2018 16:41:18 +0100 To: Olivier Matz <olivier.matz@6wind.com> CC: <dev@dpdk.org>, Anatoly Burakov <anatoly.burakov@intel.com> References: <1511539591-20966-1-git-send-email-arybchenko@solarflare.com> <1523885080-17168-1-git-send-email-arybchenko@solarflare.com> <1523885080-17168-5-git-send-email-arybchenko@solarflare.com> <20180416153341.pko6s2xxzb6nv6m6@platinum> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <59fd3f55-d69b-6749-1679-3c76ddad33e0@solarflare.com> Date: Mon, 16 Apr 2018 18:41:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180416153341.pko6s2xxzb6nv6m6@platinum> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23786.003 X-TM-AS-Result: No--19.267900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523893283-SF+sbbtEWhDD Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 04/11] mempool: add op to calculate memory size to be allocated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 16 Apr 2018 15:41:25 -0000 On 04/16/2018 06:33 PM, Olivier Matz wrote: > On Mon, Apr 16, 2018 at 02:24:33PM +0100, Andrew Rybchenko wrote: >> Size of memory chunk required to populate mempool objects depends >> on how objects are stored in the memory. Different mempool drivers >> may have different requirements and a new operation allows to >> calculate memory size in accordance with driver requirements and >> advertise requirements on minimum memory chunk size and alignment >> in a generic way. >> >> Bump ABI version since the patch breaks it. >> >> Suggested-by: Olivier Matz <olivier.matz@6wind.com> >> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> > [...] > >> @@ -643,39 +633,35 @@ rte_mempool_populate_default(struct rte_mempool *mp) >> * 1G page on a 10MB memzone). If we fail to get enough contiguous >> * memory, then we'll go and reserve space page-by-page. >> */ >> - no_pageshift = no_contig || force_contig || >> - rte_eal_iova_mode() == RTE_IOVA_VA; >> + no_pageshift = no_contig || rte_eal_iova_mode() == RTE_IOVA_VA; >> try_contig = !no_contig && !no_pageshift && rte_eal_has_hugepages(); > In case there is a v5 for another reason, I think the last line is > equivalent to: > > try_contig = !no_pageshift && rte_eal_has_hugepages(); Agree. As I understand it is true before my patch as well. > Otherwise: > Acked-by: Olivier Matz <olivier.matz@6wind.com>