From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0066.outbound.protection.outlook.com [104.47.0.66]) by dpdk.org (Postfix) with ESMTP id 64FD68E01 for ; Mon, 22 Jan 2018 19:29:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=AgaLkniybAu4WbBHkA+Pxo6wL8q+PWQUH0aOGJPsQqk=; b=ef17F/wnOU0JKCVUEGr6n8dHGoiODfmKv46cGQ4rRcEvs3wB0ddgGlWGFofckiRL1hjx7NbJsUoCGZ5wRAHuAbQIuERmGZYASLBPhRAob4IM1y4MRAiG7P1AlPylbhp3yU7OWypIqewIFmsr1o2e9AYB+E3fS3aDEbDSyCgsCpI= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB2078.eurprd05.prod.outlook.com (10.167.195.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.428.17; Mon, 22 Jan 2018 18:29:31 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::2d4b:9768:b21a:e7e9]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::2d4b:9768:b21a:e7e9%14]) with mapi id 15.20.0428.019; Mon, 22 Jan 2018 18:29:31 +0000 From: Yongseok Koh To: Andrew Rybchenko , Thomas Monjalon , "jianbo.liu@arm.com" , Jerin Jacob CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "bruce.richardson@intel.com" , "Ananyev, Konstantin" , Chao Zhu , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers Thread-Index: AQHTkL63jw6fYDodT0WIn4anmizh1qN6yU2AgAVzFwA= Date: Mon, 22 Jan 2018 18:29:31 +0000 Message-ID: <5B266F6C-A33B-4019-BFDE-9CAC80835200@mellanox.com> References: <20180116011050.18866-1-yskoh@mellanox.com> <20180119004430.15305-1-yskoh@mellanox.com> <20180119004430.15305-2-yskoh@mellanox.com> <805e1578-6e4d-6a1b-00ce-13e3b1c16be8@solarflare.com> In-Reply-To: <805e1578-6e4d-6a1b-00ce-13e3b1c16be8@solarflare.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB2078; 6:TuzCB4KXImq82ejJBCUReYHG5raVGA0rE36/iFKDnWetHAdl5l8crF5GrsW4DIkGPDztJ/59W6BXGhsakP3XYA2MohwjyYsAS+AHuWek5JrUd1mkAvVMiuSwMdujCCkqXme7vMyI01uECBTHTVjzS4Fi50XUG3jAt+iQZSCKXR5HoL//1ZRdF6vZBAPrJhSXbfAwq9s+9XTQQkvQVo3aK0Oz5se2aYp2zLvThSrw3tkxDyxQn6OfWV5hIw8y6IUY7CzfpIYi803wcHPBBKQwws6U91632pMBUcEIXd25wzlczbm9sN1v4jk80ptvuJcj10vftTrBMRRPqpSUvllZDb/L3xEtQFUZ8Ua9R6/Y4e3POA9tCmX0P92BiiVjUf14; 5:FTlXkJvU+W9w+JP+Hkl2fRGZnry4hdhPzJ2zrfWQ6Qe9qrkpM1YFREzLLd4dctZ9LH1TziLwoh15uthkr/zNw5f4J8Nafb4XvoLisX6HcaYA6sL9VpMuOFXs68lgEZtiPEvxlfJmVxZJGl1+lPmGsoPwcOJWTmMiTa+e5gUmTFg=; 24:Mmdc3HwPuoY9JvJwTJ6EK6LbTwSCh0DE+cx0HX+SdqRX4JWSC3lhVOAaWUrLOJOBnPC5KnuPgTqvBrC5WWhC6Z4xP4aLQHKHzysL1EF6KTc=; 7:8JrlPCH7Nnoy3lZhPVGPeN8mnrf3Fhhyu8P7AEw9q2UIY08Ml75xA/XLucVMQ3gXZSmIrC/gGx+E6r9l7fIoSG4H59SFVYXRHLdyN2Suza3MtGMw3OelPdLxDNloyYK/QaDUzztSgMF4ukshPi3uCEBv8UiW3pwGV3hnxqwUkaf1cjz7+Lh3r4VwKZ2qx31Lic7SXl/nDkYXeXrqP7hvBlz78E5B/C3vyQQQAX/+5ukGT5KLgFgUNPZom4KRdj0K x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 8b09fd52-90dc-4a5d-4f5d-08d561c6149a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060)(7193020); SRVR:VI1PR0501MB2078; x-ms-traffictypediagnostic: VI1PR0501MB2078: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:VI1PR0501MB2078; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:VI1PR0501MB2078; x-forefront-prvs: 0560A2214D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(346002)(396003)(376002)(39860400002)(39380400002)(199004)(189003)(229853002)(36756003)(6506007)(6436002)(2906002)(6486002)(59450400001)(14454004)(102836004)(4326008)(25786009)(99286004)(6246003)(76176011)(53546011)(81166006)(83716003)(93886005)(8676002)(86362001)(3846002)(3660700001)(26005)(97736004)(8936002)(81156014)(3280700002)(6116002)(54906003)(66066001)(7416002)(6512007)(33656002)(305945005)(82746002)(105586002)(110136005)(316002)(106356001)(2501003)(2950100002)(68736007)(5660300001)(7736002)(478600001)(53936002)(2900100001)(5250100002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2078; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: i3v1dhum9rfGmSFDbWXRdqgCM/GyV8e9Ma/9eYw8Fbag5hFSqruXvzKnf9yr3nGeeqRRnkYkHiJt6C+h9XCbFQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-ID: <726AB2DA7E31414581B4D8DFCE75CC02@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b09fd52-90dc-4a5d-4f5d-08d561c6149a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2018 18:29:31.8306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2078 Subject: Re: [dpdk-dev] [PATCH v3 1/8] eal: introduce DMA memory barriers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 18:29:34 -0000 > On Jan 18, 2018, at 11:16 PM, Andrew Rybchenko wrote: >=20 > On 01/19/2018 03:44 AM, Yongseok Koh wrote: >> This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to >> guarantee the ordering of coherent shared memory between the CPU and a D= MA >> capable device. >>=20 >> Signed-off-by: Yongseok Koh=20 >> >=20 > Acked-by: Andrew Rybchenko >=20 > It is already really good. Many thanks. Thank you! > Maybe it would be useful to: > - avoid duplication of so long explanations (put in in one place and add= reference?) May have to ask Thomas how to do this. Thomas? > - explain why it is bound to DMA or call it in a different way, since ri= ght now it is bound > to coherent-mapped IO (rte_cio_rmb() ?). Yes, I see benefits to follow= Linux > terminology, but may be DPDK can do better :) I just add my concerns, = but let > EAL code maintainers to decide Good idea. Like to hear from other people. But, following linux terms somet= ime could be good to welcome developers from kernel community to DPDK world. :-= ) To people in the cc list, any other concerns? Especially ARM users - Jianbo and Jerin? Thanks, Yongseok=