From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E883430BE; Mon, 21 Aug 2023 11:32:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8A3141149; Mon, 21 Aug 2023 11:32:55 +0200 (CEST) Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by mails.dpdk.org (Postfix) with ESMTP id 19AB140A7D for ; Mon, 21 Aug 2023 11:32:53 +0200 (CEST) X-QQ-mid: bizesmtp91t1692610358t2lgbzag Received: from LAPTOP96V0OHHN ( [183.81.182.182]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 21 Aug 2023 17:32:37 +0800 (CST) X-QQ-SSF: 00400000000000D0F000000A0000000 X-QQ-FEAT: aBJFcW+uBGYM03Objb+GdiiSrnHtMKZRoJ+jOFk4zVtW8B5MCm6aZO+ec7AFF CE/uAXwfJJOolSbFkXJTm9WHruXwfM/up4Chcusv8vI30tGkDvqnlVWwZaZEt8z312U8vBX j3NfVOur+jRF9BgjbYRmam+lUURTOyFlFQ+zIclfspXV9LCLsjySz8jVY76HEDUZ7WXEVq2 Gdm8TrQ07CDK7tPTB1z9Cj9tluQc8DvYyOQHZje5Xvux70ppwDK8TpaZahWKpaO5EjwNLXb 9wYSQnFFtje0Wt6Bve8EZhA3HxTpiKMt2RK+juvCRTFJM3j1Yp8cfPqKFGAPdnT7I8+rDvK 5w2P54q2x9rclC+778keHgZHCDpZW1kmXZoB5FROqmLbW0yC4nPa8W/0SIcjsc4Jyr6x69q Vjz0hj+GV9M= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 1143495026234998165 From: "11" To: "'Thomas Monjalon'" Cc: , , , References: <20230807021615.3663034-1-caowenbo@mucse.com> <20230807021615.3663034-2-caowenbo@mucse.com> <2763426.X9hSmTKtgW@thomas> In-Reply-To: <2763426.X9hSmTKtgW@thomas> Subject: RE: [PATCH v5 1/8] net/rnp: add skeleton Date: Mon, 21 Aug 2023 17:32:37 +0800 Message-ID: <5BDBD6571B89977B+005b01d9d412$6d346370$479d2a50$@mucse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIAWciJel+Zl+JHk1Yy6/l9eWGpdAKP4KfiAcjEFzuvhKvwQA== Content-Language: zh-cn X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:mucse.com:qybglogicsvrgz:qybglogicsvrgz5a-0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas, Thanks for your useful advice, previously only focused on code format and Ignored document format. Regards Wenbo=09 > -----Original Message----- > From: Thomas Monjalon > Sent: 2023=C4=EA8=D4=C215=C8=D5 19:11 > To: Wenbo Cao > Cc: dev@dpdk.org; ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > yaojun@mucse.com > Subject: Re: [PATCH v5 1/8] net/rnp: add skeleton >=20 > Hi, >=20 > Wenbo Cao: > > --- /dev/null > > +++ b/doc/guides/nics/rnp.rst > > @@ -0,0 +1,43 @@ > > +.. SPDX-License-Identifier: BSD-3-Clause > > + Copyright(c) 2023 Mucse IC Design Ltd. > > + > > +RNP Poll Mode driver > > = +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >=20 > Please keep underlining the same size as the text above. Thanks for your kindly comment, the format of document I must lake of this knowledge >=20 > > + > > +The RNP ETHDEV PMD (**librte_net_rnp**) provides poll mode ethdev > > +driver support for the inbuilt network device found in the **Mucse > > +RNP** > > + > > +Prerequisites > > +------------- > > +More information can be found at `Mucse, Official Website > > +`_. > > + > > +Supported RNP SoCs > > +------------------------ > > + > > +- N10 > > + > > +Driver compilation and testing > > +------------------------------ > > + > > +Refer to the document :ref:`compiling and testing a PMD for a NIC > > +` for details. >=20 > It was a mistake to originally introduce the anchor = "pmd_build_and_test". > You should achieve the same result with the shorter > syntax :doc:`build_and_test` >=20 > > + > > +#. Running testpmd: > > + > > + Follow instructions available in the document > > + :ref:`compiling and testing a PMD for a NIC = ` > > + to run testpmd. >=20 > Do we really need that referencing the same document as above? For this block, there's really no need to add this. Previous ideas I want to add new content as the subsequent code is submitted. Do I need to add full features and NIC Description at the first code = commit ? >=20 > > + > > +Limitations or Known issues > > +---------------------------- > > +Build with ICC is not supported yet. > > +CRC stripping > > +~~~~~~~~~~~~~~ > > +The RNP SoC family NICs strip the CRC for every packets coming into > > +the host interface irrespective of the offload configuration. > > +When You Want To Disable CRC_OFFLOAD The Feature Will Influence The > > +RxCksum Offload VLAN Strip ~~~~~~~~~~~ For VLAN Strip RNP Just > > +Support CVLAN(0x8100) Type If The Vlan Type Is SVLAN(0X88a8) VLAN > > +Filter Or Strip Will Not Effert For This Packet It Will Bypass To = The Host. >=20 > Please check the doc contribution guide. > You should add spaces before and after titles. Yes this is my fault, :) , I have read the document and known that Add 2 blank lines before each section header. Add 1 blank line after each section header. >=20 >=20