From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 01DC91B3FC; Sun, 28 Apr 2019 08:51:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2019 23:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,404,1549958400"; d="scan'208";a="165585284" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2019 23:51:32 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 27 Apr 2019 23:51:32 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 27 Apr 2019 23:51:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Sun, 28 Apr 2019 14:51:29 +0800 From: "Xiao, QimaiX" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Peng, Yuan" Thread-Topic: [PATCH] net/i40e: remove useless check for queue number Thread-Index: AQHU/Y1/e20nvcIRy0mrxhPrmKTbyqZRISYg Date: Sun, 28 Apr 2019 06:51:29 +0000 Message-ID: <5C5FA1EBCC0D164EAD0302E258A5234B6EFB9D@SHSMSX103.ccr.corp.intel.com> References: <1556431998-65281-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1556431998-65281-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 28 Apr 2019 16:26:43 +0200 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Apr 2019 06:51:34 -0000 Tested-by: Xiao, QimaiX -----Original Message----- From: Zhao1, Wei=20 Sent: Sunday, April 28, 2019 2:13 PM To: dev@dpdk.org Cc: stable@dpdk.org; Zhang, Qi Z ; Xiao, QimaiX ; Peng, Yuan ; Zhao1, Wei Subject: [PATCH] net/i40e: remove useless check for queue number There is no need to do such a check of queue number, so remove it. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index dca61f0..5059bad 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf, return -EINVAL; } =20 - if (rss_info->conf.queue_num) - return -EINVAL; - /* If both VMDQ and RSS enabled, not all of PF queues are configured. * It's necessary to calculate the actual PF queues that are configured. */ -- 2.7.5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 57F33A0679 for ; Sun, 28 Apr 2019 16:27:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0C7111B45A; Sun, 28 Apr 2019 16:26:50 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 01DC91B3FC; Sun, 28 Apr 2019 08:51:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2019 23:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,404,1549958400"; d="scan'208";a="165585284" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 27 Apr 2019 23:51:32 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 27 Apr 2019 23:51:32 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sat, 27 Apr 2019 23:51:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Sun, 28 Apr 2019 14:51:29 +0800 From: "Xiao, QimaiX" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Qi Z" , "Peng, Yuan" Thread-Topic: [PATCH] net/i40e: remove useless check for queue number Thread-Index: AQHU/Y1/e20nvcIRy0mrxhPrmKTbyqZRISYg Date: Sun, 28 Apr 2019 06:51:29 +0000 Message-ID: <5C5FA1EBCC0D164EAD0302E258A5234B6EFB9D@SHSMSX103.ccr.corp.intel.com> References: <1556431998-65281-1-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1556431998-65281-1-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailman-Approved-At: Sun, 28 Apr 2019 16:26:43 +0200 Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove useless check for queue number X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190428065129.XKv2MC-8xkTuSRfDWoKSBBz4Do0tfOI5qHXdJbY-LfE@z> Tested-by: Xiao, QimaiX -----Original Message----- From: Zhao1, Wei=20 Sent: Sunday, April 28, 2019 2:13 PM To: dev@dpdk.org Cc: stable@dpdk.org; Zhang, Qi Z ; Xiao, QimaiX ; Peng, Yuan ; Zhao1, Wei Subject: [PATCH] net/i40e: remove useless check for queue number There is no need to do such a check of queue number, so remove it. Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") Signed-off-by: Wei Zhao --- drivers/net/i40e/i40e_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.= c index dca61f0..5059bad 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12699,9 +12699,6 @@ i40e_config_rss_filter(struct i40e_pf *pf, return -EINVAL; } =20 - if (rss_info->conf.queue_num) - return -EINVAL; - /* If both VMDQ and RSS enabled, not all of PF queues are configured. * It's necessary to calculate the actual PF queues that are configured. */ -- 2.7.5