From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17A4CA2EFC for ; Mon, 16 Sep 2019 17:59:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D3911BFDD; Mon, 16 Sep 2019 17:59:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 6D8941BFB6 for ; Mon, 16 Sep 2019 17:59:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 08:59:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,513,1559545200"; d="scan'208";a="180475794" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga008.jf.intel.com with ESMTP; 16 Sep 2019 08:58:50 -0700 To: Andrew Rybchenko , "John W. Linville" , Xiaolong Ye , Qi Zhang , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Rahul Lakkireddy , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Rastislav Cernay , Jan Remes , Alejandro Lucero , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang , Thomas Monjalon Cc: dev@dpdk.org References: <1567699852-31693-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-1-git-send-email-arybchenko@solarflare.com> <1568030331-16526-5-git-send-email-arybchenko@solarflare.com> <5093c27d-4251-e997-f4bb-d1f56a60443a@intel.com> <0aec5016-2130-26f9-dfd6-f65222514ced@solarflare.com> <1c8c01b2-b244-5cf9-8687-9ee897c73f7c@intel.com> <60e4ec91-7f2c-890a-b8d6-237f09b17c11@solarflare.com> <1696df72-998b-d189-aa19-70a16766f3ab@intel.com> <4cce6033-0347-04f6-3655-f36fbf9d32e8@solarflare.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <5a0d04d1-0e34-b4f7-19ea-bf135657169a@intel.com> Date: Mon, 16 Sep 2019 16:58:49 +0100 MIME-Version: 1.0 In-Reply-To: <4cce6033-0347-04f6-3655-f36fbf9d32e8@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/16/2019 4:45 PM, Andrew Rybchenko wrote: > On 9/16/19 4:22 PM, Ferruh Yigit wrote: >> On 9/13/2019 8:57 PM, Andrew Rybchenko wrote: >>> On 9/13/19 7:34 PM, Ferruh Yigit wrote: >>>> On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: >>>>> On 9/13/19 6:39 PM, Ferruh Yigit wrote: >>>>>> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >>>>>>> Enabling/disabling of promiscuous mode is not always successful and >>>>>>> it should be taken into account to be able to handle it properly. >>>>>>> >>>>>>> When correct return status is unclear from driver code, -EAGAIN is used. >>>>>>> >>>>>>> Signed-off-by: Andrew Rybchenko >>>>>> <...> >>>>>> >>>>>>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >>>>>>> index f85458c3cd..41612ce838 100644 >>>>>>> --- a/drivers/net/tap/rte_eth_tap.c >>>>>>> +++ b/drivers/net/tap/rte_eth_tap.c >>>>>>> @@ -1100,28 +1100,60 @@ tap_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused) >>>>>>> return 0; >>>>>>> } >>>>>>> >>>>>>> -static void >>>>>>> +static int >>>>>>> tap_promisc_enable(struct rte_eth_dev *dev) >>>>>>> { >>>>>>> struct pmd_internals *pmd = dev->data->dev_private; >>>>>>> struct ifreq ifr = { .ifr_flags = IFF_PROMISC }; >>>>>>> + int ret; >>>>>>> >>>>>>> - dev->data->promiscuous = 1; >>>>>>> - tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 1, LOCAL_AND_REMOTE); >>>>>>> - if (pmd->remote_if_index && !pmd->flow_isolate) >>>>>>> - tap_flow_implicit_create(pmd, TAP_REMOTE_PROMISC); >>>>>>> + ret = tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 1, LOCAL_AND_REMOTE); >>>>>>> + if (ret != 0) >>>>>>> + return ret; >>>>>>> + >>>>>>> + if (pmd->remote_if_index && !pmd->flow_isolate) { >>>>>>> + dev->data->promiscuous = 1; >>>>>> I think PMD shouldn't be setting this variable, it is already set by the API. >>>>>> I quickly checked if an internal function requires this but it looks like it has >>>>>> been set by mistake, I think we can remove this. >>>>> It is set after callback in the case of enable. >>>> I see, but do we need it enabled earlier? >>> Not sure that I understand the question, but tap_ioctl() does not use it. >>> So, it is safe to move just before tap_flow_implicit_create(). >> I think 'dev->data->promiscuous' shouldn't be set be PMD dev_ops, and API >> already does it. Is there a specific reason in tap to set this in dev_ops? If >> not can we remove setting 'dev->data->promiscuous' from dev_ops? > > The problem is the following: right now enable function sets > data->promiscuous after driver callback execution, some drivers > definitely use the variable internally and require it to be set before > some driver operations. That's why these drivers set it on entry. > However, it does not mean that no drivers rely on the fact that > data->promiscuous value is set to 1 after callback. Most likely these > drivers are buggy since it is false in the case of configuration restore > on startup, but anyway it is not that simply. > > Yes, I would prefer to avoid setting data->promiscuous from driver > code in enable/disable callbacks, but it should be a separate patch > which change it. > > Right now: > > net/bnxt sets data->promiscuous=1 on configure if Rx mode is VMDQ_DCB > > net/mlx4 sets data->promiscuous always on enable/disable entry > > net/octeontx sets data->promiscuous before exit from callback and > I think it can be safely removed since API functions definitely do it > before or after callback. > > net/softnic sets data->promiscuous=1 on driver register > > net/tap sets data->promiscuous=1 in enable/disable hooks before > tap_flow_implicit_create() > > net/nfb sets data->promiscuous in driver init > > net/octeontx2 sets data->promiscuous in the middle of processing, but > I guess before it is really used Thanks for the detailed clarification, I assumed it just introduced by mistake, with current status agree to handle this on a separate patch. Thanks, ferruh > > >>>>>>> + ret = tap_flow_implicit_create(pmd, TAP_REMOTE_PROMISC); >>>>>>> + if (ret != 0) { >>>>>>> + /* Rollback promisc flag */ >>>>>>> + tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 0, LOCAL_AND_REMOTE); >>>>>>> + /* >>>>>>> + * rte_eth_dev_promiscuous_enable() rollback >>>>>>> + * dev->data->promiscuous in the case of failure. >>>>>>> + */ >>>>>>> + return ret; >>>>>>> + } >>>>>>> + } >>>>>>> + >>>>>>> + return 0; >>>>>>> } >>>>>>> >>>>>>> -static void >>>>>>> +static int >>>>>>> tap_promisc_disable(struct rte_eth_dev *dev) >>>>>>> { >>>>>>> struct pmd_internals *pmd = dev->data->dev_private; >>>>>>> struct ifreq ifr = { .ifr_flags = IFF_PROMISC }; >>>>>>> + int ret; >>>>>>> >>>>>>> - dev->data->promiscuous = 0; >>>>>>> - tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 0, LOCAL_AND_REMOTE); >>>>>>> - if (pmd->remote_if_index && !pmd->flow_isolate) >>>>>>> - tap_flow_implicit_destroy(pmd, TAP_REMOTE_PROMISC); >>>>>>> + ret = tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 0, LOCAL_AND_REMOTE); >>>>>>> + if (ret != 0) >>>>>>> + return ret; >>>>>>> + >>>>>>> + if (pmd->remote_if_index && !pmd->flow_isolate) { >>>>>>> + dev->data->promiscuous = 0; >>>>>> Ditto >>>>>> >>>>>>> + ret = tap_flow_implicit_destroy(pmd, TAP_REMOTE_PROMISC); >>>>>>> + if (ret != 0) { >>>>>>> + /* Rollback promisc flag */ >>>>>>> + tap_ioctl(pmd, SIOCSIFFLAGS, &ifr, 1, LOCAL_AND_REMOTE); >>>>>>> + /* >>>>>>> + * rte_eth_dev_promiscuous_disable() rollback >>>>>>> + * dev->data->promiscuous in the case of failure. >>>>>>> + */ >>>>>>> + return ret; >>>>>>> + } >>>>>>> + } >>>>>>> + >>>>>>> + return 0; >>>>>>> } >