From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA6D2A04BC; Thu, 8 Oct 2020 15:37:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43BFE1C01F; Thu, 8 Oct 2020 15:37:47 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id EF5261C002 for ; Thu, 8 Oct 2020 15:37:44 +0200 (CEST) IronPort-SDR: bFNMpg5j6boixynA6mNHk0UWSD9kD+QAdtZAAzDOgYejf7m3cDiFwcka+dxJjQ2eO3J+E58qng bn1WIeRbdByQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="145199419" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="145199419" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 06:37:42 -0700 IronPort-SDR: 6cHsobTBPIZyD43mSen524JdKggpfWX3Qxi7aLeTKnvzE03tqrxX/HvbD0DmTjveIY+fzmFoLk Znk6pttzynpg== X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="312209236" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.103]) ([10.213.226.103]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 06:37:38 -0700 To: Ophir Munk , "dev@dpdk.org" , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Olivier Matz Cc: Ophir Munk References: <20200915131717.18252-2-ophirmu@nvidia.com> <20200918141735.18488-1-ophirmu@nvidia.com> <20200918141735.18488-2-ophirmu@nvidia.com> <24b36e2f-e601-d8b6-9a9e-b626d1ee9fd4@intel.com> From: Ferruh Yigit Message-ID: <5a0e3254-4bce-59ac-5d07-15fb5c8720bd@intel.com> Date: Thu, 8 Oct 2020 14:37:30 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/8/2020 9:44 AM, Ophir Munk wrote: > > >> -----Original Message----- >> From: Ferruh Yigit >> Sent: Wednesday, October 7, 2020 7:25 PM >> To: Ophir Munk ; dev@dpdk.org; Wenzhuo Lu > <...> >> Only when user set via "--geneve-port=N", it is the port for testpmd to parse >> (same for 'geneve_udp_port' global variable), but when user give command >> "port config N add geneve X" it is to configure the NIC to offload the parsing. >> This is too confusing, user can't know (or remember) this without checking >> the source code. >> >> Can we rename the command and variable to highlight that it is for testpmd >> to parse, I think that will be enough, instead of trying to merge them, which >> is hard as you described above. >> >> What do you think for "--testpmd-geneve-port=N" parameter and >> 'testpmd_geneve_udp_port' variable name? > > I am suggesting two options: > 1. "--geneve-port-identifier=N" and "geneve_udp_port_identifier" as variable name. > 2. "--geneve-parsed-port=N" and "geneve_udp_port" as variable name. > Can you select one of them? > I think 'identifier' doesn't add any more clarification, lets go with (2). Thanks. >> We can also update the documentation to say this is only the port testpmd >> uses for parsing, HW may be configured to use another port. >> > > Will update documentation. > > <...> >>> Done in v6. I added other missing tunnel protocols (in alphabetical order) >> such as "gtp". Since it is more than geneve I added it to the 3rd (cleanup) >> commit. >>> >> >> Would you mind adding the 'geneve' with the patch adding 'geneve' support >> (1/3), and add the other missing ones in the patch 3/3 ? > > Will update accordingly >