From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 67AB942D22;
	Thu, 22 Jun 2023 11:53:39 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id EDC52406B8;
	Thu, 22 Jun 2023 11:53:38 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 8F874406A2
 for <dev@dpdk.org>; Thu, 22 Jun 2023 11:53:37 +0200 (CEST)
Received: from [192.168.1.40] (unknown [188.170.81.161])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6740650;
 Thu, 22 Jun 2023 12:53:36 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6740650
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1687427616;
 bh=SYnXacFVIfAiBX8mb4a1CbsBaNMPWJ150GyYo5RarqU=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=gXWZ7QOJjvzwZVDNul4wYCig0v3Zhw17VV+I2UHBvI4/PnmGTXsVA8QbaknaO6nlG
 RUHr50QJIgPQ+7cGX1cspOD4xDx9fBMDIPr8CwRQVkXsQaNm6AkDrF8aFBv0uBaxZV
 x+Nej5blq1no3MN9uw5wsjbw14SMsHw3LWAGpTDg=
Message-ID: <5a2b9971-df23-2718-3bfd-a585c269b7dc@oktetlabs.ru>
Date: Thu, 22 Jun 2023 12:53:35 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2 4/4] net/sfc: add configurable Rx CRC stripping
Content-Language: en-US
To: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>, dev@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
 Roman Zhukov <roman.zhukov@arknetworks.am>,
 Andy Moreton <amoreton@xilinx.com>
References: <20230601114220.17796-1-denis.pryazhennikov@arknetworks.am>
 <20230622034738.51288-1-denis.pryazhennikov@arknetworks.am>
 <20230622034738.51288-5-denis.pryazhennikov@arknetworks.am>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20230622034738.51288-5-denis.pryazhennikov@arknetworks.am>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 6/22/23 06:47, Denis Pryazhennikov wrote:
> Configurable Rx CRC stripping is allowed only if
> running firmware variant supports it and if NIC is
> configured with single PF per port and without VFs.
> When KEEP_CRC is supported, CRC will be part of
> the packet payload. The packet length will also
> contain CRC length. At the same time, CRC length
> should be removed from stats.
> 
> Signed-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>
> Signed-off-by: Roman Zhukov <roman.zhukov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>