From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CE3543B4D; Mon, 19 Feb 2024 11:28:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3427A40289; Mon, 19 Feb 2024 11:28:56 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2041.outbound.protection.outlook.com [40.107.220.41]) by mails.dpdk.org (Postfix) with ESMTP id B34A940275 for ; Mon, 19 Feb 2024 11:28:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kNBil9OPHg+kz1hsBCDgv6q5hAP4P26MumR4w4Ue1vyXagtzFm/wIrc+lvyvIJCkvRbZM3BnqHZI3u6jNQi3clQPY6WTp3sBnvJlaDQbx4DhR37X9DNiimSWoaPYRS2Ebb/S90vL8wLtY9UWsJIUgg5j1PghmL+dbsWJZyaB2MEsWVwCcbAoPxtLM+JpvEiGefwV/mf+TI/Jv2HtbTwuVXhFabeXFTobwVJFk7M2yoOKcnsMq/HRAwXfIHdUcKAtm2fx9O6oZ0xXgWh9WERUdH/WuuNF0p/KIb0ZnPFUvfLnQcqn408zqxsHhJ3M+8oLjuLP3rrcdRsc/wFmI+h0Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=te2784PCUlxllXnb1bIYd6m4lm/bsAOFc6LM86Zh/xA=; b=WzLVu8PH64KFnZt1Ut01fIrtLC8mYyn6TvFg/m0uCi4uujOWCkaHFkF6JAdr+ctflxzQOOeLDUOhcFPQG9J9kmnyZcVg6Zq/dFkhHr/koazl+qi1RNVCOqhPh3jFM5MDNOZobSH+zJkNEl9Kl+eOBfPc5RNKCie4Ehq8eoTl/s8Gm/MUqY7xYNBsFBFKGD0U47D/sP898lVon2dQXVxPtW2E2V5yYcAGFhV8M9MGGDrcR2PXts+5qcS/8NWF/GDpaIwSq3X2BopUKLo12u4Vb+a9nDGyxnzrNuKiYJ2em9uW88bukbGYNOKC+vlz8EvmZgDhbxYpM0zgesst25Itkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=te2784PCUlxllXnb1bIYd6m4lm/bsAOFc6LM86Zh/xA=; b=RZn1iPp49pHD3iYOPuMOduaJ2MLW6qLHADAgTmgQYWpaZOsjfel4G6LeElTfdd4bvL4sjgLrjItdo1U8Nwex4yCmvJK5+xfpnOtzIf8e4acjcT+5PWg8vznOw74ollluNvDbw6dDbI8qvlZwk72d3pUICodk4YCowUA6LQ9umlY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN6PR12MB8566.namprd12.prod.outlook.com (2603:10b6:208:47c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.19; Mon, 19 Feb 2024 10:28:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Mon, 19 Feb 2024 10:28:52 +0000 Message-ID: <5a49bdd2-6b0d-4bc0-a784-f4c12e6020dc@amd.com> Date: Mon, 19 Feb 2024 10:28:48 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/nfp: add support of UDP fragmentation offload Content-Language: en-US To: Bruce Richardson , =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: Stephen Hemminger , Chaoyong He , dev@dpdk.org, oss-drivers@corigine.com, Long Wu , Peng Zhang References: <20240217015410.2163102-1-chaoyong.he@corigine.com> <20240217084725.5a1c6f34@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F228@smartserver.smartshare.dk> <20240217101122.37734606@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F229@smartserver.smartshare.dk> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0300.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:196::17) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN6PR12MB8566:EE_ X-MS-Office365-Filtering-Correlation-Id: f1cd64b7-86c6-4dc9-6890-08dc3135916d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 50pPLYaP3129yytEHk30UPz9tqtEse/RYVQV/a93QF084sjPgHe2w2PrNcMyRCszKZE9QyyyUWdttXlD9YpO+VA6F3CCAHXT4YMIiYTYlxEwTBJy6uXKB7OUx33nO01sQZTrvQRpDC42rvPKqgnceyBPjJcAOk1T55qqeXdIgnVFrjdVfry1KYnUS4aTHIradKtJxVaDQCqU3TMVWvOiYwXravP3BzwtEFzMvdoDWKR1XWiWggYBbCV0NDgQUxzhT3O1OhsM2NxB7NY/b/OalXeCqXwbbvpbsSlzF8ocpE0ANnS71W28MOTH8iNcYvG9y8FUqNAs7UohY6b/SJSmV2/7LRsyEQXuqA5U4DeHbgISCI9K0ptrS+pmBZzSMC+uZgcIVLrD1ve+hY92wv/BU0qmNOf9YcQ5ywYbxdbUw9gVoBsIaG8Gyputa3wWUCtDnpAr8oKrfhAGHpVneTYzThyVPQk0LakFQobzdRUGwoCj3MLn38SQZo3NnoSFnSEAgXiGQC4giHXVKyonoBwjHQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEJ2MTBNWDRVOUJxR2h4bUJoRWVVVE0yRFRLT3ZCa09BRkErVldqOFBGZFF0?= =?utf-8?B?YWVGMXN0OFI5UVRrYWVKV011SlROcmd1SEdhcFRsVDVGVXdTdmpZcHZkOGxj?= =?utf-8?B?d2cycTgzdWxyUGV4QU1qQ0tlWXpnM2ZxdUNsT0RlT1Z2R2xweFYyQ1g4Q3RW?= =?utf-8?B?bDZhdGxMUUxOT21yZk5iWGRGWVB6Q3FxM3I5ZHV2RkNWZkVHRGRqdlNaR2hP?= =?utf-8?B?QWdQMi9TVEpkNVdSV1F1eUNoOFNEUnUvWXFnT1FYWjU0RUwzNUR4TjZrNUVP?= =?utf-8?B?S0VMVG1HcFlGNmVWMGlNNzFMSmlVRmFjbUxGc000TzlyWklhNkRJbHN6aFQ1?= =?utf-8?B?UEVwMHVPd05EWlhvSGEvdlhIRnhLajRraE0zR2tjQk9wcHFnaTV0U01UaVRF?= =?utf-8?B?TXNZNzk0Q3h4azU3YnRyaWY2aWpwblJacU82MUhoTXkzaVkvaVpCRGRYK3NY?= =?utf-8?B?LzZ1Z1A4cUJZSjRhRjEzUUtJZEZacWJGOXRyYVdmSUhOc25qSFpWUUdMUkg5?= =?utf-8?B?RkRhZE94M0lkSXcwK0RpTzFQV3V2RjNEY2pFaFpFbzNuVU4wd1J1akxMcmF2?= =?utf-8?B?UEJKSzhISTVkTldXcWNDT2ZXWk9JS1JRYktDMC9wcUM4RmJUUTVvR0F5dy83?= =?utf-8?B?N0luc2p4SXZoejl0bzJ2T0tOL0prSjBmajJBcVF0MUVSeWJzdUlxcUMvZEFE?= =?utf-8?B?NVBrQTBQS3RHOWZTSEVzbkJNYzlLK0pPY3cvUFRIcGJva0ZYN2NYb01qNTVT?= =?utf-8?B?NHVBZmwwYlFDVkFFdWkweHJkUHNwQUlGMStyaEJGdGp1OGNFdTZ4Qm5RV1Z4?= =?utf-8?B?RCttdnY1UWQ1dGQwSUpaaHN2TUwzc0pZQW52OC9pbXNHUmhPTjRtR0loR1Bt?= =?utf-8?B?d3crYnhTTE1YLzBvRC9XTXpWWVNjaEo5V2tIb1ptSWhwaDcxT2ZOWkxyVVZL?= =?utf-8?B?aUp0aVFLa2xWMlJLZGZQM1NqNEVKUFBqYlpWLzVFdUQvUTgzV1FEb3packJm?= =?utf-8?B?Y1YyYlIwc2Y3YWZYNllVaG1HcHZOZ0UxK3d5bkQ4eFB3UUtWODgrYzBaMTcw?= =?utf-8?B?Z0VEYmZORXhNcHl1UTFBV2pEM1hBTkFtTjhOMWxhRVlUeWlzSEhJVnNkL01q?= =?utf-8?B?Z2VXV2pjQ1dqV1VBRytlME1iZVlQMi81VXE2RlFYU2RrdWRjdEpOSmZrSzZl?= =?utf-8?B?bzFwKzlmcHdnU2ZST3M1d3dJY01EMGFaVXBvcEhZWmw2K1oxYTRXMTBQWWhY?= =?utf-8?B?bU5ab1M4RkptRjFseTk1WTRCZkdkWFAvV1U2ZWFwaWU3cjhnZm1yTXErV3Jx?= =?utf-8?B?TmJTZTRTbHhsOU1kVHRwNzF3eWJza25aRStYaFFCYVlTOEpmMGowQXBKZlpu?= =?utf-8?B?Ym1SR2M0bG9oS2w3SHdCTjhYdytvY3JBeG9aU3JsVHlncVBDQWVJRVVvakEz?= =?utf-8?B?WXNaUkJ1bmtFajRHdnhQWTI2bmQrcS96aHR4SVFhOW05cHU3Z1gyNURqZ0Zo?= =?utf-8?B?ZnZiQ1N0WmRveFI4QVdlNjBOR3dHamRkaXBRNkxmNXBTYkVwZFZiUUF1aVRO?= =?utf-8?B?Z1dFVkdNSXJnMEJYTk9xM3pCWWdxRmdxaTluOVZicHdvRCtnUmpyVEdyN01Z?= =?utf-8?B?NEVPc2VUNGZuS1pEbHNPSE10Yi91eDdHZjhwN3YvbGpsbHJiNHNjZTlCZWVi?= =?utf-8?B?b29lRVFlQzh3M283UGxBQk9qN1V0bzdML2JHRjVMWEFteGtSaXpmdDdlQWpJ?= =?utf-8?B?YXoyYVlwRnVralgvU2lWdVV6MU9HeGpjcGpPYndiUXFxTHQ4VVViOEcvREtX?= =?utf-8?B?NHRiWE4wUTVNTERlcytoTGNBNmViaSt6eTBkMnJmeDgzTnIybFl2QjRyS3dz?= =?utf-8?B?TmtSMW5yQnY3RmcyR1dIbXNybkFJbzBGZWNqNVJxYnB3TlBLeVVybFd4bmp4?= =?utf-8?B?d3VVWkVLODM4aG9pTDR5Q01WTEE5VXJBYkYvL0VJWGdQY2ZYazFmd3E4b2Ux?= =?utf-8?B?bE5qQWNHbWxSVHNUUXQyVWpVOXpqbXk3VENmNkJLWEtkUGdhMmJhSSsxMHZE?= =?utf-8?B?d3dvOTdESmlML3BWSFZuTnZ0N3AwZUZocjBJOTl4eC9tWmRMcllqL0hLUXZC?= =?utf-8?Q?L96sV1yR79tiK2p/pNvPqV/QE?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1cd64b7-86c6-4dc9-6890-08dc3135916d X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2024 10:28:52.4920 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AdZ6p17Rp/OcteLeXx4cAVBY/H/KLFINv5VOw7t9lDvwtRfECoeQ4E5J1SkUde8g X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR12MB8566 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/19/2024 10:26 AM, Bruce Richardson wrote: > On Sun, Feb 18, 2024 at 11:05:35AM +0100, Morten Brørup wrote: >>> From: Stephen Hemminger [mailto:stephen@networkplumber.org] >>> Sent: Saturday, 17 February 2024 19.11 >>> >>> On Sat, 17 Feb 2024 19:02:30 +0100 >>> Morten Brørup wrote: >>> >>>> Not formally... it follows the official DPDK Coding Style [1]. >>>> >>>> [1]: >>> https://doc.dpdk.org/guides/contributing/coding_style.html#general >>>> >>>>> Should be: >>>>> >>>>> if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 && >>>>> (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0) >>>>> goto clean_txd; >>>> >>>> This indentation style is mentioned as an alternative in the guide. >>> But the example in the guide also uses two tabs for a similar long >>> comparison. >>>> >>>> Personally, I also prefer the style suggested by Stephen, so we might >>> want to update the Coding Style. ;-) >>> >>> >>> The two tabs is an Intel thing, and I prefer the kernel, line up the >>> conditional style. >> >> I prefer 4 space indentation, which is sufficient to notice the indentation. 8 spaces seems overkill to me, and quickly makes the lines too long. >> With the editor configured to show tab as 4 spaces, the kernel alignment style ends up with the same indentation for the condition and the code block: >> >> if (a && >> b) >> ctr++; >> >> Whereas with the "tab as 4 spaces" editor configuration, the double indentation style clearly separates the continued condition from code block: >> >> if (a && >> b) >> ctr++; >> > > These two above are the main reasons I much prefer the double indent on > continuation, though I'd also add a third one: it means we don't have a mix > of tabs and spaces for indentation. > > However, as stated already indent can be a matter of taste, and there will > be some disagreement about it. The existing coding standards document what > was done in the code base when they were written, and I don't think we > should look to change them. It's a bit annoying having 2 standards for > continuation rather than 1, but it's not exactly a free-for-all, and it's > not something that applies to every line, only to a small subset. > ++1