From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 664391B86F for <dev@dpdk.org>; Tue, 10 Apr 2018 14:55:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2018 05:55:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,432,1517904000"; d="scan'208";a="219244578" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.128]) ([10.237.220.128]) by fmsmga005.fm.intel.com with ESMTP; 10 Apr 2018 05:55:03 -0700 To: "Tosatti, Giovanni" <GTosatti@empirix.com>, "dev@dpdk.org" <dev@dpdk.org> References: <40ff3805d8a647f8bda4a386cc6a3987@bilemail2.empirix.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <5a663f79-da25-a2f9-d3d3-2c4817142613@intel.com> Date: Tue, 10 Apr 2018 13:55:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <40ff3805d8a647f8bda4a386cc6a3987@bilemail2.empirix.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] Add option to dpdk-devbind.py to restore kernel driver binding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 10 Apr 2018 12:55:05 -0000 On 10-Apr-18 11:55 AM, Tosatti, Giovanni wrote: > This patch adds a " --restore" option that will unbind all devices currently bound to DPDK PMDs back to the kernel driver. Hi Giovanni, Nitpicking the commit message, but I believe "unbind" here is a bit of a misnomer - one does not "unbind to kernel driver", it's either "bind to kernel driver" or "bind to DPDK driver" :) > > --- /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07.orig/tools/dpdk-devbind.py > +++ /opt/Perforce/gtosatti_centos/E-XMS/CSA-Mainline/Third-Party/dpdk/dpdk-16.07/tools/dpdk-devbind.py > @@ -91,6 +91,9 @@ > -u, --unbind: > Unbind a device (Equivalent to \"-b none\") > > + -r, --restore > + Restore ALL the DPDK devices to their kernel drivers Same here - perhaps for clarity this should be "For all devices bound to DPDK drivers, bind them to their kernel drivers". > + > --force: > By default, devices which are used by Linux - as indicated by having > routes in the routing table - cannot be modified. Using the --force > @@ -448,6 +451,21 @@ > if "Driver_str" in devices[d]: > unbind_one(d, force) > > +def restore_all_to_kernel(): -- Thanks, Anatoly