From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id ED4E71B3B3 for ; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 460B440002 for ; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 325A540008; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E643940002; Mon, 22 Apr 2019 17:52:58 +0200 (CEST) To: Neil Horman Cc: dev@dpdk.org, stephen@networkplumber.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> Date: Mon, 22 Apr 2019 17:52:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190422113420.GA22056@hmswarspite.think-freely.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Apr 2019 15:53:01 -0000 On 2019-04-22 13:34, Neil Horman wrote: >> +uint64_t __rte_experimental >> +rte_rand(void) > Do you really want to mark this as experimental? I know it will trigger the > symbol checker with a warning if you don't, but this function already existed > previously and was accepted as part of the ABI. Given that the prototype hasn't > changed, I think you just need to accept it as a non-experimental function > I'll remove the experimental tag and move it into the 19_05 section (without suggesting it should go into 19.05). That maneuver seems not to trigger any build warnings/errors. It's been a part of the API since forever, but it was never a part of the ABI. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 21C01A05D3 for ; Mon, 22 Apr 2019 17:53:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 570021B3BA; Mon, 22 Apr 2019 17:53:02 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by dpdk.org (Postfix) with ESMTP id ED4E71B3B3 for ; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 460B440002 for ; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 325A540008; Mon, 22 Apr 2019 17:53:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on bernadotte.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=disabled version=3.4.1 X-Spam-Score: -1.0 Received: from [192.168.1.59] (host-95-192-230-180.mobileonline.telia.com [95.192.230.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id E643940002; Mon, 22 Apr 2019 17:52:58 +0200 (CEST) To: Neil Horman Cc: dev@dpdk.org, stephen@networkplumber.org References: <20190419212138.17422-2-mattias.ronnblom@ericsson.com> <20190422113420.GA22056@hmswarspite.think-freely.org> From: =?UTF-8?Q?Mattias_R=c3=b6nnblom?= Message-ID: <5a7b8741-da7f-7322-e57f-59d00d7bcde2@ericsson.com> Date: Mon, 22 Apr 2019 17:52:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190422113420.GA22056@hmswarspite.think-freely.org> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP Subject: Re: [dpdk-dev] [RFC v2 1/2] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190422155258.gBRmPK1or8-otSyppJinSD34Lwj5j-mvgqXZm30XIN8@z> On 2019-04-22 13:34, Neil Horman wrote: >> +uint64_t __rte_experimental >> +rte_rand(void) > Do you really want to mark this as experimental? I know it will trigger the > symbol checker with a warning if you don't, but this function already existed > previously and was accepted as part of the ABI. Given that the prototype hasn't > changed, I think you just need to accept it as a non-experimental function > I'll remove the experimental tag and move it into the 19_05 section (without suggesting it should go into 19.05). That maneuver seems not to trigger any build warnings/errors. It's been a part of the API since forever, but it was never a part of the ABI.