From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF3F1A054F; Tue, 16 Mar 2021 17:37:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C76340A4B; Tue, 16 Mar 2021 17:37:23 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 928CA4069F for ; Tue, 16 Mar 2021 17:37:21 +0100 (CET) IronPort-SDR: BXPn39HdIO5PIWdkvnLOpngfynpoT2++z2a280fAWnFamnKghOd7SsxPRkZ27fwkfzDWhDCjS7 VufbCP4EGUVA== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="168564945" X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="168564945" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 09:37:20 -0700 IronPort-SDR: ibUEI+aBxJeHnekcgpRA7MsD60TCn2Do3sgdf/0JyUe/EE4C0+DsfNVufOJIA05W8PcACJh/q4 u1Plu7uyNOOA== X-IronPort-AV: E=Sophos;i="5.81,254,1610438400"; d="scan'208";a="405596571" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.11.157]) ([10.252.11.157]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2021 09:37:18 -0700 To: Thomas Monjalon , Qi Zhang , Andrew Rybchenko Cc: dev@dpdk.org, xiao.w.wang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com, bruce.richardson@intel.com References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210312121223.2028029-2-qi.z.zhang@intel.com> <93fd4fce-a961-8ccf-fd32-0386461e4e99@intel.com> <8879674.o8TafV64eK@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <5a7ee4c7-8027-93bd-2e3f-4073e2769018@intel.com> Date: Tue, 16 Mar 2021 16:37:14 +0000 MIME-Version: 1.0 In-Reply-To: <8879674.o8TafV64eK@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/8] ether: refine debug compile option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2021 1:39 PM, Thomas Monjalon wrote: > 16/03/2021 14:05, Ferruh Yigit: >> On 3/12/2021 12:12 PM, Qi Zhang wrote: >>> PMDs use RTE_LIBRTE__DEBUG_RX|TX as compile option to wrap >>> data path debug code. As .config has been removed since the meson build, >>> It is not friendly for new DPDK users to notice those debug options. >>> >>> The patch introduces below compile options for specific Rx/Tx data path >>> debug, so PMD can choose to reuse them to avoid maintain their own. >>> >>> - RTE_LIBRTE_ETHDEV_DEBUG_RX >>> - RTE_LIBRTE_ETHDEV_DEBUG_TX >>> >>> Also, all the compile options are documented on the overview page, so >>> users can easily find them. <...> >>> + >>> +- ``RTE_LIBRTE_ETHDEV_DEBUG`` (default **disabled**) >>> + >>> + Compile with debug code on data path. > > What is data path if not Rx or Tx? > >>> + >>> +- ``RTE_LIBRTE_ETHDEV_DEBUG_RX`` (default **disabled**) >>> + >>> + Compile with debug code on Rx data path. >>> + >>> +- ``RTE_LIBRTE_ETHDEV_DEBUG_TX`` (default **disabled**) >>> + >>> + Compile with debug code on Tx data path. > > In general, I think "LIBRTE_" is redundant and useless as macro prefix. > 'RTE_LIBRTE_ETHDEV_DEBUG' already exits, it enables datapath debug without distinguishing Rx or Tx. When we have _RX and _TX macro variants now, it may be possible to 1- get rid of 'RTE_LIBRTE_ETHDEV_DEBUG' macro and continue with fine grained RX & TX 2- Use 'RTE_LIBRTE_ETHDEV_DEBUG' as an alias to enable both RX & TX 3- Keep 'RTE_LIBRTE_ETHDEV_DEBUG' for ethdev layer datapath debug, and RX & TX variants for PMDs. I think (3) can be more backward compatible, and can be helpful to separate ethdev layer and PMD debugging, but no so strong opinion.