DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, Matan Azrad <matan@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "835703180@qq.com" <835703180@qq.com>
Subject: Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed
Date: Wed, 22 Jun 2022 10:46:57 +0200	[thread overview]
Message-ID: <5aa5d1d2-6ced-bde8-1f79-b402530a9ca3@redhat.com> (raw)
In-Reply-To: <23095133.hxa6pUQ8Du@thomas>



On 6/22/22 10:46, Thomas Monjalon wrote:
> 22/06/2022 10:11, Maxime Coquelin:
>>>>> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>>>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
>>>>> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv
>>>> *priv)
>>>>>                 rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED);
>>>>>         if (priv->err_intr_handle == NULL) {
>>>>>                 DRV_LOG(ERR, "Fail to allocate intr_handle");
>>>>> +             rte_errno = ENOMEM;
>>>
>>> Shouldn't rte_intr_instance_alloc set it?
>>
>> I think it makes sense, Thomas could you drop the patch while pulling my
>> branch? Or do you prefer I remove it directly from my tree?
> 
> I'll drop it, no problem.
> 
> 
> 

Thanks, I'll update its patchwork status to change requested

Maxime


      reply	other threads:[~2022-06-22  8:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-12 14:09 835703180
2022-06-14  9:43 ` Maxime Coquelin
2022-06-14 13:36   ` [PATCH V2] " 835703180
2022-06-14 13:50     ` Maxime Coquelin
2022-06-14 13:48   ` 835703180
2022-06-15  7:47     ` Matan Azrad
2022-06-22  8:03   ` [PATCH] " Matan Azrad
2022-06-22  8:11     ` Maxime Coquelin
2022-06-22  8:46       ` Thomas Monjalon
2022-06-22  8:46         ` Maxime Coquelin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5aa5d1d2-6ced-bde8-1f79-b402530a9ca3@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=835703180@qq.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).