From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F5DCA04FD; Wed, 22 Jun 2022 10:47:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 403264069C; Wed, 22 Jun 2022 10:47:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1B41640689 for ; Wed, 22 Jun 2022 10:47:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655887623; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbWoqdcu6n7gPiAZaMW99ACWoZkXxPxswy3B5kvCtN8=; b=iyVXkdFqu6e4Umf+5Fws2/Th01Gniux5YxXNvmknc68l0doQTr+5dS18k8Yktgpeum9r+P pefrVid3F3CFzdk4oZ1r9h9Tny0EdKfraYabySQ6mEKvqb8YAKkbPxbNtRQ3iBHRF9bgya lbZ8rL3A7VnGZOvpT4BAtl3nMECLkNg= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-VZg87a7CPmyVrbOjuP_l4A-1; Wed, 22 Jun 2022 04:46:59 -0400 X-MC-Unique: VZg87a7CPmyVrbOjuP_l4A-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 892B929DD995; Wed, 22 Jun 2022 08:46:59 +0000 (UTC) Received: from [10.39.208.40] (unknown [10.39.208.40]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C1B7740334D; Wed, 22 Jun 2022 08:46:58 +0000 (UTC) Message-ID: <5aa5d1d2-6ced-bde8-1f79-b402530a9ca3@redhat.com> Date: Wed, 22 Jun 2022 10:46:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] vdpa/mlx5: return correct error code after rte_intr_instance_alloc failed To: Thomas Monjalon , Matan Azrad Cc: "dev@dpdk.org" , "835703180@qq.com" <835703180@qq.com> References: <0dfe8a28-869b-1454-8fec-7634e7a87f8d@redhat.com> <23095133.hxa6pUQ8Du@thomas> From: Maxime Coquelin In-Reply-To: <23095133.hxa6pUQ8Du@thomas> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/22/22 10:46, Thomas Monjalon wrote: > 22/06/2022 10:11, Maxime Coquelin: >>>>> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>>>> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c >>>>> @@ -395,6 +395,7 @@ mlx5_vdpa_err_event_setup(struct mlx5_vdpa_priv >>>> *priv) >>>>> rte_intr_instance_alloc(RTE_INTR_INSTANCE_F_SHARED); >>>>> if (priv->err_intr_handle == NULL) { >>>>> DRV_LOG(ERR, "Fail to allocate intr_handle"); >>>>> + rte_errno = ENOMEM; >>> >>> Shouldn't rte_intr_instance_alloc set it? >> >> I think it makes sense, Thomas could you drop the patch while pulling my >> branch? Or do you prefer I remove it directly from my tree? > > I'll drop it, no problem. > > > Thanks, I'll update its patchwork status to change requested Maxime