From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52D25A04C3; Fri, 22 Nov 2019 12:54:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BFD62C08; Fri, 22 Nov 2019 12:54:13 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id D37AD1DBC for ; Fri, 22 Nov 2019 12:54:10 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 60892100088; Fri, 22 Nov 2019 11:54:08 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 22 Nov 2019 11:53:59 +0000 To: Thomas Monjalon CC: Ferruh Yigit , Pavan Nikhilesh , Neil Horman , "John McNamara" , Marko Kovacevic , , , , , References: <1574165145-23960-1-git-send-email-arybchenko@solarflare.com> <3628380.zSPWDRPf13@xps> <7f1ca296-d4b0-e11b-7a70-50379de831c4@solarflare.com> <2061551.U1huFxGPsU@xps> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <5aa70bf7-9afd-4c5d-708c-c922288755e8@solarflare.com> Date: Fri, 22 Nov 2019 14:53:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <2061551.U1huFxGPsU@xps> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25058.003 X-TM-AS-Result: No-19.049400-8.000000-10 X-TMASE-MatchedRID: IeZYkn8zfFr4ECMHJTM/ufZvT2zYoYOwofZV/2Xa0cKNTrsIz649BGcu Y4ix4PoK+9E9zjm1EULClgCVDis8Kh2k1vtl2oj3JNzc11O35npbnEbdz0P1q+QydRUvl3QTI8N 6TI0jBjudssHnNcMsHfBkEhMPw8DLGHMruoCVNIuEhXJ95BMUPN36/RwkiJ0fbPfGfHxv+pEnnR Ws3D0zibOxW2s2drMDwH1WhgCHp+Zv6Yq1TxQF1D2gUycsvOMFvMRNh9hLjFnwOeqRlsRlmG7+J Qzwn8WJHJLhN9mPjBdOlL/9K/ggR0RmJOOe4rUo2fov7TwhL8mhhKooH+/fy6ltwC81AJoF9J+A LrLsP8CnG3qCveF9dis33itPxcNl7q7LX1RUOwe6iJsmkdGsWZ3BxJKbQwMYlSFPfwjN9pFIeBR Uygi/YU3tSJf6CPwtTNoQFuQPKQJp7EHWyY9c1o6MisxJraxHUb4EdIZGxuAda1Vk3RqxODp0RQ 1/bKBcsWhm33jk2GsZqa58/h9WuWIuNMNBksCvfTWvG3pXL4TyCvICuK46clfLpI8fOvDuS717h L/58vbJcu8gej23tN7p9XeveoAAuqdku9gD4hG8coKUcaOOvSlj52CeQMtqIeOLVF/ekdDCbx8T WnQwX8UKqxep1BENEOn6dB21WwlrvYvNXFMpBddFDwSoLmcbcuFRT+prg4aZfDRE1uqSgjwAIQx bAtyDeiAXcxwYxzxwwx7fe7FfbO4Kd5Z4mUYvqHH6xh+Zp947F3ZcdQmMKwQsw9A3PIlLFv42S2 Mw7ZfBTV/sma2KskECImil5O/QKerAqZTShjOeAiCmPx4NwLTrdaH1ZWqC1B0Hk1Q1KyJXaDn6D hA2Ao2j49Ftap9EOwBXM346/+zllXix4R6LdMtZuPqqeV1R/23XdbEWOdbeKvH6McaDKM/9za0y 1DHl X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--19.049400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25058.003 X-MDID: 1574423650-gUwVXwLqJ-rV Subject: Re: [dpdk-dev] [PATCH v2 3/3] ethdev: improve flow mark Rx offload deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/22/19 2:15 PM, Thomas Monjalon wrote: > 22/11/2019 11:12, Andrew Rybchenko: >> On 11/22/19 1:01 AM, Thomas Monjalon wrote: >>> 19/11/2019 13:12, Andrew Rybchenko: >>>> The deprecation notice is required since it adds more requirements >>>> when RTE flow mark and flag actions may be used and require >>>> changes in applications. >>> I am still not sure what is the best solution here. >>> I continued to think about it in this thread: >>> http://mails.dpdk.org/archives/dev/2019-November/151960.html >>> >>> I think we cannot require any application change until 20.11 >>> in order to keep API (and behaviour) compatibility. >> Expected, but still very disappointing. >> >> The feature is implemented by Pavan (@ Marvell), supported by me, >> used by Qi (@ Intel), looks better than alternatives from application >> developer point of view [1] and finally postponed for 1 year without really >> strong motivation. > I see different valuable point of views. This is enough motivation. It looks like I miss it in previous discussion, I would be thankful if you give me links to read or hints how to find. > And no, it is not postponed by one year. > Next release can implement a new API. > >> I disagree that it is tightly related to moving >> mark/flag to >> dynamic field/flag and absolutely blocked by it. Yes, I know that the are >> concerns from the very beginning, but the problem is explained [2] and clear >> and no full-featured alternative solution is suggested. Solution suggested >> by Ori has many significant drawbacks as explained in [2] and highlighted >> in further discussion. > I disagree with working only on mark action while there are a lot > of other configs which have to be implemented in drivers. > > The reality is that some drivers decided to have some "optimizations" > disabling some features, and you want the application to opt-in > in order to allow your optimized paths. Strictly speaking it is not about driver optimized paths only, but HW configuration as well which can be done on start-up only (not dynamic) and could be per-queue in fact. > Note that opt-in is different of really enabling an offload. > For some basic port-level features like RSS hash, > it is enabled with an offload flag before starting the port, > acting as an opt-in. Could you highlight the difference between opt-in and offload. What is the key difference which makes one solution better than another? Why different mechanism is required? > Some features have some dedicated API, which may be enabled after > starting the port, and no way to opt-in (or opt-out) before start. It sounds like you have examples in your mind. Please, share. > A lot of features are using rte_flow API which is in this situation. > If we take the opt-in path, let's not do it only for the mark action, > but let's create a real API for it: > rte_eth_dev_optin() > rte_eth_dev_optinall() > rte_eth_dev_optoutl() Introducing new types of controls would make configuration more and more complex. I think that many different types of control would over-complicate it. May be it is unavoidable, but it should be clear why the problem cannot be solved using existing types of controls (e.g. offloads). > I think the motivation is strong enough. > >> [1] http://inbox.dpdk.org/dev/1573203631946.15959@kth.se/ >> [2] >> http://inbox.dpdk.org/dev/f170105b-9c60-1b04-cb18-52e0951ddcdb@solarflare.com/ >> >>> If something would be implemented in 20.02, >>> it must be a new and optional API. >> Flow mark and flag may work without the offload with some drivers, >> but some drivers require the offload to make it work. Flow API error >> should contain message which says that the offload is disabled and >> must be enabled. > Yes, the PMD should return an explicit error about a feature being disabled. > How does it impact ethdev API? It is still the offload discussed in the deprecation notice. The solution is far from ideal, since allows the difference in PMDs behaviour and an application debugged on one PMD may not work using another PMD (unfortunately it is true in any case, but such definition makes it 100% legal). >>> That's why I think no deprecation notice is required. >>> >>> [...] >>>> +* ethdev: New offload flag ``DEV_RX_OFFLOAD_FLOW_MARK`` will be added in 20.02. >>>> + This will provide application an information if ``RTE_FLOW_ACTION_TYPE_MARK`` >>>> + or ``RTE_FLOW_ACTION_TYPE_FLAG`` is supported and, what is more important, >>>> + allow an application to let PMD know that it would like to use these >>>> + features. >>>> + PMD may use the information to choose optimal datapath implementation and >>>> + configure HW appropriately to optimize performance and/or resources usage.