From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5F9491200A for ; Sun, 21 Jan 2018 23:07:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2018 14:07:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,393,1511856000"; d="scan'208";a="21468171" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.1.152]) ([10.252.1.152]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jan 2018 14:07:57 -0800 To: Hemant Agrawal , dev@dpdk.org References: <1514284608-9263-1-git-send-email-hemant.agrawal@nxp.com> <1516255980-25092-1-git-send-email-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: <5ab068df-3263-d82b-750f-13a8ce8b8723@intel.com> Date: Sun, 21 Jan 2018 22:07:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1516255980-25092-1-git-send-email-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/3] kni: support for MAC addr change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 22:08:00 -0000 On 1/18/2018 6:12 AM, Hemant Agrawal wrote: > This patch adds following: > 1. Option to configure the mac address during create. Generate random > address only if the user has not provided any valid address. > 2. Inform usespace, if mac address is being changed in linux. > 3. Implement default handling of mac address change in the corresponding > ethernet device. > > Signed-off-by: Hemant Agrawal <...> > @@ -530,6 +556,14 @@ rte_kni_handle_request(struct rte_kni *kni) > req->result = kni->ops.config_network_if(\ > kni->ops.port_id, req->if_up); > break; > + case RTE_KNI_REQ_CHANGE_MAC_ADDR: /* Change MAC Address */ > + if (kni->ops.config_mac_address) > + req->result = kni->ops.config_mac_address( > + kni->ops.port_id, req->mac_addr); > + else if (kni->ops.port_id != UINT16_MAX) This won't be enough. rte_kni_alloc() can be called with NULL ops value. For that case m_ctx->ops won't be updated. And by default ops will have all zeros, not sure how to differentiate it from real port_id zero.