From: "Björn Töpel" <bjorn.topel@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
helin.zhang@intel.com
Cc: "Xu, Qian Q" <qian.q.xu@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: force CRC stripping for i40evf
Date: Wed, 9 Nov 2016 11:05:57 +0100 [thread overview]
Message-ID: <5ad83b54-f13b-787e-c056-958f5cb8bd61@intel.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB9772583F0D2F6C@irsmsx105.ger.corp.intel.com>
Adding Helin to the conversation.
> That's a common problem across Intel VF devices. Bothe igb and ixgbe
> overcomes that problem just by forcing ' rxmode.hw_strip_crc = 1;' at
> PMD itself:
[...]
> Wonder, can't i40e VF do the same?
Right, however, and this (silent failure) approach was rejected by the
maintainers. Please, refer to this thread:
http://dpdk.org/ml/archives/dev/2016-April/037523.html
> BTW, all other examples would experience same problem too, right?
Correct, so the broader question would be "what is the correct behavior
for an example application, when a port configuration isn't supported by
the hardware?".
My stand, FWIW, is that igb and ixgbe should have the same semantics as
i40e currently has, i.e. return an error to the user if the port is
mis-configured, NOT changing the setting behind the users back.
Björn
next prev parent reply other threads:[~2016-11-09 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 8:23 Björn Töpel
2016-11-09 8:37 ` Yao, Lei A
2016-11-09 9:28 ` Thomas Monjalon
2016-11-09 9:39 ` Björn Töpel
2016-11-09 9:46 ` Ananyev, Konstantin
2016-11-09 10:05 ` Björn Töpel [this message]
2016-11-09 10:22 ` Thomas Monjalon
2016-11-09 11:08 ` Ananyev, Konstantin
2016-11-09 11:27 ` Björn Töpel
2016-11-09 12:13 ` Ananyev, Konstantin
2016-11-09 13:01 ` Zhang, Helin
2016-11-09 13:09 ` Björn Töpel
2016-11-10 5:49 ` Yao, Lei A
2016-11-10 6:17 ` Björn Töpel
2016-11-10 7:55 ` Thomas Monjalon
2016-11-10 7:59 ` Björn Töpel
2016-11-10 13:50 Mori, Naoyuki
2016-11-10 14:32 ` Thomas Monjalon
2016-11-10 14:43 ` Mori, Naoyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad83b54-f13b-787e-c056-958f5cb8bd61@intel.com \
--to=bjorn.topel@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=lei.a.yao@intel.com \
--cc=qian.q.xu@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).