From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A19FCA0547; Tue, 19 Oct 2021 18:17:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E998410FC; Tue, 19 Oct 2021 18:17:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 581D84003E; Tue, 19 Oct 2021 18:17:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="292024927" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="292024927" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 09:12:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="574229524" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 19 Oct 2021 09:11:58 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 09:11:58 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 09:11:58 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 09:11:58 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.40) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 09:11:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jIdhw89RHE3T9+HCuyJYYYw6g3Nod8JcPhYkVWJDFrgyn06fpxoson6oOm8ykbQ1WL/AFT6NtAXewrDqwDIEHlIsuVHiz7vy1R3i9Kvg5Jdan+i9dyGL5tB8zFPVKri17k8/1/fjA9hJZC5TTTpL43WhRc1lcOG1KsRqphaIXjxpbrQcfu8OiG2UW7LjaWCa4VV9VJemInwIGvLuWn2tMW9HAFBhlO5MRHWM63NEl9SHBIIuycP3BEWfoIiUf7BRxc75gh5/RDPh6//69OehHuPxT3VHldJ6Fr/bOGBJNyQd27kGTW9p9nbJBvbzLokVqCljjn4JYyjMqGF2whZ9iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zm7o0mpmGwBuR4xiY2Cvy2ruHlQBkSDVv6GEY5+aHtU=; b=SyMCQYD09A4epILyMj69wzdvtXFHXb1DgLlBxNKj2gistdxhUt+mThK553meaC4zefVatdEG/KkzKlpI0itE55KeJHuNnyz9YHpzvChMJddTO1gKrZ++ZE+/OwRX06+n197GrIYEOXBvmr7ykqztG+wtEuMyh+GQ7VwoCEDFJ+CyqhV0aoR+R0PAJqVYnu+eTGvurFZjrJhTO52VU7dqd9zqO3XzyumHcnpB7d33yLiqAMdbOLDDAuGnGXDRHjjRahcrv8mv+2XKBDYXViUnXPShQx/6gbwN3gVGyGCBZJNfCw1daMGINEw4nUJ+GiW95LcbK+jKlmt0+da2IhP9uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zm7o0mpmGwBuR4xiY2Cvy2ruHlQBkSDVv6GEY5+aHtU=; b=eKDFSGJFWCwHARzoejdGU/Uj2xUU1wp+MefUCq4D1bGDh3ClxI4b0g9Pq0KiVgLYOrkyFRiJHUvmqyWvfAFnC5sAPzF0NBXoUWngBooJShUNulikcfvE4q2u3lfls6XfIJkq87Fcae+fEgAxQVTcSp4/uD9nxODoh62xVK01nZ8= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5110.namprd11.prod.outlook.com (2603:10b6:510:3f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Tue, 19 Oct 2021 16:11:56 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 16:11:56 +0000 Message-ID: <5aef690d-2da9-777f-3d2a-a162676e2c24@intel.com> Date: Tue, 19 Oct 2021 17:11:48 +0100 Content-Language: en-US To: , Xiaoyun Li CC: , , "Singh, Jasvinder" , "Dumitrescu, Cristian" References: <20211012073624.399404-1-skori@marvell.com> <20211012083317.399870-1-skori@marvell.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211012083317.399870-1-skori@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P250CA0024.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::29) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P250CA0024.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 16:11:54 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc34b0b0-77aa-4b2a-0292-08d9931b2c31 X-MS-TrafficTypeDiagnostic: PH0PR11MB5110: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2449; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OxlBkGyLuxtfMy+yi5XPxaTrQPx9mJCXWVKY4osd48Ly55e6Q6QHdDrKF7MVcGJX/Zl3WT6ZGywbR7euQZO7F05Sa/ZM3BWzVgXGEJnHxWv+HiysSwLA22Bles9le5nZkP91qJ/Yu+SPuUsQ5egbE2ezllvnlh859ic/1JEHOh7NyaVLaHZeTqBp/dGEsCnrTNpRET1CS+xOMSper1L7QW28fUDCwl4D3dEQ2MQyWpf7X9uCYCjiSKUZI1i5K8Ov6sTjg9CSyGtu671YmNR+OvwRMTHMjxgRLPyXF8j5xuyyjIdPbWXFn6CaFwb+R3Usr/KuAeKy5hZ5m7EJZ/txl9jdumKLUDNGC6OPc/M5ks7IaLprGpctzanGKoAqlUVMvEDvk8vjKX9xegI+W4IhzXUR5ZTyUL+V1b3blCqpIhhXvR6RHF3hAZWfToqaXPptm5JeuVZyT4XfRs83YoAQm1mOQ3GLVYE2NovcqbeYXMP10LSTCm2SIDPZfxrRqEYgnSQbLbWpE9TLxoPnlftsMXGKjyjFotig4vSnIyHf+ZmJvhUm3hRB8HRcYHBmfJf8dNJaQr6MQ4WA6Twq4eERXxoPuSQMHJ/65tjJFKaUPcK7E5NugounMUraMC95zfvgASXwYxh/6kMZ/9NSr8Pora0YZDyexXhhNTqgzjAz7JJJALFDrx6ersqdZcEmfaEf1pUuqTsPkTItV/R81e5XiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(186003)(8676002)(8936002)(26005)(53546011)(4326008)(66946007)(5660300002)(44832011)(956004)(2616005)(66556008)(66476007)(508600001)(316002)(6486002)(2906002)(54906003)(37006003)(16576012)(6636002)(38100700002)(31696002)(31686004)(36756003)(83380400001)(6862004)(86362001)(6666004)(82960400001)(107886003)(4744005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bU1LSG0yYmF3SkdDL3VHM1BneTZVeTNUTklaNHh5cFlHT2NBTzdWRFVGMmJr?= =?utf-8?B?SWg2RlRVaG13cVpWd0c2YURpWllxZ2IxbzZTWWxiREVYa1loNlhtLzFyR1Ry?= =?utf-8?B?QTVSalZzeUV5cTNHUVc2QUpIVjR1aWxEMjFuOElQYVFhV1BReUxPdEVZRk9R?= =?utf-8?B?aHVDZVJ4UjI1bklFUnNWNm1hT2ZkaTZWZFBIb3lyTFkvM2NhSWhoZ0sxZmR4?= =?utf-8?B?ZlA0V2JweVo5cFhaa0RwTjVJOVBrN1R6c20vMEh5cFVpQnlSMmNRL2wzS0hO?= =?utf-8?B?WDM2bUFGTXNneFhHeGZ6Mk1PWUxnVWtOUEVXS1lnWUtQZHkxZ0RVTkFXeEo2?= =?utf-8?B?NjVOOVlHTjZMR3FuTDN3WEFibWUvSG9mSDNyMDhSeWFaZk13Nnk3NXJWRUdh?= =?utf-8?B?ME44M21nZHN5TkErZXlOR3ZxYlVwY3Q5WlB6MmtpUGtqMUpUYmt2UlJ6YzVj?= =?utf-8?B?VlpJSFlyMmVBQjcwbnVxR3JKS3JEOFd6L3NxOUhyQitqNWJIL2hJcUZXMS9G?= =?utf-8?B?VnFqeTB1MzZ3NXUxUFZUdTd2L0t3eFNna05nWGRxeHVmODhTVzgxRzg5aGZl?= =?utf-8?B?YUI2RnpGYVdBdEZZY1FrY1ZFQ3FRQktOUERpVXdqcmZXUEVqdllvWWI5Vk1L?= =?utf-8?B?dTVwZFNuSnhmd285amxqUzV3K0JseHd2ZHhlVitMZzlUQ2g0K1k1aXdoaVdk?= =?utf-8?B?SDYwU3NlUmg5SW9mRmNKOHRTRWFwQmhmdFFjTU1zYythYmNhc1AxV2NCS2NL?= =?utf-8?B?MkFpUDdES1ZJRVBOVEY4bVZrbVExa05vUnY2ditFTlZpZVBTdVd1YVRRZnBz?= =?utf-8?B?S3dOSkFuZVh0dXQwWDFHNEc2azl2MUxsVW9BTEJWSDhyd3ppOS8weGFGUm9j?= =?utf-8?B?eVNiR2c1RGVGTjlEQ3JYcU0rdmdtTjFtY2VGbjhsSko0VE5zY0oyNGdyRlJT?= =?utf-8?B?cDlTQklobG90UWZFWForKzhLUU16TzkwUGJpb2NGOUNZWFZUbmkxelVuT0M2?= =?utf-8?B?Z2V1YWJzUWFFRDYyWGRFM285RkRyazl6WVgyUjhnMHFVUElWTGZwbWZma3N2?= =?utf-8?B?LzZocXhrTUVMVDdvM1JXMTM4UlJOSW1DaU1jQU01aDJpcnRNRmNacTdMMlp6?= =?utf-8?B?L2p6a2dPeWhxRXVTanliRXVzVmRqbk5JaFVFR3c1b1lHUXlhZldva1JBREVt?= =?utf-8?B?ZThaeGoyVEhnYk9OSVk3a0MveDBoRmRySmlVdTNaWnBkYkdCRW9pNkRRYkhr?= =?utf-8?B?dU01Z0FFWXlObG1PV2VkcU1waW1EbGhET1RWaWVEZ25CSjdRZU5OaFpKczdW?= =?utf-8?B?Qm51YWYyWE45ajhucnY1QmVvSnpOemd6eEl2S3RvelVwc0l5akJyMHFnL2lV?= =?utf-8?B?RE1lbStWRmxCa050bWY5elZjb1YzSUhOT2RrdWROV0pPekNrWDV0YXcwYXJO?= =?utf-8?B?ZU9XZWJWRS9TQ0U1YVJUUGlnRFJqMFJKYmJpNFhiTU4wQjNidlFFYzFtcUEw?= =?utf-8?B?dW51OHVWaVBXV2twVDJ5RlhVNG1PTFordTIvSEVRQ0p0Z0d1WUVnTXZIZkNT?= =?utf-8?B?UGhWN3p6cXBqN2NYOE5YNkswS3pJQk95UEpCYmhwY3JHZVFqWUx2YzBPakZh?= =?utf-8?B?cHd2NnlCNDBwcUM2cU5oWjFSRjhjRkFrRENmdjFpUGYydXNsUkZSOFZCb2Fo?= =?utf-8?B?MkxnQVZEQVlYRjNHZ3dFYzVVQUNvQnVPQisrWm1ieStWSzc3Unl3RVZodVhI?= =?utf-8?B?WkhEV2hFcUZ4Y3M3ellCdmZ1OHY2djNiZStkY1RjdFFWOUxXUDdVcEdmVDJw?= =?utf-8?B?MTJyaE9pM1VnL2ttQjFhbHNsd1QzZEwwbG9ZQWNMTGtqMmdjd1c2TmFxRFN0?= =?utf-8?B?TzE0YWxIY1dMcE9ISXVvcFdyaUdFRWcwY3FuSWxCeGRVWnlCS0RHSVhOWnNt?= =?utf-8?B?YkJCbXllTDVkTUFIbUxsZmNIL3RET3REdGJlT1gxRVY1VVM2bk0yWWJETE14?= =?utf-8?B?WHlZWkxDYXdEM3lQaFFyV1BSL0Z4VXlOOUJxQkVqUiswL1RzNTBraDF3dmpZ?= =?utf-8?B?UHpFN1lpSUsraG5ISnZvbGU3QVVSdERsMCtmWlZXWGtRbVBhc2Rod3lVSVhq?= =?utf-8?B?V28yclJJb2V6eFVGcXBINkZLQ2kwV25WcURVVmdESFRlUm1XUGNtWVl1T0dI?= =?utf-8?Q?+2i1NEweVvABsAMOEf5W8cg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: bc34b0b0-77aa-4b2a-0292-08d9931b2c31 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 16:11:56.7979 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BRsUd8UZjUzskgKeF7jze1A/g+a2oUCVnHa8bIvaYGeGhNZ0OOBQN9DT4ze9rZlps27l/uchwIKWPOdSo5qwyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5110 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/1] app/testpmd: fix invalid memory access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/2021 9:33 AM, skori@marvell.com wrote: > From: Sunil Kumar Kori > > During parsing of DSCP entries, memory is allocated and assigned > to *dscp_table. Later on, same memory is accessed using > *dscp_table[i++]. > > Due to higher precedence for array subscript, dscp_table[i++] will > be executed first which actually does not point to the same memory > which was allocated previously for DSCP table entries. > Of course, thanks for the fix. > Cc: stable@dpdk.org > > Fixes: 459463ae6c26 ("app/testpmd: fix memory allocation for DSCP table") > > Signed-off-by: Sunil Kumar Kori Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.