From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83804439D3; Fri, 26 Jan 2024 17:54:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E5A740289; Fri, 26 Jan 2024 17:54:42 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id 805074021D for ; Fri, 26 Jan 2024 17:54:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ln7GOfOHWnJJk/7pDGLNg7ika+IwEFbCdzOp07cX4LGHkN4TBxdK+9uofC2Ihesw3761l8bOxGoPz7gDgpqwEqXrGCUAuzvjuyxIjD57B/muZuiVBQoaOwde142Kbh9Hv9c/RbgzKEQfuMZ/ByjCbxihnIt5R1pKmIYDM7L8t462ROaEiaSjosFEPzwz0Ipq99w+4vHw9FrEQ3XmySFmOoHARmy7nmnznG+lYjjwDthVEHMRPJ4AwOI1pNVIG3ePcqKAnwgZ0F/7ZpLKnS2ffMw258lxhjYhNYZjlSJTh4+abWHkPreiG2nYfEvIU2bX1Z/4yvcOKy6Mg5RiDd3VoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/K06HnmEpyxZ5dA94cgXeC42SJyhxoiKibd9TM0YJDc=; b=Jozw2CPHxUqe23mtiUvnvGOkf1tlVAFROVmlWNS7e4YN9J62ktxvG8L7e412f50Jzgds/zggX3H4cjtIqHLIyMbVvlkcsgLDrha7t3Oe87Zqzc+kr83YoCAS5UBucK3yi+/ZN+0v11EFK7PlUFu29fSrb9serJk7Wx6Z2H/a2Q43IrKC2eA+gHs1yJHDr/YtCdhqN6kmtK8SDqdb9/4Ek/O59jP6U1cLQmRFEwDswg6bB2wZC/lfaJnN8wEq8j5Z1kEymKEHubGLCnh51V/Vip+/o66vC/64pdkt/UFAwAQ2zWM6MotYWp6iDeXTcr/c/Q1FrW+j+OicRzGwUgEKBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/K06HnmEpyxZ5dA94cgXeC42SJyhxoiKibd9TM0YJDc=; b=npC2eikB77y2OFBzS2rw5eq9/j+RD/bbsa2pH6jM+ASb3OG2pMkH60Ek2J+llBWQ6u1ohulbFXxhRB+KIQlLbgmkMfSfe0mIOlMIZLONkIcWohe8/LMMJD/QS61QUb27fWy+XveEeKssMf1VyegFukO8qifdo+sNeZObfz9Z98w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8087.namprd12.prod.outlook.com (2603:10b6:208:401::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.37; Fri, 26 Jan 2024 16:54:35 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::815a:45e6:cf5e:479f%4]) with mapi id 15.20.7228.027; Fri, 26 Jan 2024 16:54:35 +0000 Message-ID: <5afa7ecf-254f-424b-9a58-1548e8ef270d@amd.com> Date: Fri, 26 Jan 2024 16:54:30 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] ethdev: add the check for PTP capability Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru, liuyonglong@huawei.com, Gagandeep Singh , Hemant Agrawal , Simei Su , Qi Zhang , Qiming Yang , Junfeng Guo References: <20220628133959.21381-1-liudongdong3@huawei.com> <20230817084226.55327-1-lihuisong@huawei.com> <1834a6a9-ef92-4a67-a987-490151cf5380@amd.com> <242e8583-969e-d8ca-2dd4-80e8cf73a662@huawei.com> <0d7f429c-8862-4f16-b7e5-46d69581f54f@amd.com> <3a11b30d-346f-446f-903a-5a56cbae3853@amd.com> <665b0b6e-1ad9-a692-39cb-9e45e6b78b08@huawei.com> <7ecc6f3b-78f8-6421-307d-2c6c484c6109@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <7ecc6f3b-78f8-6421-307d-2c6c484c6109@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8087:EE_ X-MS-Office365-Filtering-Correlation-Id: ca61b827-6d0d-4843-790e-08dc1e8f79b0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TGw+RXoSZuhCvg1cLWBNyFUWrpJh5anh8XCU8E42hgz+KTiNUInPIVQagAAjqJFTdBuLRHwAGMo51NJKQvp79uKwTAyqtnX0nydpLqWC4NWOt1BgBPBmBUAQI8EtLk/ZP4Iw+WSFTWcZnMtNB4QRGS0zQ/ycEOqbENfwDU7NVbI+f44L65voSf/m/Mt2P2scSNDDer3hzAEQbaU5MZTaNBfz4gXH1rrHBMYkqEZ1E8mw/o/5gxFA/xHHGmfK+VjxBRMAk2Aai5ekJx8ziOHPnovbSDKNxaqwp7uFxb0p1YgU6+HJpFFsrmqKYq7xz6kVZfuyO75pedE6THtL3bO2FV+IiFsWQRkxQukvWrNRxY59kuI8N8/j7r4tpYQ5c9dj3oKAppATMq2zyHPS1HDh9YyoaX7g6wUXHOd1aBypkkCOu8iNAjpY3WdTcMZ0xmziwje06eZQNVRqQZXdM2fKx5m+Ju/sDKeWp+D2O5Jl/8aIDm9JZCRgKRCk8+DX/MAG7H2v+0Q5QnJk6qBQGj5lkbJmAtqhlHUvVkF7UkDRFR8f5ovyEDSEmsbJPV8NZB8gp7rIdMD89ZOC55X3ghrq6rmv1RQY7rMn+qQx/NFe1NzSGrgbodIZ9fT/XEi/FHAfXUCbxEDGWZQM69BB9P0GGA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(376002)(396003)(136003)(366004)(230922051799003)(64100799003)(1800799012)(451199024)(186009)(6512007)(7416002)(44832011)(6506007)(53546011)(26005)(83380400001)(6666004)(2616005)(41300700001)(8676002)(8936002)(5660300002)(316002)(2906002)(54906003)(4326008)(86362001)(36756003)(66556008)(66476007)(31696002)(478600001)(6486002)(31686004)(66946007)(38100700002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3VJN0xGQW4rYm8ra3R0QU5TblIvQjlvZ3RuRWFMZnBybEFFYlV3REFPSVp0?= =?utf-8?B?U0ZwRkVKYzF3WFZjazYwenZ4bkowTXhxWTdCNXZ2ZUpOVGE2UFRMR0w1TTZx?= =?utf-8?B?MGREWkoyRHd3bDhjN1hjamFTckJ5WW5qL29EWjd0b1JpclZESU5yNFN2NmxO?= =?utf-8?B?ODhrcGNYdGxmMU5ZNm12RjcreXR5UjZhaGpZTnZoNzg0YXgvSUxrdVAxUjlB?= =?utf-8?B?TGtWSnZLQU9kd3JCY00wV1U3U3lzSXdSY0k0QVkrNFoxYUJJUE1Hb1czSjNt?= =?utf-8?B?MnIwQzcxTHk3MTgrRzNLZzQ5Q2p5K08yUS9QdkJZdElqRjFHcWxFRHMrT2Jq?= =?utf-8?B?QVNUbmgyWWQ5QlpzVWZ4b0dYQS9HUWlQL3BZSVBmdWV2RUs1WjhZaXFMMFNF?= =?utf-8?B?bHAvUGRiNjJaM1RYT0V0ZFlFMFRVWDk0dll2d1ZpcjRCbDBqelhPSTN5bC9m?= =?utf-8?B?aDVJb0pBNWEvemhyeFhicHBZWjA3ZHhUUU9OOXNuN1JHWXY4Tldaa3hEZTVq?= =?utf-8?B?TEhyZ2w0dXlQVXk0MjBVSUtnenJqOFFEbkxaSVREMzY2d05PVld1RFhkWWIz?= =?utf-8?B?bFc4RzZwMDJhZVRQREpXNk1ZeW5SM0s4RUh6U0hWV0hDV3hrT1E0U2pvZXY0?= =?utf-8?B?QUppYSt2c2tXYXZUb3c1WS83VTk1TEVwdHFERUJhSFhDYlJLc2Z2Mmc2V0J3?= =?utf-8?B?V3RocWwyamJFL1BlT1VyMjNkZS9TQ1ZZUVVqbDB4VDRWOEdZbTVyeHFJRGs0?= =?utf-8?B?MGRTYmJ0ckx5UHJHSDVjUkxjYWVNVExJc1ZuY1orOWlRNyt0R05vRm01R3Nk?= =?utf-8?B?WEdnVlV1ZE1QeUJqOWpKZGJRSlM0c3lTeWJmblFCNXNRWEtKZWx5K1BJOGhl?= =?utf-8?B?UERsamtjZnZ6anUvV0FJSzVsU01hbC9oMlA5TS9UT05XQXNWMjRidCtDbkJQ?= =?utf-8?B?M2NPU2JnMUZZd1dJdlRpTTU2dm9xcHY2Q1FWRkJLOXdtN3dWWEZONnBHTnJR?= =?utf-8?B?ZGcrdi9VbXR5T3JVRHFrM0Y4NjJmSitRbUFZRjMyRDI4UEU2TkFpYStyRG03?= =?utf-8?B?amN0bFlvRkEyUWlCdHJrSm42SEhXWUlxeXFVWnNDaVRWdmdkeEQrUWFjOWpX?= =?utf-8?B?K0VZMGhnOGRiSG0wUWdPNjdrbExYbmdHWlI0cDNCUStKV3Jmb0F5QXpTWFJr?= =?utf-8?B?UFUyaHdOclZrWitzT0dNam40UHBpZmJjaGNmVTc1NHphVm1TdEhaQzR3QjUy?= =?utf-8?B?NjNNRVJWbCtDZzNBeUdkQURqN2h1b1phenFSUkExcDBQUElDWlVFMWgvaUpV?= =?utf-8?B?bTQ1RSt6N204MW12NnM5bzdSRnpSWS9ldUNBZ2orWDYvYXdTaVk4MUUyNWFl?= =?utf-8?B?ek94RUdkbUtJRWdtMjdVdHNGQzRXSnBBWlloMlJUc2s1V1p5OWRSSnpDSi8r?= =?utf-8?B?Q0lGYndwM050WUVXRkxpZXo1NmFzaHdXNUtROStkT0lWZVZhYmZmbVFHd1Mv?= =?utf-8?B?RVU5WEJJVGVtcExSV2NQdkROakJCb2QvbmxUWUQ1SUJGUVFHb3ovWkpwcHBV?= =?utf-8?B?Vnd5bm91cE9RME9jWVFyalh4ZmRvNjVuVzYyZlNTdXRlMmh2MEVTeWswLzlL?= =?utf-8?B?SGJDQkhuREd4WHV2SVBidUg3cVZndGIzN3RmQ1JDRmExMWkvVm9uQW8yTkFB?= =?utf-8?B?NDNvSEQyU2puQ3p0ZnZHZXJPMlJWQWgzb3dXbVV1TEk3V1lUSTRNcnNiMWYz?= =?utf-8?B?RHhteHNuVG9CZE9ZL3JLRmVEZFhsakF3S1JFQlo5K2RwOUwyWjRGQ1FwNmhW?= =?utf-8?B?UmdhVTZ4VW84TW80SWRUV3BVQzZLazBnSDNKS21KSWdjRmJ5TTU0c3ZYOCt6?= =?utf-8?B?VVltOEtReDZLV0xPMVVhUVQxazJ4a0RpbkcwK2daaW44Q1Z6b2dpWWZCRnZh?= =?utf-8?B?YWhSVE9oa1FaSHlsSzN6c3dUK3p4WUViekdXT2k1djRzV2lKTEdKZ3lrS2hp?= =?utf-8?B?am8vT05VK00xbU1QRGU0ZUpnM3JEMmplSHROWXF2N2wwNVZsaHB4bWN1QzFI?= =?utf-8?B?SGFyNlhNelRkcGJXSDI5akQzc1BMb24rWUpJbHEyR2Z2cXEvRGprWDl4MUVH?= =?utf-8?Q?pSoI=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca61b827-6d0d-4843-790e-08dc1e8f79b0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 16:54:35.3379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sx5GNRevJqU0anGW5a2upCCWdU8xeXS94T0b7tMnrjhi+HiUN1b4uH3zklCDGg7i X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8087 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/11/2024 6:25 AM, lihuisong (C) wrote: > Hi Ferruh, > > 在 2023/11/23 19:56, lihuisong (C) 写道: >> >> 在 2023/11/2 7:39, Ferruh Yigit 写道: >>> timesync_read_rx_timestamp >>> On 9/21/2023 12:59 PM, lihuisong (C) wrote: >>>> add ice & igc maintainers >>>> >>>> 在 2023/9/21 19:06, Ferruh Yigit 写道: >>>>> On 9/21/2023 11:02 AM, lihuisong (C) wrote: >>>>>> Hi Ferruh, >>>>>> >>>>>> Sorry for my delay reply because of taking a look at all PMDs >>>>>> implementation. >>>>>> >>>>>> >>>>>> 在 2023/9/16 1:46, Ferruh Yigit 写道: >>>>>>> On 8/17/2023 9:42 AM, Huisong Li wrote: >>>>>>>>    From the first version of ptpclient, it seems that this example >>>>>>>> assume that >>>>>>>> the PMDs support the PTP feature and enable PTP by default. >>>>>>>> Please see >>>>>>>> commit ab129e9065a5 ("examples/ptpclient: add minimal PTP client") >>>>>>>> which are introduced in 2015. >>>>>>>> >>>>>>>> And two years later, Rx HW timestamp offload was introduced to >>>>>>>> enable or >>>>>>>> disable PTP feature in HW via rte_eth_rxmode. Please see >>>>>>>> commit 42ffc45aa340 ("ethdev: add Rx HW timestamp capability"). >>>>>>>> >>>>>>> Hi Huisong, >>>>>>> >>>>>>> As far as I know this offload is not for PTP. >>>>>>> PTP and TIMESTAMP are different. >>>>>> If TIMESTAMP offload cannot stand for PTP, we may need to add one new >>>>>> offlaod for PTP. >>>>>> >>>>> Can you please detail what is "PTP offload"? >>>>> >>>> It indicates whether the device supports PTP or enable  PTP feature. >>>> >>> We have 'rte_eth_timesync_enable()' and 'rte_eth_timesync_disable()' >>> APIs to control PTP support. >> No, this is just to control it. >> we still need to like a device capablity to report application if the >> port support to call this API, right? >>> >>> But when mention from "offload", it is something device itself does. >>> >>> PTP is a protocol (IEEE 1588), and used to synchronize clocks. >>> What I get is protocol can be parsed by networking stack and it can be >>> used by application to synchronize clock. >>> >>> When you are refer to "PTP offload", does it mean device (NIC) >>> understands the protocol and parse it to synchronize device clock with >>> other devices? >> Good point. PTP offload is unreasonable. >> But the capablity is required indeed. >> What do you think of introducing a RTE_ETH_DEV_PTP in >> dev->data->dev_flags for PTP feature? > > Can you take a look at this discussion line again? > > Let's introduce a  RTE_ETH_DEV_PTP in dev->data->dev_flags to reveal if > the device support PTP feature. > Hi Huisong, First let me try to summarize the discussion since it has been some time. HW timer block can be used for Rx timestamp offload (RTE_ETH_RX_OFFLOAD_TIMESTAMP) and/or PTP support, but they are two different things. This patch uses 'RTE_ETH_RX_OFFLOAD_TIMESTAMP' capability for PTP support, which is wrong. After we agreed on above, your next question is to use 'dev_flag' to report PTP capability. First, can you please describe what is the motivation to learn if HW supports PTP or now, what is the benefit of knowing this. If we agree that there is a need to know the PTP capability, question is where to report this capability. Suggested 'dev_flags' is used for various things, some are internal flags and some are status, I don't think overloading this variable is not good idea. Other option is an update 'rte_eth_dev_info_get()' for it but it has the same problem, this function is already overloaded with many different things. We can have an API just to get PTP capability, but this will require a new dev_ops, this can be an option but my concern is having a capability dev_ops for each feature create a mess in dev_ops. Perhaps we can have single get_capability() API, and it gets features as flags to return if that feature is supported or not, but this requires a wider discussion. Instead can we deduce the capability from PTP relevant dev_ops, if they are implemented we can say it is supported? This doesn't require new support.