From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E40F0A0C47; Wed, 27 Oct 2021 16:18:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A327B40DDA; Wed, 27 Oct 2021 16:18:47 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 2442B407FF for ; Wed, 27 Oct 2021 16:18:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10150"; a="253721518" X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="253721518" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2021 07:18:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,186,1631602800"; d="scan'208";a="572956383" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2021 07:18:40 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 07:18:40 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 27 Oct 2021 07:18:39 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 27 Oct 2021 07:18:39 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 27 Oct 2021 07:18:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3YrmTeVJnkoVN0S+OvKAUQIdBjqaK88/Vi7VkEf4PaGbsYZmhaSa1hCFFLaTonY6dMmK+6KK/DxFxL0xanfov9Jk8HNqBwvwInEDIhfTrqJBZ9f4JNkIOOkQEc/AOFqVotq4EoSaSEgRnWj4YoY1rHTbUqY6sYxNqgqcxd0PcSfp78pY48GwffIPNvH0XXHCDxizfZ3EAwinhoAnq04YZc7b/Ou/yhvipFf9EUGztp5nN1OAhLfHtPDSqBWH6Yxe59/cG1ZdWXc8l5GE85cxbktRgZ8wH0Jc2Aqw29jjIlbEJYhyRqFyyCKDnok4XohjjbyXJEYnR3LTFiMYC4ceQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=97odYY6jvPGSpS+kmtXoaaFmRSHAqjREQnbxBe72vgA=; b=n3KC9hBNQcb2lR3C4D9Ra9/GGBTSl3RBP8FQMhfcgwiK8XrYm+6KaOQvZ9ZHVBkuVDxNbOd8VFfx1FGexscBSl6ZhlQcuWQjCczYVun/6raAWcUNsx5kEyq4OEhpZ9fQB/m4PKd+yiYUDCR4V1++/ek+0FmWy2eDuJYr9TSj/IEuEkjgEHtMeH8jT9L6fQ1hzWpBT9U5MbYGvwLmQQViF5mLtlI1PnGVRuwE3SbLuL4Ttj8WJasCOYpx9EIPIaGXcLZGmaXPjcr09IvFn+wV5iSPbXbcDzzUwN2dvX27kHblJmiM9NtUpaAAws2sKOaCtmcO4A47U9qw4nboDlycjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=97odYY6jvPGSpS+kmtXoaaFmRSHAqjREQnbxBe72vgA=; b=NQHKcmevtCU76yJo4e3V/xSit9kH5XtUOIDknmmoBmu4urUBGIWuL5PR0L5UBiGB8+JNb6kkffwq2kjptdBSD07+soEO47Ckl059Ce+ZcUm9Kbljxmuw84WwIQWibVJ0MVA+7FUX38CS1vpFEqmmXivB3c2PF7Z2GosVIIsW6mc= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4936.namprd11.prod.outlook.com (2603:10b6:510:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Wed, 27 Oct 2021 14:18:37 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 14:18:37 +0000 Message-ID: <5b203733-7669-a719-15b7-9e29fc80e91e@intel.com> Date: Wed, 27 Oct 2021 15:18:31 +0100 Content-Language: en-US To: Apeksha Gupta , , CC: , , References: <20211019184003.23128-2-apeksha.gupta@nxp.com> <20211021044700.12370-1-apeksha.gupta@nxp.com> <20211021044700.12370-2-apeksha.gupta@nxp.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021044700.12370-2-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR05CA0027.eurprd05.prod.outlook.com (2603:10a6:10:1da::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR05CA0027.eurprd05.prod.outlook.com (2603:10a6:10:1da::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Wed, 27 Oct 2021 14:18:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 690ae63a-0e7c-4221-2a57-08d99954ab05 X-MS-TrafficTypeDiagnostic: PH0PR11MB4936: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O51AJhxjvRL9BUNaa2LT3Q5klvZg908zcwchI22NqR+0PRUil9xjWqG+Du5b0C8Tahuq3yhhW/29YqV2eAiUYCw3yEQg9eiiBK+N3w59Sukya0Mgh+2S2d37A1ewF8YWNGCrfe9pLik7oT1NtzYdaWaR7DNtk5NOE+5izdrtlxZgufrfoZk5rbn1U3vFX9nR33tvC7WJxsizJJ56mCwJs+vTeq5m0oU+HOTQ438lXliKnTPUMJGBu40Ly7bSp4sdz0XfpKNc1Ut42RChNr2ZQoFh45iFDywFubS9tDQnpmDoRVtuIclwCid//VgdQOsr2bEjv6hWbOgoQxtFtiKYh+hMSR8O32v0dv4B6AriZxjC06uIkhaxpKca/cdN7KaBZQ8dBluw6+LKslhY/NOO6ePFf3Jkci8wpcqc+3qgM0sT0xZ1LtSsL4L0UAL6hVG3LoFZX3erUZnQOj2nvkh26bUSD6MbNGZudBTFGgRV00l2IlVB74fP2wtWnMrvzq7htQLxoGO5kKYeey2dmxbZmf1nFfoOqYG6soQzETyGWXTisNP0Cfv/tV62i6Ytqa049/2ogMBj8BO8fNHLdx6deOHJtGdjbvAp7ST1gV9fMbNUzrp3eBe/+wmMIokv8Eol+QXvABo50+4/5c/QWDvaXgC2MeoAp331Z7mWRitzcapcrnBiTUhzX7K/bWwi2Mm5vBLAiYNkVBh0t2P0ODWMog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(4326008)(44832011)(38100700002)(2616005)(31686004)(186003)(6486002)(53546011)(31696002)(508600001)(956004)(8676002)(8936002)(83380400001)(86362001)(26005)(2906002)(36756003)(82960400001)(6666004)(66946007)(16576012)(66556008)(66476007)(5660300002)(316002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDc0b0NWY3VjS1FrZWluN0wwRlFPZFZLVkl6MHVPdGxESXYwdmhwc0MwenVZ?= =?utf-8?B?aldMWFk1aUJ4NkFFZURKekhZRDhCMVRVSWExR2w4dW9iajk1L0wxeEFtcjFK?= =?utf-8?B?andvTjZwYWhqdy9FUWhsVGpjd3BPTUdiQjFrS0t6RjBUNWphVWtBYkFLMC91?= =?utf-8?B?dStVVmFoZ3hvWEtESUpRR0NxN3hFNXJacTBWWG5MVVF2VkZwVk5mUlFMWW9M?= =?utf-8?B?ZFF5cDE2UXMybWxjK2FMMHYxYVlncDB0M2V1WDhZRmVNejZySlgxaGNsYm1v?= =?utf-8?B?aG5kZk55cVk4VVNJSmk0bmFuNUh4eXV3ZDE3Qm90cWpMT3NnTWdEZGowWC9y?= =?utf-8?B?Nzg5cFU3d01pTnVieGsvV0FFS1J5V3ZSVHJsZTNjaGt1bE5tbk1PZUVsSzhj?= =?utf-8?B?VlZveTBuNGg1ay83LzhkTThvdzVudFZDclJJendtT0dnY0x0S1VVMThGUmpr?= =?utf-8?B?eDgwMTcvUW9IdFVrZVZYR0l3NEp0a3lBdkdNZ3lmaktxZFNsY2RnallxUnN2?= =?utf-8?B?TVZuRWYzOFdZQ0M1UU1HNGRPbS9rVFBWcUdsRFA4Z3hnV3RPMjJha3FxRU9a?= =?utf-8?B?cHpyRG5sSS81c1c4dFMycVpFeUhHd0hCcEtxTXNCMjBUVTdEV1hTNnNaRmJv?= =?utf-8?B?cWFlaTN2UGlicldFZG9NZGdObmhYUTFMT3dPOTQxTE95cmEvNDVUM2JNQVBH?= =?utf-8?B?anlJNjFIR2J3cjRuVUc2cnBuWC9MZkNqME1jTTBDeEQxcXZXcjJodUJ5VmNS?= =?utf-8?B?OVgzUEJKeSt3V0tEWUIrRmYxKzZ3bXpsMXBkb09qNHBJZ09ydFFXZDBBMEpm?= =?utf-8?B?RHNDOERRT0kyV1ZGdHJic2kxOGJuOUpoamxrdmh5dHNpTnlwdlRxL1I4SGVP?= =?utf-8?B?SEdNOVBER3MrT3h1MVNQWmdVNVd6YzZ5UUVWU0dXSkp3bWhvbHhJU05mSkxI?= =?utf-8?B?T3lNQW0xa2R2VFlCQi84a0s2VnZpWis5RU4zcVYzTGthZEtEN05NWHdFU1lO?= =?utf-8?B?eUdiZS9ydjNiL2czOVVzK05yNDI1cFg4WDBWaXJBc0lRSzA1TTZPT0tnUWYx?= =?utf-8?B?K2NyVGdHbEVvSXlydXBiR1pEOXJndjEyUVIzdURyYjhUS3hTbC9wZEtraXBr?= =?utf-8?B?T0hEM0ZQamJ2Q3gvMFpkeTFMSjZ4bThUbVZOenNBVGYvamgzc01VUXVGK2xU?= =?utf-8?B?b0xxT1MyOUpmWEE2YmZuWkIveFZtbDQ2SWVtSWFHNUh2Q0xtckZZVUI2V290?= =?utf-8?B?Qm5ueU5pb21OcndMOThCeDk1aWI1ekJyK0FsWThaZ2lDdzU1UUVhTVIwdmJw?= =?utf-8?B?YVdtNWkrZkdrdGpyemJSSTZSV0ZENGpURkF1NGIvU0Z4SVhrRTAwMXhjejFL?= =?utf-8?B?R1k0djdQcW42bnljeFVzRUZYc1VQMlk2Sm9nbGYxVzJCWmg0N01HWnZZRys4?= =?utf-8?B?YndLYTJYeUl1dTJkc0RrUkNHTmltTVd5dFA4VUNhendNTWJiYWduKzNoLzVH?= =?utf-8?B?UkZZL1k4ZGxuQWVCOS9vQ0x3V1l0NDA5cExMRXhoeTArVmdzRWZBSFVYak9C?= =?utf-8?B?elR4YS9kMmVWWEpUVVZTM3J3SVAyeVRVNGxxUTZDZkhHaHVkR2xrWG9GME5X?= =?utf-8?B?Um1VMGRyOGZlK0VTOEpuUVlQbWJQc1UyQ09xUFJ2MjA5ZGprYXRodHpxQi9l?= =?utf-8?B?UWhubHlTdEFsNmJBaDBpNnpDZzVMRmlCR291L3I1ZVl0bHlBYlJmdFljdDFF?= =?utf-8?B?ekZ1Z0cxU2ZHM1RHT1pPSGlDZkY2SVlNU2FLNkxOcm4zeEpZUElWZ1hDbnRF?= =?utf-8?B?cmRoSE1QczNWWEk2V1hrZ3Q4MGt6UkZaNTNLYXp5TVpPNWM4ZDFTQTdNWmNI?= =?utf-8?B?Vjdvb2V2a2JkZlh4cGpPZTllOWJlNTZxbjJ2aDNTcElvY3MwNHJKYzNabDFT?= =?utf-8?B?RHIzc3VZVHNFek5SVjVwTlJYWGZ0M2pKQnhXZS8xQ1drRW96aGNaTjcxa3lD?= =?utf-8?B?VStRSTlLTnJiYUVWNnRHUFBuT1ltZ2taMGFnRDQ0eFBzSEJRQmtBdFJDZDFK?= =?utf-8?B?WnI3Mzd1ejZzcGVVVkhWc0lBeWUvOHdnNUpsOHlwZThoN0hMM2VQR1MvZ2Rl?= =?utf-8?B?UVV4ZGZmL0tQL25obTBUSzVIdHpNQzRPSG82TFR1ZUI2Z3ZrdjhPRkhSaVJY?= =?utf-8?Q?lOYbzjFAQvgv9DFL4QN65Ic=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 690ae63a-0e7c-4221-2a57-08d99954ab05 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 14:18:37.7460 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5fBv5lM01R5+don77WEmr2hHOSzSmaDCSelH4/q0fqMGqEMBH+oRqCoHJn++aDN9XSzF56aSJcpLZypWLmv4kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4936 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 1/5] net/enetfec: introduce NXP ENETFEC driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/21/2021 5:46 AM, Apeksha Gupta wrote: > ENETFEC (Fast Ethernet Controller) is a network poll mode driver > for NXP SoC i.MX 8M Mini. > > This patch adds skeleton for enetfec driver with probe function. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta <...> > +Follow instructions available in the document > +:ref:`compiling and testing a PMD for a NIC ` > +to launch **dpdk-testpmd** > + > +Limitations > +~~~~~~~~~~~ > + > +- Multi queue is not supported. in 'enetfec_eth_info()' max_rx_queues/max_tx_queues returned as 3 (ENETFEC_MAX_Q). If multi queue is not supported why it is not one? <...> > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -20,6 +20,10 @@ DPDK Release 21.11 > ninja -C build doc > xdg-open build/doc/guides/html/rel_notes/release_21_11.html > > +* **Added NXP ENETFEC PMD.** > + > + Added the new ENETFEC driver for the NXP IMX8MMEVK platform. See the > + :doc:`../nics/enetfec` NIC driver guide for more details on this new driver. > Update is in the doc comment, can you please move it down, within the ethdev driver group in alphabetically sorted manner. <...> > +static int > +pmd_enetfec_probe(struct rte_vdev_device *vdev) > +{ > + struct rte_eth_dev *dev = NULL; > + struct enetfec_private *fep; > + const char *name; > + int rc; > + > + name = rte_vdev_device_name(vdev); > + if (name == NULL) > + return -EINVAL; Can name be 'NULL'? Not sure if we need this check, can you please check? <...> > +static int > +pmd_enetfec_remove(struct rte_vdev_device *vdev) > +{ > + struct rte_eth_dev *eth_dev = NULL; > + int ret; > + > + /* find the ethdev entry */ > + eth_dev = rte_eth_dev_allocated(rte_vdev_device_name(vdev)); > + if (eth_dev == NULL) > + return -ENODEV; > + > + ret = rte_eth_dev_release_port(eth_dev); > + if (ret != 0) > + return -EINVAL; > + > + ENETFEC_PMD_INFO("Closing sw device"); Log can be misleading, there is another dev_ops to close the device. <...> > @@ -0,0 +1,179 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright 2020-2021 NXP > + */ > + > +#ifndef __ENETFEC_ETHDEV_H__ > +#define __ENETFEC_ETHDEV_H__ > + > +#include > + > +/* > + * ENETFEC with AVB IP can support maximum 3 rx and tx queues. > + */ > +#define ENETFEC_MAX_Q 3 > + > +#define ETHER_ADDR_LEN 6 > +#define BD_LEN 49152 > +#define ENETFEC_TX_FR_SIZE 2048 > +#define MAX_TX_BD_RING_SIZE 512 /* It should be power of 2 */ > +#define MAX_RX_BD_RING_SIZE 512 > + > +/* full duplex or half duplex */ > +#define HALF_DUPLEX 0x00 > +#define FULL_DUPLEX 0x01 > +#define UNKNOWN_DUPLEX 0xff > + Some of the defines in this header is not used at all. What about only adding structs/defines that are used? And add them as they are needed? This guarantees not having unused clutter in the code. <...> > +/* Required types */ > +typedef uint8_t u8; > +typedef uint16_t u16; > +typedef uint32_t u32; > +typedef uint64_t u64; > + Do we need these type definitions, as far as I can see they are used only in a few places, why not just use uint##_t types? <...> > +static inline struct > +bufdesc *enet_get_nextdesc(struct bufdesc *bdp, struct bufdesc_prop *bd) > +{ > + return (bdp >= bd->last) ? bd->base > + : (struct bufdesc *)(((uintptr_t)bdp) + bd->d_size); > +} > + > +static inline struct > +bufdesc *enet_get_prevdesc(struct bufdesc *bdp, struct bufdesc_prop *bd) > +{ > + return (bdp <= bd->base) ? bd->last > + : (struct bufdesc *)(((uintptr_t)bdp) - bd->d_size); > +} > + > +static inline int > +enet_get_bd_index(struct bufdesc *bdp, struct bufdesc_prop *bd) > +{ > + return ((const char *)bdp - (const char *)bd->base) >> bd->d_size_log2; > +} > + > +static inline int > +fls64(unsigned long word) > +{ > + return (64 - __builtin_clzl(word)) - 1; > +} > + Same for these static inline functions, can you please add they when that are needed? > +uint16_t enetfec_recv_pkts(void *rxq1, __rte_unused struct rte_mbuf **rx_pkts, > + uint16_t nb_pkts); > +uint16_t enetfec_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, > + uint16_t nb_pkts); These function definitions are not declared, at least not in this patch. > +struct bufdesc *enet_get_nextdesc(struct bufdesc *bdp, > + struct bufdesc_prop *bd); This is already static inline function, do we need separate definition for it? > +int enet_new_rxbdp(struct enetfec_private *fep, struct bufdesc *bdp, > + struct rte_mbuf *mbuf); > + ditto, no function declaration. <...> > + > +/* DP Logs, toggled out at compile time if level lower than current level */ > +#define ENETFEC_DP_LOG(level, fmt, args...) \ > + RTE_LOG_DP(level, PMD, fmt, ## args) > + Not used at all. > +#endif /* _ENETFEC_LOGS_H_ */ > diff --git a/drivers/net/enetfec/meson.build b/drivers/net/enetfec/meson.build > new file mode 100644 > index 0000000000..79dca58dea > --- /dev/null > +++ b/drivers/net/enetfec/meson.build > @@ -0,0 +1,11 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2021 NXP > + > +if not is_linux > + build = false > + reason = 'only supported on linux' > +endif > + > +sources = files('enet_ethdev.c', > + 'enet_uio.c', > + 'enet_rxtx.c') This should cause build error on this patch, isn't it? Since these files don't exist in this patch. Each patch should be built successfully.