From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF762A0C4D; Fri, 13 Aug 2021 15:59:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64FBA40DF4; Fri, 13 Aug 2021 15:59:55 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 63E904069C for ; Fri, 13 Aug 2021 15:59:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="202722312" X-IronPort-AV: E=Sophos;i="5.84,319,1620716400"; d="scan'208";a="202722312" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 06:59:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,319,1620716400"; d="scan'208";a="447059033" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga007.fm.intel.com with ESMTP; 13 Aug 2021 06:59:52 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 06:59:52 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 06:59:51 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 06:59:51 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 06:59:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VN3LifuvsRyBWhTVTg/MQGwdcWH0y9zcY+ERrpXRR13dCpwRljZ8wIN6eeCWJkJML74afz2u2zrz7bnKqQNbAQCzwO0L6XRb6ean77eaLBQVlVJAU+3IlbGWyFgIZNpLRS7nv7vvqmrLOXGnH7L03xWyWzZguqRTunkoiuHJIJHai28MkDoRp1sIck8SsZz6uXDgJBrkhpvY2Cdhn75sUG3rdJGcICQ7ONe66B7l+8jc2OXw+ZCHUiziXsB3KxzjRjR34ntVWFwbO0DF7i2KoqK8AZuo1V6k5ygYcCHkOsjEQzVr7Zdsrp/OyeLPAMqEQXRLaRxst0+xC5re6lnAfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQKYfIlGu/171WmRioVaqsQoTaXklnICupfeu8T6anI=; b=CPfsIOARkSL7e4i6DT8uA+jWm46SmlEjy0dDNBAFfMyz/MUnNvgAhPbh3CbSMuYRA3fql0Xh14LGsDGImOgxOWfrWe217BAUrfe92fxIwXsP891PFIMK3XTAVJJYd9zDaxLMW+IwqEBBUV1Djv4DKwbDQxHwVXhal2H/x1Qc8FlVR+Xvr9c5DG1XZcmYh/8mrkett0ZfH1w3zHylJMFww062Erxa93UG5F4PIuhB69L/Se6/GH0Lf/njtrG4ul5Owud6cmbnXaB7V1Pi6lSq8QsnHwtERE65o57Nv9M2g58yLvj/BwXGFzMFFH/xhRuGW1mVjfvN+4QSs7/2LXH//w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JQKYfIlGu/171WmRioVaqsQoTaXklnICupfeu8T6anI=; b=dMuIZWDwHbZWLgD3AHlER88Am4SlOCHRW40BE08ipiYEATwQtk60f+oQ/4m+2tu2yuqOJAHGqzKU6OMoltgYw73Ev6XVTGQSSPawnmzQkH9xdUP8RpRupF1pELxoQugdoxwKc4TxuyfUAfqWEMMVV73zkeO/Zlz6yH4jMYj64YA= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3303.namprd11.prod.outlook.com (2603:10b6:a03:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Fri, 13 Aug 2021 13:59:49 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5ef:d69:fa61:6150]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5ef:d69:fa61:6150%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 13:59:49 +0000 To: Wenjun Wu , , , , References: <20210802075754.952979-1-wenjun1.wu@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <5b2dd6ae-b3fd-7d7b-5e80-90f838b633fb@intel.com> Date: Fri, 13 Aug 2021 14:59:43 +0100 In-Reply-To: <20210802075754.952979-1-wenjun1.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0202CA0023.eurprd02.prod.outlook.com (2603:10a6:4:29::33) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0023.eurprd02.prod.outlook.com (2603:10a6:4:29::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Fri, 13 Aug 2021 13:59:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 51c8e19a-9387-4977-83fa-08d95e629d55 X-MS-TrafficTypeDiagnostic: BYAPR11MB3303: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hsI+coW/ylo9Rfd/8s7IBq3+OnbswTCYK3REKTg0bopREqcMFrZtkHSCc+lzNreR/8g8XB5/5vH6BHngTozgm6hx/smCbLJNWowzUdezUmlebfrMtPL4KoZdFsfaxw4bOg6MdiR+aY0gcg0u2ChAZPLJuWlriX3WwHQC0reixLxNcOuj+pY16f7XReOOQcUXSxDItJM8A0x21hoZrWu+VMKuUiO472vVw39BpF5KFdbYLTNTBrskCTNtQeUifjpQoJplfH79FGTS5AZ/lurByNze97gvciP+ZpDi23CUPDZ1E/5Qhxm/fDWBbwlFflDxfiPzK8HaenO9V1J1vDsbzFkcSyOop1wyolS9vLwqcdBREM9TOk5IkKgrSFrnixabUua8JP2Gm0tHuiDd3K95cd2fLn5JWeNJ0qJsKWhq2xkaE7Ff6kCW8VCtV4b4UPWy/yK4RzN191z74FyQ75+m7T/bYIfF8IZEOboN3Pn6Qr7YzMZU/8Uy+MDmzfrwbRo6KoU+ewYq67tc/HW8SPOLKmIuS8YW4LEiw77LorDM6W5M6q7tn7ZLzcMjeiG6s+RGkgFRuSrq+BV5A38Ps1fSPYOHAMPjUQT8jENl60WNdL8Q4edEnAEOhuePRwfHK0zfjDZEcVCcCcP/eZzz2ija1RuVNJDsxy0W5yU7pkRlzcLJAFjKVV3aBwXTvundY3i+N31p0zZKq8nk+AWP2DcT8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(39860400002)(366004)(396003)(376002)(31696002)(186003)(86362001)(8676002)(2906002)(956004)(8936002)(44832011)(2616005)(6636002)(38100700002)(478600001)(16576012)(53546011)(316002)(26005)(66946007)(31686004)(83380400001)(6486002)(36756003)(66476007)(6666004)(66556008)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?My95OXdLbkxIZThvd3RuVUZZYzRaRDJIeWtRQm03Ukx6M0ZWVit0bG5GZ3Ft?= =?utf-8?B?RW1CeUplWXRvQXFna1ViT1FXTGtqTXU3MlBMYXZVTEhnVFFTWFB3elcrS3Iz?= =?utf-8?B?bVVqMHdvRGFXN2tJOE1EMEdaTTZVb2p0U2xxTHRMcytuWEZIUWlzNXVleTNV?= =?utf-8?B?dG9jWlRQaU95NHVaazJodVRLb3ZxK3JIM0NrZElyZU8wS0diMUVmTkx5V2Fl?= =?utf-8?B?N3l6TVdKbWkzeGlDQnpsZXgvcTM2RE1MZ3VkL3hqdmxaY29Xb2lJbkcrdFBM?= =?utf-8?B?MjNMSDZKN2tuRlBtVHBwK2ZYTFBNbGpwcVdrdFQ4SHZVOXFEUk9xRW1wUnJK?= =?utf-8?B?VEMzemZHTFUzOUV1T2M0dTZEdGtpaUR5bGVnbXhYK3JxWTUvOXRaN2o5ZW1J?= =?utf-8?B?cnlJU3pYSlRDK0NNYnc5eTZhdmZ5ZXN4QnhVYWhWemJGQ0lVNFYzdXR6a2Yv?= =?utf-8?B?QTA4aUdlZUpURWVxOUhUSUhkanJQTWhEdzZUc25nWERXNlh0R2tmN2RnQjNN?= =?utf-8?B?eWJWd1JNL2FaWWRMQnp5M1hnMm5DUFN6dnRMNDlRRHZCOWVhZE1ySTVnMFpk?= =?utf-8?B?ek1UL0I1cmZlTWE1dk9HTEdvcWE3c2NEbzhpbktzaW5GOEhNS2NCSHJCTGwx?= =?utf-8?B?dHNKbXlLMDhKS0p6WHBHdEl5OEtEMGZGVzhVcXB0WjRpZjE1T2RnTDEvVmcv?= =?utf-8?B?MkxHcy9USnd6T3FGNU12STdjNmE0V0ZHR1pYd05ZL0kvenBlZGVIVmQ1Tkd3?= =?utf-8?B?Rlg0YzQ2c0xQSSt1MGp5UFNBaStwOXExMElleEZGSUZGQXVwT1MvMnpKVHNz?= =?utf-8?B?dGpXRnh1TU1QSlhBMnpXUnJxVm90cEluV0ZCSjN5NGJjSlZ1dE84SmhPWGFT?= =?utf-8?B?Q3htUktDdm1hQmJYQUozZTJnWVJGblMwOFN4cWpKVGxic0R4L2RXeDgwbkJE?= =?utf-8?B?ajIwakE1MDl3a1lsV1FCM2JEZGdDVmY5Qk04WTJ2b0RkZ1BqWmpSN094SzBj?= =?utf-8?B?TCtxempHWFZjenBuSmRIKzcvdXRBcUpYTlRQNFprWW1uUUdEQ2dhVGNCby9z?= =?utf-8?B?S2Uwb1lCRkc1K09kYktIcVJUV1g2TnpndWVKSzd6aFdRanpyVXcvK002TklX?= =?utf-8?B?Y3NKSTlnaHAwK3BQOWlMb2Mzb0NIZ1NkTUY2SDNXWDgzQkZHbThhQmxNZSs0?= =?utf-8?B?YW4zQitGZXRreXlvRGQvRFFPRlgwMTMyNlFrL3hydTJ5Q0w1M2daQ1poci91?= =?utf-8?B?bnBSUVFyWklMMFF3TnkvV1R1OWJrbGc2Zi95azgyTG1yTkQ4QVlsM1cyanh3?= =?utf-8?B?VXl2S2xTSERPc1hOdi9NbFBqY3oyaGxTMnFsTEs0MzExZ1hsMjVvL1U0YTU5?= =?utf-8?B?SVk1RTVwYjRrbW4yTFhEZkVNVzV6dEt3QVE5WTdNQW1HdVNkQ3FYSVdjbm1Y?= =?utf-8?B?eGp3cFBEL0ZFV2JSOEZZL1pzNUIvWWpoZUdVM2M5RXp4UXBDUHFNMmJORE44?= =?utf-8?B?Y1Y4c01jZHZwVFZIQUlDYkRER1krNkg4VWpqb0xxeWdOQkE2cFZPRDNhU3JJ?= =?utf-8?B?a2VsSlNIWkhkRDY1S2xCMS9iTUdwdm8wZ05DUGlWWmF0dUVvaENHaytvMldC?= =?utf-8?B?SEdXdk14eFJsNGs1SllwQWhRaHY3VlJrUVE2bkwwVWVObnZralRQOXlSRlRP?= =?utf-8?B?TURjcTBiajVVRnRmWTNoaGIyQ2VNejVaT0Q4RFl0OUk0QXZSTlFGWEIwUy94?= =?utf-8?Q?/1U5Bd+vFvgz3W/5eGQAG7rZW7LNcSXJG4XKN4Q?= X-MS-Exchange-CrossTenant-Network-Message-Id: 51c8e19a-9387-4977-83fa-08d95e629d55 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 13:59:49.1408 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dx7zmBI7mDnk09km3I+cr+haTdpSvBeXXW7zbkKOFGOuNaWYmSEiPdQvZTLF3djSctWrTIXpw+odO8nlo0RhWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3303 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/iavf: support FDIR L3 fields for IP fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/2/2021 8:57 AM, Wenjun Wu wrote: > Add support of FDIR L3 fields for both IPv4 and IPv6 fragment packets. > Description mentions from both IPv4 & IPv6 but only IPv6 macro is updated, is this expected? Is following correct: Before this patch flow director rules were not applied to fragmented IPv4 & IPv6 packets (so packets were not able to sent to specific queues), but after this patch it does. Is it the case that HW configuration was missing and hash is not calculated for these kind of packets etc.. If you have more details can you please provide? Also what was happening to these packets previously, sent to queue 0 by default? Overall can please provide more description and check below question related to 'field_selector'? Thanks, ferruh > Signed-off-by: Wenjun Wu > --- > drivers/net/iavf/iavf_fdir.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c > index da3eec8b59..32b06044f2 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -57,7 +57,7 @@ > IAVF_INSET_IPV6_HOP_LIMIT) > > #define IAVF_FDIR_INSET_ETH_IPV6_FRAG_EXT (\ > - IAVF_INSET_IPV6_ID) > + IAVF_FDIR_INSET_ETH_IPV6 | IAVF_INSET_IPV6_ID) > > #define IAVF_FDIR_INSET_ETH_IPV6_UDP (\ > IAVF_INSET_IPV6_SRC | IAVF_INSET_IPV6_DST | \ > @@ -664,6 +664,7 @@ iavf_fdir_add_fragment_hdr(struct virtchnl_proto_hdrs *hdrs, int layer) > /* adding dummy fragment header */ > hdr1 = &hdrs->proto_hdr[layer]; > VIRTCHNL_SET_PROTO_HDR_TYPE(hdr1, IPV4_FRAG); > + hdr1->field_selector = 0; Is this change related to new support, or fixing something that was missing previously? > hdrs->count = ++layer; > } > >