From: fengchengwen <fengchengwen@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@amd.com>, <dev@dpdk.org>
Subject: Re: [PATCH 1/7] app/test: introduce UT suite framework for kvargs
Date: Fri, 11 Oct 2024 11:35:35 +0800 [thread overview]
Message-ID: <5b6bc306-3e38-4252-87f5-1ba2f34a66b0@huawei.com> (raw)
In-Reply-To: <20241010190851.48011478@hermes.local>
On 2024/10/11 10:08, Stephen Hemminger wrote:
> On Fri, 3 Nov 2023 09:53:19 +0000
> Chengwen Feng <fengchengwen@huawei.com> wrote:
>
>> Introduce unit test suite framework for test_kvargs.c.
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> ---
>> app/test/test_kvargs.c | 20 +++++++++++++-------
>> 1 file changed, 13 insertions(+), 7 deletions(-)
>>
>> diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c
>> index 7a60cac4c1..9aeb9aa0aa 100644
>> --- a/app/test/test_kvargs.c
>> +++ b/app/test/test_kvargs.c
>> @@ -1,5 +1,6 @@
>> /* SPDX-License-Identifier: BSD-3-Clause
>> * Copyright 2014 6WIND S.A.
>> + * Copyright(c) 2023 HiSilicon Limited
>> */
>
> The test changes look good and it is always better to have more tests.
>
> IANAL but starting the precedent of allowing adding copyright whenever a file
> is touched just leads to lots of meaningless fluff.
OK, I sent v2 which remove this line.
next prev parent reply other threads:[~2024-10-11 3:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 9:53 [PATCH 0/7] refactor kvargs test Chengwen Feng
2023-11-03 9:53 ` [PATCH 1/7] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-11 2:08 ` Stephen Hemminger
2024-10-11 3:35 ` fengchengwen [this message]
2023-11-03 9:53 ` [PATCH 2/7] app/test: extract basic token count testcase " Chengwen Feng
2023-11-03 9:53 ` [PATCH 3/7] app/test: extract without keys " Chengwen Feng
2023-11-03 9:53 ` [PATCH 4/7] app/test: extract with " Chengwen Feng
2023-11-03 9:53 ` [PATCH 5/7] app/test: extract parse list value " Chengwen Feng
2023-11-03 9:53 ` [PATCH 6/7] app/test: extract parse empty elements " Chengwen Feng
2023-11-03 9:53 ` [PATCH 7/7] maintainers: update for kvargs library Chengwen Feng
2023-12-05 2:55 ` [PATCH 0/7] refactor kvargs test fengchengwen
2024-10-05 15:49 ` Stephen Hemminger
2024-10-11 3:34 ` [PATCH v2 " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 1/7] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 2/7] app/test: extract basic token count testcase " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 3/7] app/test: extract without keys " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 4/7] app/test: extract with " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 5/7] app/test: extract parse list value " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 6/7] app/test: extract parse empty elements " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 7/7] maintainers: update for kvargs library Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6bc306-3e38-4252-87f5-1ba2f34a66b0@huawei.com \
--to=fengchengwen@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).