From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 1CF7E11DE
 for <dev@dpdk.org>; Fri, 11 Nov 2016 03:22:06 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga104.fm.intel.com with ESMTP; 10 Nov 2016 18:22:05 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.31,620,1473145200"; d="scan'208";a="29969122"
Received: from rhorton-mobl.ger.corp.intel.com (HELO [172.16.225.47])
 ([172.16.225.47])
 by fmsmga006.fm.intel.com with ESMTP; 10 Nov 2016 18:22:05 -0800
From: Remy Horton <remy.horton@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>, dev@dpdk.org
References: <1476711584-25377-1-git-send-email-reshma.pattan@intel.com>
 <1478524474-7154-1-git-send-email-reshma.pattan@intel.com>
Organization: Intel Shannon Limited
Message-ID: <5b715ac1-b9e8-f7fc-33a1-a430208c4fe4@intel.com>
Date: Fri, 11 Nov 2016 10:22:04 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1478524474-7154-1-git-send-email-reshma.pattan@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v4] latencystats: added new library for
 latency stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 Nov 2016 02:22:07 -0000


On 07/11/2016 21:14, Reshma Pattan wrote:
[..]
 > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>

Reviewed-by: Remy Horton <remy.horton@intel.com>


 > +static void
 > +metrics_display(int port_id)
 > +{
 > +    struct rte_stat_value *stats;
 > +    struct rte_metric_name *names;

Note that rte_stats_value is being renamed to rte_metric_value in the 
next version of the metrics library..


 > +int
 > +rte_latencystats_init(uint64_t samp_intvl,
 > +        rte_latency_stats_flow_type_fn user_cb)
 > +{

Far as I can tell, user_cb is always NULL, and the two callbacks it 
eventually get passed to don't use it. There any reason the function 
signature has it at all?


 > +++ b/lib/librte_latencystats/rte_latencystats_version.map
 > @@ -0,0 +1,10 @@
 > +DPDK_16.11 {

This will need to change to 17.02 once new release cycle starts. :)

Will also need to add entry to release_17_02.rst once it becomes available..

..Remy