From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0589AA0353;
	Wed,  2 Mar 2022 03:09:40 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D74F540696;
	Wed,  2 Mar 2022 03:09:39 +0100 (CET)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id A6A7340040
 for <dev@dpdk.org>; Wed,  2 Mar 2022 03:09:38 +0100 (CET)
Received: from kwepemi100020.china.huawei.com (unknown [172.30.72.53])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K7cwM1BNDzdfms;
 Wed,  2 Mar 2022 10:08:19 +0800 (CST)
Received: from kwepemm600004.china.huawei.com (7.193.23.242) by
 kwepemi100020.china.huawei.com (7.221.188.48) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2375.18; Wed, 2 Mar 2022 10:09:36 +0800
Received: from [10.67.103.231] (10.67.103.231) by
 kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2308.21; Wed, 2 Mar 2022 10:09:35 +0800
Message-ID: <5b829b45-220b-daa2-19e4-3b3fc746d152@huawei.com>
Date: Wed, 2 Mar 2022 10:09:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH 2/6] net/hns3: fix inconsistent enabled RSS behavior
To: Ferruh Yigit <ferruh.yigit@intel.com>, "Min Hu (Connor)"
 <humin29@huawei.com>, <dev@dpdk.org>, <thomas@monjalon.net>, Andrew Rybchenko
 <andrew.rybchenko@oktetlabs.ru>, Qi Zhang <qi.z.zhang@intel.com>, Ori Kam
 <orika@nvidia.com>
CC: Olivier Matz <olivier.matz@6wind.com>, Ajit Khaparde
 <ajit.khaparde@broadcom.com>, "jerinj@marvell.com" <jerinj@marvell.com>,
 Stephen Hemminger <stephen@networkplumber.org>, Viacheslav Ovsiienko
 <viacheslavo@nvidia.com>, huangdaode <huangdaode@huawei.com>
References: <20220228032146.37407-1-humin29@huawei.com>
 <20220228032146.37407-3-humin29@huawei.com>
 <ccf87f2f-6a95-8617-e483-52d01b8b84ef@intel.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <ccf87f2f-6a95-8617-e483-52d01b8b84ef@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


在 2022/3/1 0:42, Ferruh Yigit 写道:
> On 2/28/2022 3:21 AM, Min Hu (Connor) wrote:
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> RSS will not be enabled if the RTE_ETH_MQ_RX_RSS_FLAG isn't be set in
>> dev_configure phase. However, if this flag isn't set, RSS can be enabled
>> through the ethdev ops and rte_flow API. This behavior is contrary to 
>> each
>> other.
>>
>> Fixes: c37ca66f2b27 ("net/hns3: support RSS")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>
>
> Hi Huisong, Connor,
>
> Let's get a little more feedback for this patch, cc'ed more people.
>
>
> To enable RSS, multi queue mode should be set to 
> 'RTE_ETH_MQ_RX_RSS_FLAG'.
>
> But I wonder if it is required to configure RSS via flow API,

I do not know the original purpose of adding the RSS configuration in 
flow API.

However, as far as I know, the hash algorithm can be configured via this 
API,

but not via ethdev ops API.

> and if other PMDs check this configuration for flow API?

Some PMDs already have similar check in RSS releated ops or rte_flow API.

For example, hinic, axbge, bnxt, cnxk, otx2, and ena.

> .