From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 6A9742BF3 for ; Wed, 30 May 2018 16:48:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2018 07:48:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,460,1520924400"; d="scan'208";a="59827085" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.12.58]) ([10.252.12.58]) by fmsmga001.fm.intel.com with ESMTP; 30 May 2018 07:48:47 -0700 To: Pablo de Lara , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org References: <20180530063156.17902-1-pablo.de.lara.guarch@intel.com> From: "Burakov, Anatoly" Message-ID: <5b964ef5-0b58-4eaa-f814-0ac46186cd3f@intel.com> Date: Wed, 30 May 2018 15:48:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180530063156.17902-1-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix crash on detach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 May 2018 14:48:49 -0000 On 30-May-18 7:31 AM, Pablo de Lara wrote: > When detaching a port bound to ixgbe PMD, if the port > does not have any VFs, *vfinfo is not set and there is > a NULL dereference attempt, when calling > rte_eth_switch_domain_free(), which expects VFs to be used, > causing a segmentation fault. > > Steps to reproduce: > > ./testpmd -- -i > testpmd> port stop all > testpmd> port close all > testpmd> port detach 0 > > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") > > Reported-by: Anatoly Burakov > Signed-off-by: Pablo de Lara > --- Tested-by: Anatoly Burakov -- Thanks, Anatoly