From: Kevin Traynor <ktraynor@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: ian.stokes@intel.com, i.maximets@ovn.org, Ray Kinsella <mdr@ashroe.eu>
Subject: Re: [dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable
Date: Fri, 22 Oct 2021 11:22:56 +0100 [thread overview]
Message-ID: <5ba1af7c-f658-3991-87e5-1d75ddfcae1b@redhat.com> (raw)
In-Reply-To: <20211022065528.25178-1-david.marchand@redhat.com>
On 22/10/2021 07:55, David Marchand wrote:
> This API has been around for more than a year (and is in LTS 20.11).
> It did not receive negative feedback and will be used in a next OVS
> release.
> Mark it stable.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
I have tested with rte_lcore_dump(), rte_mp_disable(),
rte_thread_register(), rte_thread_unregister() in OVS patches and they
are straightforward API and worked fine. rte_lcore_iterate() tested
implicitly through rte_lcore_dump().
I haven't used
rte_lcore_callback_register()/rte_lcore_callback_unregister() as they
are optional but it doesn't make sense to leave them experimental while
promoting rte_thread_register()/rte_thread_unregister() which call those
callbacks.
Noting that rte_lcore_iterate() is also in use for 1+ year from
mempool_bucket.
Acked-by: Kevin Traynor <ktraynor@redhat.com>
next prev parent reply other threads:[~2021-10-22 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 6:55 David Marchand
2021-10-22 10:22 ` Kevin Traynor [this message]
2021-11-03 17:41 ` Thomas Monjalon
2021-11-05 9:42 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba1af7c-f658-3991-87e5-1d75ddfcae1b@redhat.com \
--to=ktraynor@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=i.maximets@ovn.org \
--cc=ian.stokes@intel.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).