From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77858A0C43; Fri, 22 Oct 2021 12:23:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DDB34114A; Fri, 22 Oct 2021 12:23:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 081AE41149 for <dev@dpdk.org>; Fri, 22 Oct 2021 12:23:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634898180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y/qIS89i659vITO7/nGdqdNT0hX7dNxnPc+MUUVxovE=; b=CqNIpt2ilzfstBhJe0CsW/lAOWOZ4gvnh/ksdCDlScivAAJe17iCz/3zU+XMMmvqSd3LnB cmPINjuUhE/k0NuYXWfc62GoDzEDT2ROiV1Oq3mMYIS2jr8U3aS80fKobYt8/hQ0e3/6OJ n/If0uCJL0Uf/dCIGXk5JxJL0ZkgCdo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-7YehZP-eNeuwY3U3-0IrCg-1; Fri, 22 Oct 2021 06:22:59 -0400 X-MC-Unique: 7YehZP-eNeuwY3U3-0IrCg-1 Received: by mail-wm1-f71.google.com with SMTP id b81-20020a1c8054000000b0032c9d428b7fso671782wmd.3 for <dev@dpdk.org>; Fri, 22 Oct 2021 03:22:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=Y/qIS89i659vITO7/nGdqdNT0hX7dNxnPc+MUUVxovE=; b=TV0asDTjluA3cG4HPTEUNkmZLU7VRznoYpgExdaTBComv4aJxeE66EB0UIx9h69rjX z+IBlfEqA3uam/V2BimsLZA9Rm4741a8GKu759ZSRMGrc0amoje0gMc9fJ1Muv+SABR6 B8vXjCd+1sKziWlMXY7jtPu3cI793epT4zW3AB175sDAZraJ8nUvKq34R7k9U3Msm4yL EzmyrIoTOJ5O2GFDeLMeNIBVobOJdRSpFl4tBY43fxfCRNq95C5SzCNHcR2zRK3tTsYh /XFCnk871o3bKnCKJcxvAl527MZyB117JXEcwOgz07YiCBeOMQkt/6bq0r0E5g57E68P pYhg== X-Gm-Message-State: AOAM533pxyLCuga+WanapwDr3MJlRijqeuuIdffGD+ESp8JEMwamny52 2b7fQM7d5New3JxynvplzrV1sAdwEF5fYQtDeRYGFssqYV2ej0NVHu3vELP69uF8KOOivjPLNA4 qtLo= X-Received: by 2002:a5d:6349:: with SMTP id b9mr13973436wrw.102.1634898178156; Fri, 22 Oct 2021 03:22:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzABnf/mNtdRdENbjoo/6AV6UfQkmlNxRlTu4wQo4owrq8/bxUIpdECl8XJLeVG4wxly2D+jQ== X-Received: by 2002:a5d:6349:: with SMTP id b9mr13973413wrw.102.1634898177951; Fri, 22 Oct 2021 03:22:57 -0700 (PDT) Received: from [192.168.0.36] ([78.19.105.235]) by smtp.gmail.com with ESMTPSA id n12sm8710813wms.27.2021.10.22.03.22.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Oct 2021 03:22:57 -0700 (PDT) Message-ID: <5ba1af7c-f658-3991-87e5-1d75ddfcae1b@redhat.com> Date: Fri, 22 Oct 2021 11:22:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org Cc: ian.stokes@intel.com, i.maximets@ovn.org, Ray Kinsella <mdr@ashroe.eu> References: <20211022065528.25178-1-david.marchand@redhat.com> From: Kevin Traynor <ktraynor@redhat.com> In-Reply-To: <20211022065528.25178-1-david.marchand@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 22/10/2021 07:55, David Marchand wrote: > This API has been around for more than a year (and is in LTS 20.11). > It did not receive negative feedback and will be used in a next OVS > release. > Mark it stable. > > Signed-off-by: David Marchand <david.marchand@redhat.com> I have tested with rte_lcore_dump(), rte_mp_disable(), rte_thread_register(), rte_thread_unregister() in OVS patches and they are straightforward API and worked fine. rte_lcore_iterate() tested implicitly through rte_lcore_dump(). I haven't used rte_lcore_callback_register()/rte_lcore_callback_unregister() as they are optional but it doesn't make sense to leave them experimental while promoting rte_thread_register()/rte_thread_unregister() which call those callbacks. Noting that rte_lcore_iterate() is also in use for 1+ year from mempool_bucket. Acked-by: Kevin Traynor <ktraynor@redhat.com>