From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49B2143180; Mon, 16 Oct 2023 18:50:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39FF84067D; Mon, 16 Oct 2023 18:50:27 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2066.outbound.protection.outlook.com [40.107.223.66]) by mails.dpdk.org (Postfix) with ESMTP id 083E840269 for ; Mon, 16 Oct 2023 18:50:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oO0dnTl/NDrC2+lxEAmDKJGhofgzg/shk+94u09bC4gMjzaKfDUqr+a016i/xc0XsSX9phgODP6kjEUrqdEp96TbkA4HdDQbi9RLyxfFZSULYqYKBz3QSbV9eO/+13scg/DIgahCuXal77F1P5KtrGNdWRNkODRDdv9gfWW0PkipSQmTmlONa8xSygg8m/t7x69wDKCU4zBc2I6oQUzWsimT61AJEteXDs1c0YK8ON7D7/n2Nc+/WtyJ9sMPEbTtmWtqno1jVAjJpbNxmCml81Mg+zKIkcCskqPi6spq0+zfUGxIeOW/0aAK2dPurftLpCp8Zhctsp+L0f58eI1LLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EOkKWdB1T9O5lEq1+jF4FmvzAiYaSzFhBuppV6kYwLo=; b=nzhX1hD+eMTmauPn16hwXhRJOod9/PvSGuWGNJ+JuOmw3tCsZ4c2nTzfwe1Ty8wzXg/4WGHfQm3lbSX1YalRiCqRwn93eOW7PRsnvw8oaCaB3yGNVxah6713DiOstipoIhvH3f31sUIxX+FjynfWQzx8lu+KPxjiJzPUTnQYds5eAbd4zUe06ytm+NYZQ6e7ZlFsHC6MlP/pk2421D20fHINwCw/QXDCS7Kd8S6KyhHa0dKcaIwQdMeRF3aGlxsYaxdxF0v7i1GrQYZc53eCd2Gt8RkX20d63W6YRhYnLhbw/7RlpLoHsuPR87tgNDt3THhaxXmPlxs0sQk1rjyUVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EOkKWdB1T9O5lEq1+jF4FmvzAiYaSzFhBuppV6kYwLo=; b=MMXVPzDicUztxIjaxGAKCQp8Hw+uA9wwVlbc8kL0QVK5aLASNuaoQynbNMDUny2h2w00LzJ9Mpu2Cs0hb9t8OK7PfLC/AtNcqwlZn9zgG2266gd8Q3QWwjiOH4OWD0uZeC5x3lngdWqX4cdT8nKfMe5D1RS9rIWQaMV3J2CbH2A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7028.namprd12.prod.outlook.com (2603:10b6:510:1bf::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35; Mon, 16 Oct 2023 16:50:24 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6863.032; Mon, 16 Oct 2023 16:50:23 +0000 Message-ID: <5bd2a874-1032-4335-ab0a-a622ac604e46@amd.com> Date: Mon, 16 Oct 2023 17:50:22 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 00/11] Unify the PMD coding style Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com References: <20231012012704.483828-1-chaoyong.he@corigine.com> <20231013060653.1006410-1-chaoyong.he@corigine.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231013060653.1006410-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0375.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:399::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7028:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fbc828a-18d1-4fc8-05b5-08dbce67fdbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l965gHfG2sds1trFIAKo2dfLkQiXRmdbik6zrrur9R7RjdNWrlNcAacgc74abWXphxObpGqRj1AdPxiigJzVLbl64+CZYTuzhhvDQjBz4Iq5IuCQv4rEMIxvDOhPZqGr/rerwECnWixfx2+vt/0FCSEhfoMiqyY+MSGBfJaP38cR5LVjpnYOh+qDvN7l4vRYbNtUFHcOEhtkgDkR3i8rtiwgMP7ZfKZzmaFcT9JFbFkpZ0M8jhNY6MIHUCwlUqkR1diSy47BfDVarZ7c3w+WeqBenaEMqTzrDXjgPelFaGFsE1Ox7RX8bneZqmzm2AL3EuVLd2fqgutXx7L+3Se195varKAECFAlZbojzvPNgk8/SOII1I2tWT5hjLKv3+AmsKO65Ngwh5Ia09AcSNIIu9shAeOLP+srnE7+XK+MgH/qRrbgrcNMlOExea5ZB0GLSIYT1UKxjzHxgovxtu8LbT5JSy3b1KbNQo/be8GZHxLiaSFQ5+q01ri6I6HEr4YCBLKMxwODQob6HGxg/rqXe6FhLbhxFO+WDjo0mfMBKez9MojB9CXKEgYEnDPxtGLTySBZmy3fwfK2K/rPpm6Wccx6IDa86C3jsKY1SHdn/sxA0mttpf3TU3tpiP5rIHICrdDwFd1QmEuwtLo9PiZemg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(366004)(136003)(39860400002)(346002)(396003)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(31686004)(478600001)(66556008)(66476007)(66946007)(6486002)(83380400001)(31696002)(86362001)(38100700002)(2616005)(6512007)(26005)(53546011)(6506007)(316002)(41300700001)(5660300002)(36756003)(44832011)(8676002)(4326008)(8936002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzAzTEtyV1pZdGhjbTE1RnRmMGdURGRXTkxrazBrN3pyMno4bUhBWEpoREZp?= =?utf-8?B?SnZUcHlRaER0amtxQ3BCMGZEeGJVeEQ3aUVuNCtsZmw4NlV4YytBMlQ5cFFX?= =?utf-8?B?UTdTWkg2Yys4Qjc0K1ZtUUV5TytuT3NvdnU3eTJHSk04dHVNVUdOZU5iOWdD?= =?utf-8?B?U3VOTk5VSWJ2d3ZhalpQOEFaVUdLdHZVRU84ODdFL1lUTnhwclVnMURSeVBo?= =?utf-8?B?SlBhdjloTWpaOHdoNGsyN2RWSmwyU2J1TEE0bk82Y3RRUG0xQmFrMlJvTFZB?= =?utf-8?B?QnlWNGZhRVp0RDJDbGJEd0FRQkpobnBQMG9haitYMHZTUWY5M3djbThObmJv?= =?utf-8?B?L3A5MVUyalNlbGt0SVdUQnZheFpYaHhtaTUvN3dhRm91UldhcDd2Wm56dEkr?= =?utf-8?B?UGxDdHl2NTlrREliRFAzcjgzV1Y0T1dmMzFFL05XUVRnYzJlK1liYzY5Y2Vs?= =?utf-8?B?dElvNXVsTk1qbTlWR1dZd0s4S2Z5VEluM0RjRHFKMWNmMEh4M1ZPR3VPSWVq?= =?utf-8?B?UmxBMVI1NU5SaXVySWVVZXZuRlh5aXdhVWJyVUJnMzAwdllkS0wyQWY3U0xG?= =?utf-8?B?TFZCUXlCZ09mR01VWmNKMWhCODhoZFo2SThTblN6eitqOUI2R2tCN1lXNUcy?= =?utf-8?B?R2pxRlBnVDRRZkRXbWRNTXNBd3VyNm9LRkEycXN0VHR0U2NEbmg2M0dJQUpO?= =?utf-8?B?SWZzRUhHNFYwVERSVVRUWnJtdytyeUFpcE5BeWxTM0dwK1dERTB0c0JINWlF?= =?utf-8?B?eUx4YUtXd1RQWDF2TmM0bUc0NFhEOUQwejJ3UWl0R3BJUHNRdlBYcEVxWklK?= =?utf-8?B?TU5Ld2U3azJTcGZxNlZxRkFzd1ZMU3pKb0xaZjZETmpSWkZUbVNhY29HMWZM?= =?utf-8?B?NWVxN0c3YTRBWUlXNFp0bW0wWFZpRmFaYkhFS2o5MUxpWTR1eWh6aHd2RE9F?= =?utf-8?B?czJIa0VjZDFKTEVOTTZGSmErRS8reFVXeTl4VXlpRXZ1c1VQd1Q1Wk5zQnpP?= =?utf-8?B?emlUK2ZTYmFOWmNsYWNwYUZqbTVkeWhOdEVnZmExV2V1VTJwK1RuOVpvQ200?= =?utf-8?B?b0FCQlhvUzJ3aFZjbnBPOTdmaEJ5MUgwblduWElRaC91cDIzUjVsUzdSUkFP?= =?utf-8?B?cmkwVk1hRUtCQ3Rpd0pKajBVYWRJVXF3YmpFN0RWdDZLNmwzVXNINllwbXp2?= =?utf-8?B?Y0RobE1OdU1ZWlZKUGxIV01iQzliZHJRWmFoKzNlU1pESFo2NkRPdmVWY3Nn?= =?utf-8?B?ejljbEVNakpkMGFGOXl2ZFcvSkRkc3RmbVIvZ2p4VzBJc0Q2VHMyYXQ5TXUx?= =?utf-8?B?UHBmb2R6Y0dmZHd1eGh4MElLaUVwYW9PcjNPa1pYWnNKOVhYWVRQbGIzRGxi?= =?utf-8?B?STBnU2lWeEVaeXRzK1ZQc0luWGFNazBLQ3dmVGlicm5EZkNXSVlwNnh3VDZn?= =?utf-8?B?WjQ2czFWbUl2eTRDSlloeVI0cXpBcmFraEljTEw0Mk9zWUhXNWtWOUVUeVZm?= =?utf-8?B?Z21NTkpkN3NsencyWFhabjF1Z3Z2ZCtZdXFCbmZrS2MvdXZvdUp2MXZmT3Rl?= =?utf-8?B?THlySnpDYmR6eHJOOGxQQm5DcllCUXlhdUlCckFFd3NNN1VBcTJxTXRXWWps?= =?utf-8?B?VWhpaHFsOFFvQXMrODFnNHFJcG94MG5xWHVPMHdnbE10aHlzSUw0MHVPREhn?= =?utf-8?B?cklMYlFVQldHekk1dGdBcFRuRlFWWEVIRU4rUlI1V24zSGVBQ01MVHNncjV4?= =?utf-8?B?c09QWGJUMlBkektaWnFyelVBeitORWh0Qzg1WFRiWkZZbGJMN0ZIQy9LSElJ?= =?utf-8?B?TmNhZ3plYWVGR3RuQXg0a0twb1AyeXduT3l2T2xUK293NzhlbDMrbFlPK2pW?= =?utf-8?B?ZnFheWtqYkVhR1pCSmkrMitCV3JWdDlUL2I0cTVyYlRjSmlQVmc5OGUrRGhB?= =?utf-8?B?Y3pQSnBxVVp0aWdXRWMzWEU3THBVRTNTRjJsclgwaDI4S1JpTkJSclo5c0po?= =?utf-8?B?ekpLSG44U3Y3Q0hBcGFzb1VrYVg3a3Fid1l1L3Q2YkFMUHR4SEE5RkV4Mm9X?= =?utf-8?B?K2V1REFPa2hxUVZGVW1PcldwZmlsamlpbE9YZlVzKy8rNDVGYUVleGhNTUpw?= =?utf-8?Q?Sb4+HfoEkR1Iqb2d2h4xnzbSA?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4fbc828a-18d1-4fc8-05b5-08dbce67fdbf X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 16:50:23.9035 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DZqMIihHKMXnJ9HhgIH3Lrz0a0pTMSNihj/vz7caZkFQWEpRjiI/kCq7x8nvTyMm X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7028 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/13/2023 7:06 AM, Chaoyong He wrote: > This patch series aims to unify the coding style of NFP PMD, make the > logics following the same rules, to make it easier to understand and > extend. > Also prepare for the upcoming vDPA PMD patch series. > > --- > v2: > * Add some missing modification. > v3: > * Remove the '\t' character in the log statement as the advice of > reviewer. > --- > > Chaoyong He (11): > net/nfp: explicitly compare to null and 0 > net/nfp: unify the indent coding style > net/nfp: unify the type of integer variable > net/nfp: standard the local variable coding style > net/nfp: adjust the log statement > net/nfp: standard the comment style > net/nfp: standard the blank character > net/nfp: unify the guide line of header file > net/nfp: rename some parameter and variable > net/nfp: adjust logic to make it more readable > net/nfp: refact the meson build file > It is good to take care of the code and update syntax, coding convention etc, but it also creates noise in the git history and makes backporting fixes/patches harder. For a while the driver got lots of refactoring changes, I hope they are completed with the patches in this release. Series applied to dpdk-next-net/main, thanks.