From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 887D343279; Fri, 3 Nov 2023 10:48:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51D6340284; Fri, 3 Nov 2023 10:48:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 937F24027F for ; Fri, 3 Nov 2023 10:48:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699004898; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j79gjs0POKRLjhvMWNFe/IiTzON8pg2uc8QFGBf1iMs=; b=D935kMg46aKgSGCq/pS7lFbf/xe2c7HTMp67Y5/EBF21O9oWCXsLfegmVN5bokUKzTrY8E jggi0sJFRwOErMDyCauDFArhRYJ68Jizxi2gBHH/hNWJ7KDED9gskM8inq6azLZjOCvLhX iSaD66zSWb0KYSMusWdgVFhim/bhtDY= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-bU3jGgs2OgCTK5AXVfN1LQ-1; Fri, 03 Nov 2023 05:48:15 -0400 X-MC-Unique: bU3jGgs2OgCTK5AXVfN1LQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B422A1E441CF; Fri, 3 Nov 2023 09:48:14 +0000 (UTC) Received: from [10.39.208.39] (unknown [10.39.208.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 040CE1C060BA; Fri, 3 Nov 2023 09:48:12 +0000 (UTC) Message-ID: <5bf222a1-3c23-42a5-91dd-fab6a1ceaf68@redhat.com> Date: Fri, 3 Nov 2023 10:48:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 02/11] test/bbdev: update python script parameters To: "Chautru, Nicolas" , "Vargas, Hernan" , "dev@dpdk.org" , "gakhil@marvell.com" , "Rix, Tom" , Hemant Agrawal Cc: "Zhang, Qi Z" References: <20230929181328.104311-1-hernan.vargas@intel.com> <20230929181328.104311-3-hernan.vargas@intel.com> <25566cf0-2c91-43b3-b7cd-7a93b935c4b2@redhat.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= xsFNBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABzSxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPsLBeAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASrOwU0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAHC wV8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/2/23 19:18, Chautru, Nicolas wrote: > Hi Maxime, > >> -----Original Message----- >> From: Maxime Coquelin >> Sent: Thursday, November 2, 2023 10:00 AM >> To: Chautru, Nicolas ; Vargas, Hernan >> ; dev@dpdk.org; gakhil@marvell.com; Rix, Tom >> ; Hemant Agrawal >> Cc: Zhang, Qi Z >> Subject: Re: [PATCH v1 02/11] test/bbdev: update python script parameters >> >> Hi Nicolas, >> >> On 10/27/23 22:02, Chautru, Nicolas wrote: >>> Hi Maxime, >>> >>> Back on this discussion and there was some misunderstanding. This is really >> a bug for the python script helper only. >>> The -t option is already reserved for bbdev-test application (and in doc) for >> setting the iter_max (see main.c). >>> The problem is that the python script introduced -t by mistake for an >> additional time out when calling the binary to be handled in the script only, >> now resolving this by using -T to avoid clash with existing -t option. >>> No one is genuinely using -t for timeout. >>> Ping me if still unclear >> >> I actually understood it from the beginning, -t was used as timeout option in >> the test-bbdev.py script, this patch changes -t to now represent the maximum >> number of iterations. >> >> I'm sure you can see the problem if someone was using -t for timeout in some >> CI (Neither me or you can guarantee this is not used)? >> >> If you think we really should change the meaning of this option, we should >> have a deprecation notice, have both -t and -T to represent timeout during >> the deprecation period and emit a warning when -t is used. Once deprecated, >> you can assign -t to max iterations. >> >> Sounds good? > > The problem with your option is that during that period of time the script is still broken since you cannot set the number of iterations which is what -t is meant for in the binary application. > This is really a fix, and until that fix is applied the python script should not be used, instead the binary should be called directly. > If you want to do it your suggested way and then do the formal fix in 24.03 that is possible even if not ideal to me, but it would still mean the script should arguably not be used during that period of time from my point of view. You will be able to use --iter-max during the transition period, I think it is a good compromise. Ok for you? Thanks, Maxime > Let me know > > >> >> Regards, >> Maxime >> >>> Nic >>> >>>> -----Original Message----- >>>> From: Chautru, Nicolas >>>> Sent: Thursday, October 19, 2023 8:10 AM >>>> To: Maxime Coquelin ; Vargas, Hernan >>>> ; dev@dpdk.org; gakhil@marvell.com; Rix, >> Tom >>>> ; Hemant Agrawal >>>> Cc: Zhang, Qi Z >>>> Subject: RE: [PATCH v1 02/11] test/bbdev: update python script >>>> parameters >>>> >>>> Hi Maxime, >>>> In practice anyone using that API is already using the one defined in >>>> the patch below and not using -t for time out. So not a concern to do >>>> it properly through that patch. >>>> Heman, any concern on your side with this change? >>>> >>>>> -----Original Message----- >>>>> From: Maxime Coquelin >>>>> Sent: Thursday, October 19, 2023 11:19 AM >>>>> To: Chautru, Nicolas ; Vargas, Hernan >>>>> ; dev@dpdk.org; gakhil@marvell.com; Rix, >>>> Tom >>>>> >>>>> Cc: Zhang, Qi Z >>>>> Subject: Re: [PATCH v1 02/11] test/bbdev: update python script >>>>> parameters >>>>> >>>>> >>>>> >>>>> On 10/19/23 11:01, Chautru, Nicolas wrote: >>>>>> Hi Maxime, >>>>>> >>>>>> I believe there was some historical discrepancy, even in doc both >>>>>> appeared >>>>> but none of the 2 -t options with the cap. >>>>>> https://doc.dpdk.org/guides/tools/testbbdev.html >>>>>> Resolving this historical issue here. >>>>> >>>>> Ok, then we should fix the doc, not the code. >>>>> >>>>> Thanks, >>>>> Maxime >>>>> >>>>>> Thanks >>>>>> Nic >>>>>> >>>>>>> -----Original Message----- >>>>>>> From: Maxime Coquelin >>>>>>> Sent: Tuesday, October 17, 2023 9:08 PM >>>>>>> To: Vargas, Hernan ; dev@dpdk.org; >>>>>>> gakhil@marvell.com; Rix, Tom >>>>>>> Cc: Chautru, Nicolas ; Zhang, Qi Z >>>>>>> >>>>>>> Subject: Re: [PATCH v1 02/11] test/bbdev: update python script >>>>>>> parameters >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 9/29/23 20:13, Hernan Vargas wrote: >>>>>>>> Update the timeout argument and default values. >>>>>>>> Update EAL help message and default value. >>>>>>>> Add iter_max and snr arguments. >>>>>>>> >>>>>>>> Signed-off-by: Hernan Vargas >>>>>>>> --- >>>>>>>> app/test-bbdev/test-bbdev.py | 22 ++++++++++++++++++---- >>>>>>>> app/test-bbdev/test_bbdev_perf.c | 2 +- >>>>>>>> 2 files changed, 19 insertions(+), 5 deletions(-) >>>>>>>> >>>>>>>> diff --git a/app/test-bbdev/test-bbdev.py >>>>>>>> b/app/test-bbdev/test-bbdev.py index >> 9cdb4659724d..8d0145076e4d >>>>>>>> 100755 >>>>>>>> --- a/app/test-bbdev/test-bbdev.py >>>>>>>> +++ b/app/test-bbdev/test-bbdev.py >>>>>>>> @@ -25,12 +25,12 @@ def kill(process): >>>>>>>> help="specifies path to the bbdev test app", >>>>>>>> default=dpdk_path + "/" + dpdk_target + >>>>>>>> "/app/dpdk-test- >>>>> bbdev") >>>>>>>> parser.add_argument("-e", "--eal-params", >>>>>>>> - help="EAL arguments which are passed to the test app", >>>>>>>> - default="--vdev=baseband_null0") >>>>>>>> -parser.add_argument("-t", "--timeout", >>>>>>>> + help="EAL arguments which must be passed to >>>>>>>> + the test >>>> app", >>>>>>>> + default="--vdev=baseband_null0 -a00:00.0") >>>>>>>> +parser.add_argument("-T", "--timeout", >>>>>>>> type=int, >>>>>>>> help="Timeout in seconds", >>>>>>>> - default=300) >>>>>>>> + default=600) >>>>>>>> parser.add_argument("-c", "--test-cases", >>>>>>>> nargs="+", >>>>>>>> help="Defines test cases to run. Run all >>>>>>>> if not >>>>>>>> specified") @@ -48,6 +48,14 @@ def kill(process): >>>>>>>> type=int, >>>>>>>> help="Operations enqueue/dequeue burst size.", >>>>>>>> default=[32]) >>>>>>>> +parser.add_argument("-s", "--snr", >>>>>>>> + type=int, >>>>>>>> + help="SNR in dB for BLER tests", >>>>>>>> + default=0) >>>>>>>> +parser.add_argument("-t", "--iter-max", >>>>>>> >>>>>>> We shouldn't change parameters meaning, it will silently break >>>>>>> existing scripts making use of it. >>>>>>> >>>>>>>> + type=int, >>>>>>>> + help="Max iterations", >>>>>>>> + default=6) >>>>>>>> parser.add_argument("-l", "--num-lcores", >>>>>>>> type=int, >>>>>>>> help="Number of lcores to run.", @@ -68,6 >>>>>>>> +76,12 @@ def kill(process): >>>>>>>> >>>>>>>> params.extend(["--"]) >>>>>>>> >>>>>>>> +if args.snr: >>>>>>>> + params.extend(["-s", str(args.snr)]) >>>>>>>> + >>>>>>>> +if args.iter_max: >>>>>>>> + params.extend(["-t", str(args.iter_max)]) >>>>>>>> + >>>>>>>> if args.num_ops: >>>>>>>> params.extend(["-n", str(args.num_ops)]) >>>>>>>> >>>>>>>> diff --git a/app/test-bbdev/test_bbdev_perf.c >>>>>>>> b/app/test-bbdev/test_bbdev_perf.c >>>>>>>> index 276bbf0a2e6d..faea26c10eed 100644 >>>>>>>> --- a/app/test-bbdev/test_bbdev_perf.c >>>>>>>> +++ b/app/test-bbdev/test_bbdev_perf.c >>>>>>>> @@ -26,7 +26,7 @@ >>>>>>>> >>>>>>>> #define MAX_QUEUES RTE_MAX_LCORE >>>>>>>> #define TEST_REPETITIONS 100 >>>>>>>> -#define TIME_OUT_POLL 1e8 >>>>>>>> +#define TIME_OUT_POLL 1e9 >>>>>>>> #define WAIT_OFFLOAD_US 1000 >>>>>>>> >>>>>>>> #ifdef RTE_BASEBAND_FPGA_LTE_FEC >>>>>> >>> >