From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D7C8A046B for ; Thu, 27 Jun 2019 23:27:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 686CA20BD; Thu, 27 Jun 2019 23:27:53 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id BA68B20BD for ; Thu, 27 Jun 2019 23:27:51 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id n4so4053607wrw.13 for ; Thu, 27 Jun 2019 14:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=E3Th+VKGFeW0mGJEHTaQeHePwpqtFGXFNvmCXMmibzI=; b=e2xpG0GUs2C6oidMsfB8y11lZCRX4UuHvohCQQXya1IY3P+vDzC30JELn+I4HbcchA d//2qzJfh/jun4NGyf+Rxw/S+yHf3xZeXEPWdG32oVkz6+JZVeP0ZMaDXcHbGZn2o113 nHOFlY7OJvYmG4hBJCCKs4SinO6WG9JS7mzbL+mDhFLwhk3H1usXuSV4FVkWDBxeqp9X FLqerHN3K4BnPRkPrHkvqV6MFAjmAv21UutwVM/QDehvGv/fT5aEUn71+rq6mT9+F+zE lTrPRLoUwZSqDZQOtiw4mtVhIJNX+Q2AfBzc3vi6jv+8Q5yKem0nU0zCDj+BRbA9YrDM CdHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E3Th+VKGFeW0mGJEHTaQeHePwpqtFGXFNvmCXMmibzI=; b=puz7gmRNr2WsvH7u1R5on5/srFNDa7z3qv2td5O4oyVlEEjhC14ZDVndhkvm+XaUZT 775LkeFq3dFCJHVNB5pLrv8Dben7h+YwBbAnl/AoHvO6NLcTvnWG2Rd40zUxSqLfSv8p qilBdpqIqjjGOXRuvEGsTzwQW/BCxZs+5JkVw6B0oC0ojx3cp98LSqhdBBUThYZTM4sO 5WjcLiDJzr99P7WsRiqz6X0DB1I20ZFfiROnv4Ks7xaqpX+Uc+A7AIDdw9csB7fBUPUF wWgIeS+Ww2wedHVe8nGa6NQrAeOEeHRh7TZFP0Jo/Vmxluob6R38YwJEnwNqPFZ5CtbU vEXA== X-Gm-Message-State: APjAAAWfKmXJ3zgqGuf/F73DWg6wu8OkNYS4Ep3rChIhssuPLwLPlCBA A2pPbH0swK3s9VPnn9yevgYeOXev5rqW+Q== X-Google-Smtp-Source: APXvYqyyiyUW+679zl8nTDASwqWXSlDaef2Ixv+I4Yzg3eLHRgJGQJYCPBScDLRptEdR+3FyWl9wsA== X-Received: by 2002:adf:b64b:: with SMTP id i11mr4800038wre.205.1561670871491; Thu, 27 Jun 2019 14:27:51 -0700 (PDT) Received: from [192.168.1.6] (178.43.130.103.ipv4.supernova.orange.pl. [178.43.130.103]) by smtp.gmail.com with ESMTPSA id 35sm392300wrj.87.2019.06.27.14.27.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jun 2019 14:27:51 -0700 (PDT) To: Shally Verma , "dev@dpdk.org" , "fiona.trahe@intel.com" , "arturx.trybula@intel.com" References: <1560032553-15528-1-git-send-email-tjozwiakgm@gmail.com> <1561566633-12329-1-git-send-email-tjozwiakgm@gmail.com> <1561566633-12329-3-git-send-email-tjozwiakgm@gmail.com> <5fe0d9e5-2524-ac41-8f97-ec4fa8390d91@gmail.com> From: Tomasz Jozwiak Message-ID: <5c2e2de5-a11e-1605-f087-d55d3f596a85@gmail.com> Date: Thu, 27 Jun 2019 23:27:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest command line option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shally, > >> -----Original Message----- >> From: Tomasz Jozwiak >> Sent: Wednesday, June 26, 2019 11:05 PM >> To: Shally Verma ; dev@dpdk.org; >> fiona.trahe@intel.com; arturx.trybula@intel.com >> Subject: Re: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest >> command line option >> >> Hi Shally, >> >> >>>> -----Original Message----- >>>> From: Tomasz Jozwiak >>>> Sent: Wednesday, June 26, 2019 10:00 PM >>>> To: dev@dpdk.org; fiona.trahe@intel.com; tjozwiakgm@gmail.com; >> Shally >>>> Verma ; arturx.trybula@intel.com >>>> Subject: [EXT] [PATCH v3 2/7] app/test-compress-perf: add ptest >>>> command line option >>>> >>>> External Email >>>> >>>> --------------------------------------------------------------------- >>>> - >>>> From: Tomasz Jozwiak >>>> >>>> This patch adds --ptest option to make possible a choose of test case >>>> from command line. >>>> >>>> Signed-off-by: Tomasz Jozwiak >>>> --- >>>> app/test-compress-perf/comp_perf_options_parse.c | 36 >>>> ++++++++++++++++++++++++ >>>> 1 file changed, 36 insertions(+) >>>> >>>> diff --git a/app/test-compress-perf/comp_perf_options_parse.c >>>> b/app/test- compress-perf/comp_perf_options_parse.c >>>> index bc4b98a..07672b2 100644 >>>> --- a/app/test-compress-perf/comp_perf_options_parse.c >>>> +++ b/app/test-compress-perf/comp_perf_options_parse.c >>>> @@ -15,6 +15,7 @@ >>>> >>>> #include "comp_perf_options.h" >>>> >>>> +#define CPERF_PTEST_TYPE ("ptest") >>>> #define CPERF_DRIVER_NAME ("driver-name") >>>> #define CPERF_TEST_FILE ("input-file") >>>> #define CPERF_SEG_SIZE ("seg-sz") >>>> @@ -37,6 +38,7 @@ static void >>>> usage(char *progname) >>>> { >>>> printf("%s [EAL options] --\n" >>>> + " --ptest benchmark / verify :" >>>> " --driver-name NAME: compress driver to use\n" >>>> " --input-file NAME: file to compress and decompress\n" >>>> " --extended-input-sz N: extend file data up to this size >>>> (default: no extension)\n" >>>> @@ -76,6 +78,37 @@ get_str_key_id_mapping(struct name_id_map >> *map, >>>> unsigned int map_len, } >>>> >>>> static int >>>> +parse_cperf_test_type(struct comp_test_data *test_data, const char >>>> +*arg) { >>>> + struct name_id_map cperftest_namemap[] = { >>>> + { >>>> + >>>> cperf_test_type_strs[CPERF_TEST_TYPE_BENCHMARK], >>>> + CPERF_TEST_TYPE_BENCHMARK >>>> + }, >>>> + { >>>> + cperf_test_type_strs[CPERF_TEST_TYPE_VERIFY], >>>> + CPERF_TEST_TYPE_VERIFY >>>> + }, >>>> + { >>>> + cperf_test_type_strs[CPERF_TEST_TYPE_PMDCC], >>>> + CPERF_TEST_TYPE_PMDCC >>> What is PMDCC here? What kind of test type? >> [Tomek] This's for 'pmd_cyclecount_test'. Actually compression_perf tool >> >> doesn't support that test, but we added a sort of 'template' for that, cause >> there's a plan to add >> >> this test in the future. > Isn’t it better we add this .. when we actually add feature? [Tomek] True , I'll remove this in V4. Thx, Tomek