From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9259D137C for ; Tue, 18 Sep 2018 15:01:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2018 06:01:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,389,1531810800"; d="scan'208";a="258242755" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by orsmga005.jf.intel.com with ESMTP; 18 Sep 2018 06:01:03 -0700 To: Xiaoyun Li , beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, zhiyong.yang@intel.com, thomas@monjalon.net, bruce.richardson@intel.com References: <1535595399-430873-1-git-send-email-xiaoyun.li@intel.com> <20180918022240.49376-1-xiaoyun.li@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <5c47a24f-3db0-5a52-e57e-2b0098f33267@intel.com> Date: Tue, 18 Sep 2018 14:01:02 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180918022240.49376-1-xiaoyun.li@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7] net/i40e: add interface to use latest vec path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 13:01:13 -0000 On 9/18/2018 3:22 AM, Xiaoyun Li wrote: > For IA, the AVX2 vector path is only recommended to be used on later > platforms (identified by AVX512 support, like SKL etc.) This is because > performance benchmark shows downgrade when running AVX2 vector path on > early platform (BDW/HSW) in some cases. But we still observe perf gain > with some real work loading. > > So this patch introduced the new devarg use-latest-supported-vec to > force the driver always selecting the latest supported vec path. Then > apps are able to take AVX2 path on early platforms. And this logic can > be re-used if we will have AVX512 vec path in future. > > This patch only affects IA platforms. The selected vec path would be > like the following: > Without devarg/devarg = 0: > Machine vPMD > AVX512F AVX2 > AVX2 SSE4.2 > SSE4.2 SSE4.2 > > With devarg = 1 > Machine vPMD > AVX512F AVX2 > AVX2 AVX2 > SSE4.2 SSE4.2 > > Other platforms can also apply the same logic if necessary in future. > > Signed-off-by: Xiaoyun Li > --- > v7: > * Use uint_8 instead of bool type for struct member. > v6: > * Polish the doc and commit log. > * Use rte_kvargs_process instead of directly kvlist internals. > v5: > * Simpify the rx set function. > v4: > * Polish the codes. > v3: > * Polish the doc and commit log. > v2: > * Correct the calling of the wrong function last time. > * Fix seg fault bug. > --- > doc/guides/nics/i40e.rst | 8 ++ Doc is causing warning: doc/guides/nics/i40e.rst:172: WARNING: Unexpected indentation. Except from that, Reviewed-by: Ferruh Yigit