DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems
@ 2020-05-01 11:08 Harry van Haaren
  2020-05-01 11:50 ` Ferruh Yigit
  2020-05-11 20:56 ` David Marchand
  0 siblings, 2 replies; 4+ messages in thread
From: Harry van Haaren @ 2020-05-01 11:08 UTC (permalink / raw)
  To: dev; +Cc: bernard.iremonger, ferruh.yigit, Harry van Haaren, stable

This commit fixes failures of the flow_classify_autotest when
ran on dual-socket servers, as the sample application does not
support more than a single socket. Increasing the NB_SOCKETS
value allows the test to run successfully.

Fixes: 9c9befea4f57 ("test: add flow classify unit tests")

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

---

DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot
easily statically allocate the array. As a bugfix patch, I'd
prefer not add complexity of dynamically allocating based on
rte_socket_count(), hence just increasing the value seems the
most pragmatic fix.

Fixes: tag is a bit complex, code was moved in previous commit.
This fixes tag is against when the NB_SOCKET = 1 was introduced.

Cc: stable@dpdk.org

---
 app/test/test_flow_classify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
index ff5265c6a..ef0b6fdd5 100644
--- a/app/test/test_flow_classify.c
+++ b/app/test/test_flow_classify.c
@@ -23,7 +23,7 @@
 
 #define FLOW_CLASSIFY_MAX_RULE_NUM 100
 #define MAX_PKT_BURST              32
-#define NB_SOCKETS                 1
+#define NB_SOCKETS                 4
 #define MEMPOOL_CACHE_SIZE         256
 #define MBUF_SIZE                  512
 #define NB_MBUF                    512
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems
  2020-05-01 11:08 [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems Harry van Haaren
@ 2020-05-01 11:50 ` Ferruh Yigit
  2020-05-05 11:02   ` Iremonger, Bernard
  2020-05-11 20:56 ` David Marchand
  1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2020-05-01 11:50 UTC (permalink / raw)
  To: Harry van Haaren, dev; +Cc: bernard.iremonger, stable

On 5/1/2020 12:08 PM, Harry van Haaren wrote:
> This commit fixes failures of the flow_classify_autotest when
> ran on dual-socket servers, as the sample application does not
> support more than a single socket. Increasing the NB_SOCKETS
> value allows the test to run successfully.
> 
> Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
> 
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> ---
> 
> DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot
> easily statically allocate the array. As a bugfix patch, I'd
> prefer not add complexity of dynamically allocating based on
> rte_socket_count(), hence just increasing the value seems the
> most pragmatic fix.
> 
> Fixes: tag is a bit complex, code was moved in previous commit.
> This fixes tag is against when the NB_SOCKET = 1 was introduced.
> 
> Cc: stable@dpdk.org
> 

Thanks for the fix.

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems
  2020-05-01 11:50 ` Ferruh Yigit
@ 2020-05-05 11:02   ` Iremonger, Bernard
  0 siblings, 0 replies; 4+ messages in thread
From: Iremonger, Bernard @ 2020-05-05 11:02 UTC (permalink / raw)
  To: Yigit, Ferruh, Van Haaren, Harry, dev; +Cc: stable

Hi Harry,

> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, May 1, 2020 12:51 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: Re: [PATCH] test/flow-classify: fix failure on dual socket systems
> 
> On 5/1/2020 12:08 PM, Harry van Haaren wrote:
> > This commit fixes failures of the flow_classify_autotest when ran on
> > dual-socket servers, as the sample application does not support more
> > than a single socket. Increasing the NB_SOCKETS value allows the test
> > to run successfully.
> >
> > Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> >
> > ---
> >
> > DPDK does not provide a RTE_SOCKETS_MAX #define, so we cannot easily
> > statically allocate the array. As a bugfix patch, I'd prefer not add
> > complexity of dynamically allocating based on rte_socket_count(),
> > hence just increasing the value seems the most pragmatic fix.
> >
> > Fixes: tag is a bit complex, code was moved in previous commit.
> > This fixes tag is against when the NB_SOCKET = 1 was introduced.
> >
> > Cc: stable@dpdk.org
> >
> 
> Thanks for the fix.
> 
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
Tested-by: Bernard Iremonger <bernard.iremonger@intel.com

The Cc: stable@dpdk.org line should be after the fixes line in the commit message.

Otherwise

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems
  2020-05-01 11:08 [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems Harry van Haaren
  2020-05-01 11:50 ` Ferruh Yigit
@ 2020-05-11 20:56 ` David Marchand
  1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2020-05-11 20:56 UTC (permalink / raw)
  To: Harry van Haaren; +Cc: dev, Iremonger, Bernard, Yigit, Ferruh, dpdk stable

On Fri, May 1, 2020 at 1:07 PM Harry van Haaren
<harry.van.haaren@intel.com> wrote:
>
> This commit fixes failures of the flow_classify_autotest when
> ran on dual-socket servers, as the sample application does not
> support more than a single socket. Increasing the NB_SOCKETS
> value allows the test to run successfully.
>
> Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Cc: stable@dpdk.org


> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>

Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Bernard Iremonger <bernard.iremonger@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-11 20:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-01 11:08 [dpdk-dev] [PATCH] test/flow-classify: fix failure on dual socket systems Harry van Haaren
2020-05-01 11:50 ` Ferruh Yigit
2020-05-05 11:02   ` Iremonger, Bernard
2020-05-11 20:56 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git