From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 358A642E5E; Thu, 13 Jul 2023 10:14:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A02CD4114B; Thu, 13 Jul 2023 10:14:41 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2087.outbound.protection.outlook.com [40.107.212.87]) by mails.dpdk.org (Postfix) with ESMTP id 7226540DDA; Thu, 13 Jul 2023 10:14:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2pBY0SP7Org13ueOAnJwCe9NoWKlaDJBekh7ro3q7NVwzXCBmxHl8XJDES3hc3ON65EjoDHCmtJD4uNUKVCOXU4Pf0KBMOnewDhoFfdRnTwe4fv3lHDUPEGJ8gVxQMj59+2iPB6IbozOHHls3wNgdsHauVa88vSCGHO0vwLLHzLLYJo1lS27ah5ox5FPIfvwm4VXXsl7vCL40Auj7ddGD1iOztQ2tHFlFE9gZgODPEvEgGt+yCir4TedVy+5GtkvcAcwDl9uEWxoLVlRxlvrNXG/G6waZRrQHeXVtnk9SRdMSgYenD4A2fDviPnjFG2Lnrep7UBG5dd5uMuhEt7aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1wmBaK+njohoi5kcOTZv5J7c5YH3KoINrv1XY/MxQw=; b=ksM9X9FR9/Sk6xwWHDS5Ll5QSiv2r0GlWarCpOwZqjA5qKyKbFXVUCHIL5bfUpX4CFpQ+4qb1Amv79DAfAQTCEb0MJeIfFqDwJwtdjBgBrR/RU3bEghwHJAehwKGwA0d+yvBQxcGwF4vwUlm4rdS7j1M9E/H2HKs3Mf0fEJshi7yiZyT12HyFkafK7vf9TQzcVUwfr352xB3G4QYg5lW2xf9RqiLEnve1EBsiVo+Kng6oRyQKG/shC5ueOpOS3v2b/16rg3e+eMqdCZvLBludvuUT/wertRZqcWcbq6uXjG2a0FRgsRF0F7LLPU/0CwKcjO49nzBt3My2+NkRMFYLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1wmBaK+njohoi5kcOTZv5J7c5YH3KoINrv1XY/MxQw=; b=WZJXppodyFT86huTFlynEc9tA2SXEexzidXrB7hlIo7OuR2SV1jAenHocOP3AXmYAguia0dMhvzKei7UsB5f6E8YpdNBatxpdNCBYk7lvjSlNpsXLH7IfKN2G2iHB9yDMLo6I+mFpti1a6JBitJCm1gcc+QcSpc/qODQyjjR5U4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB7449.namprd12.prod.outlook.com (2603:10b6:806:299::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Thu, 13 Jul 2023 08:14:38 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::369d:5f05:aaba:ebd8%3]) with mapi id 15.20.6565.028; Thu, 13 Jul 2023 08:14:38 +0000 Message-ID: <5c739f65-cd97-59af-74f9-43f99e8e5a15@amd.com> Date: Thu, 13 Jul 2023 09:14:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] net/nfp: fix invalid control message packets Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Long Wu , stable@dpdk.org, Thomas Monjalon References: <20230713030217.1142257-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230713030217.1142257-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0217.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB7449:EE_ X-MS-Office365-Filtering-Correlation-Id: 219a56ef-85d0-4c88-fb60-08db83793332 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lLLO3T5OOSrxod9ZRMgqUA+d0YdA0uHNOz4e1ehhhCp7Wt3jqRsCzcr5KSyzDJoXEDd+kgCI7/aZ/YeYD+C38SmU3hs/efZ+/KAJE7GXldmt7R3VlMFHp+9RS1haRavTWlJ9S0THEnYfUKjWvjsxv9lUF+ijeVd9o7Qj8WMjQvYoezgp2n+865Qn/vxeKJfVrFmhymki20NF4NiV59T3YQLXzXGwJ2YzwT0WITuSdtBvoI8Zz6pqYSzIVli03J6EKr11I2nWZxLq2a+Go49BkczQcTZhW2vMOP89hg2AISWdnmXFcDf634AazGVbHDGCExlIH3z+YzoQk0xzewekQwg+Gb5+5VUO9ERg3o9Xyu+v49J4FNUvqmUpTAYsFzY6Nvh6DWO66JLPzO2+N+uAV/r9TFsoHmwfosNuD0hqCaFGE6wp5xAO5DIN80D77QkPpVSXNBoJ8Rg2TbuSvPsvCYNDtMtdt/05pinAPaQazcbfLzP0+/t/KcmSuWYsOx+fe+fO3G2aCfpZGpat+d9q4wn0/5UmG1cJgsdrwwQjzM6Aj0wFqj6OeehZmQRYTnqFzWWuBUHrra9N5E2VOEO/HBgzxH2KXZPVQzaYCq+RGx+rm0x6yBYqF4tQWHYBBybmQP4d/afgW4qjePxfRy8xxw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(66556008)(66946007)(66476007)(2906002)(316002)(4326008)(6512007)(41300700001)(5660300002)(36756003)(26005)(54906003)(38100700002)(6506007)(8936002)(8676002)(31696002)(86362001)(6666004)(478600001)(44832011)(53546011)(186003)(31686004)(2616005)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlppakRHQTVyZ1M1SU5zcHBRcnlxeEJXSDNBTU03WDczbElnSCsxWTdsZlpq?= =?utf-8?B?aWFDV0RFOG1RQ25COUZvQ2dJS3UycmJJdGIrbGF4V2tOeUlKdzFOM0lIV2ZZ?= =?utf-8?B?WkZsT3VTUUttQTlVWHNhbnVJcHJIMmVid3UrekFpNDVPd0YzYmR1cXF6MU1o?= =?utf-8?B?YnF4RWFIQlJUcnA1TWQ3MmNjWnBNZmtEMFRkKzRuS0xJWGFFcDk4NEEzTUUy?= =?utf-8?B?NGZQbEI2a0VGbHQwM0RiNUQxTGRCZHdvckxUaEprTVZHSlpRUlBRTXNmdGph?= =?utf-8?B?a0ZqSmNlb1dSWCt0NHJmbWdJQWtMdDBVUFlaZnVFOXF0d1V6Tmt2UEx4WDgz?= =?utf-8?B?blFCTHlOTmhJUzlBUisrNDVYTUZSR3ovZnF6bTI3dUZZOGROeXZzd1o2SUIr?= =?utf-8?B?ckV5MXF0TGNkV01xTjJxTlkyc08xRktwSWYwYU05L2tpSjJyaHJWdndzRXFu?= =?utf-8?B?c2JXMnd0c3JHOGhwb2IxUmRNRnRtcERrK2pBa0ttcHhBNDIremV3Vk0rOHdT?= =?utf-8?B?N09TV3A4eEUzZTRoSmREdjhzNkdvQ0l3K1NIWEZFZVpvbnBZNmpKK3NvNnBv?= =?utf-8?B?R0xpMlZlY2NGM2crNVFoV1B5WnZqYjlpcUhTa1BOWHFoSlIwOFk1ajQyRFEw?= =?utf-8?B?a2NHbGwxNkJEdS8ydG0vWlF6c3FHbDg5c1lSYkl5bFdBdWs0VmUvL0RaU0lu?= =?utf-8?B?R0xlM0lDYmRtdHlSdkl4YkMwVy9GZ0NIZ1N1T2ZBdVVoU3RqQldiUURmZTJJ?= =?utf-8?B?RGg4N0VhNjRWc0VvSzhwcFdZQmxXQzZqMzkxcmN6b3BoNGRNZ2pEYlBycGFR?= =?utf-8?B?TlhkaDlGYkZVbWxSYzk3Ymd0Z1BxczZNQkZWWDA3enM4aVlpSEtSNXB5WHRV?= =?utf-8?B?b3dYelFBejJNY0diNktIMlN6dmc5eHRJdnY3UlZWTWpvdnJ5Yk01b0V2UUs1?= =?utf-8?B?RXdTcDh4SFVFUXJjN1dDVm1sUzNWbVlBSHdpcDB5ajA3cExyemtLV3NvRU04?= =?utf-8?B?bXl4a0JIRG1HZWt5czVEU2Fnbmw4UXRNVkJkaTBmWm0wcXRjRkFTTWtwZDla?= =?utf-8?B?MU9aQzZ6RGJRb2VRdlc4Z3M5UjdUN2phYlRpMm0xckNxYTV4VXczamVETFlI?= =?utf-8?B?dk80cDhKTXNMWTRqSGJuZ2ZRMWYrUnRFRTZtVDM3QkZ2ZnN5RVE4bWRwbmpp?= =?utf-8?B?cGVyTnowQzBhN1ljZjNtUUhRZzBRMzNvZW5zWSsxNHBlQVlsb2o2aXJManA3?= =?utf-8?B?L3YzNVhBQzdJTXh0MDJtUjdNck91eGJQWHZCUE1vM3FLWDdXc2lGUUhEb1Bp?= =?utf-8?B?b3lYYm9lNE9ycmZVazcrVDNYSjE1WmVVM0l4eUtpdEczWTRYdFVJSGFIQWlQ?= =?utf-8?B?N0ZOSkRBOGZGTER0SnRuU1Yybm1HdloraEJmUVhzREtPQ0RRRmQ2aTNuV00y?= =?utf-8?B?ckd2NkdHdHZmejNJSE9sSjRFMndTNnVKNytLVEkrc3FXbnh3bWpsNkxMTlN6?= =?utf-8?B?SXptNEdkVTVrcUI5ZnY3T1NnZTNoZE5TODlrM2d4bEtTbTJjRFc1M1c4N25N?= =?utf-8?B?cHphUzFEaXd0WGdaVWtlMU1TUUpIblZBZVF5T0JKT2hsVS9tR0Y2QkNJS0VV?= =?utf-8?B?U2hxcnE3bDdxb21remMvTjhjbWwvZmJCbThWYTBiNk03Zjg0R0tkSlprNmoy?= =?utf-8?B?WXE5d3oybWs2TDNkUjQzWVluaGs1dlJONmJqTit4Sko3Ym1mREdoNDZxdmx6?= =?utf-8?B?bmw2TUxCNjJRaTFJejE1aThNcnQ4d1VIQ2k5elU1ZDNBZWhnVTVCbnlyOUtn?= =?utf-8?B?cE5BZmdaWkp6bVFibTdjdGppMys1dXkzYWhJTjlqN0VaeHFvaEU3cnlSZno2?= =?utf-8?B?VHFGQURTTFVXakl6OGF3b3lvTE1GZGk5S3VDNDlYSGVYZlczRXA0dTZLeVR2?= =?utf-8?B?RjZ5TnJtb1FhVU1pRk01REN3SHY1cDl6R1RoYTNOTkpvdlc1Ukw3TGtkSzZ2?= =?utf-8?B?VGhsT0w4eG16NFBsMTNERUxwb0tJTUdPY25WMFFQZ1IwbFcySnFkLzdvZjFU?= =?utf-8?B?THJDdlNzVnZkc2N3eThJNTcreFlnOGl2SzJGaUI0WlJVZ0YrbDN3YmZZWXJY?= =?utf-8?Q?GYPGIAIYWJZc/326VNDrT5nD3?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 219a56ef-85d0-4c88-fb60-08db83793332 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:14:37.8556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5XsBSsnFE8Ql2Q0jlDdYEnUwtkkc53RiGxiF7OrkH60IxihuXqBqX6bjfM0NgNs6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7449 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/13/2023 4:02 AM, Chaoyong He wrote: > From: Long Wu > > If we add two cards that uses flower firmware into one dpdk-testpmd, > NFP PMD will printf error log. The reason is that the second card > uses the control VNIC Rx queue of the first card. > > Because rte_eth_dma_zone_reserve() will reserve new DMA zone if > DMA zone's name is unique. But if there is already a zone with the > same name, rte_eth_dma_zone_reserve() will return the pointer of > the previously DMA zone. We try to reserve DMA zone for each card > but we use the same name to reserve. > > We use the PCI address to give control VNIC a unique ring name > to avoid the above situation and let each NIC's ring have its > own DMA zone. > > Fixes: 945441ebdb9c ("net/nfp: add flower ctrl VNIC") > Cc: chaoyong.he@corigine.com > Cc: stable@dpdk.org > > Signed-off-by: Long Wu > Hi Chaoyong, Is this patch for this release or next one? -rc3 is already out, after this point we should have documentation and critical fixes.