From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E282A317C for ; Thu, 17 Oct 2019 16:09:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 264CC1E934; Thu, 17 Oct 2019 16:09:05 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9087D1E930 for ; Thu, 17 Oct 2019 16:09:02 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id p14so2537930wro.4 for ; Thu, 17 Oct 2019 07:09:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=/0H5H77uyEm4lNYiIwcEAwlKpgNrnMCzRLofVFQ1zj8=; b=KhMc6DUwDd9K9dJAxNr52wZefcg+NuULQvmWSU/B51eHe6g2DRk/U2x47ul64RAhKs ki8v5Om6+C8TxhT240HwREvekmi0H/1oMzIFRiAKt7jYwN7pL0w8S+6Ci17NF8PUCTAX gDvCAF6ByqFuD3MW7VNII9IE+TcNJPTXiUmtKybquWzI/byy6yLO9pMLEyXkacD4kY53 zGKsweFJKIozKozGuRnQxsAOcq1Q/piGjYb8AL1bb9smvhzu2Uir2YKcY3JTg64U3+aO ERLhemObdwJG8GeDuzdIp0hOrRI7VfG8dyiRiCOeYauqJZxn4oDG0guT4xE9idm4TGlu YEOA== X-Gm-Message-State: APjAAAWmROVIGUCmz221spRLku3v4kz46NCdPtDUJBbm4KEgpE4oBS2N sKBcsKv2MBifcsdJgCExb2s= X-Google-Smtp-Source: APXvYqy7VutFPZiAp26orBKlPtUnE+KQDkgAubnjEDiW++7ZFCiFa7Ad8ziBxgKRZ3lfAiEH8kU1TQ== X-Received: by 2002:a5d:440b:: with SMTP id z11mr3083390wrq.309.1571321341851; Thu, 17 Oct 2019 07:09:01 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n14sm1836879wro.83.2019.10.17.07.09.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 07:09:00 -0700 (PDT) Message-ID: <5c8c094e3bbac75068ae86a0682f6b31a2f7e417.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , Anatoly Burakov , Christian Ehrhardt Cc: dev@dpdk.org, Marcin Baran , Thomas Monjalon , john.mcnamara@intel.com, david.marchand@redhat.com, Pawel Modrak , ktraynor@redhat.com Date: Thu, 17 Oct 2019 15:09:00 +0100 In-Reply-To: <20191017084459.GA855@bricha3-MOBL.ger.corp.intel.com> References: <671cb144be5089abff524ef452ad7bb8b6778524.1571245316.git.anatoly.burakov@intel.com> <20191017084459.GA855@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/9] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2019-10-17 at 09:44 +0100, Bruce Richardson wrote: > On Wed, Oct 16, 2019 at 06:03:36PM +0100, Anatoly Burakov wrote: > > From: Marcin Baran < > > marcinx.baran@intel.com > > > > >=20 > > As per new ABI policy, all of the libraries are now versioned using > > one global ABI version. Changes in this patch implement the > > necessary steps to enable that. > >=20 > > Signed-off-by: Marcin Baran < > > marcinx.baran@intel.com > > > > > Signed-off-by: Pawel Modrak < > > pawelx.modrak@intel.com > > > > > Signed-off-by: Anatoly Burakov < > > anatoly.burakov@intel.com > > > > > --- > >=20 > > Notes: > > v3: > > - Removed Windows support from Makefile changes > > - Removed unneeded path conversions from meson files > >=20 > > buildtools/meson.build | 2 ++ > > config/ABI_VERSION | 1 + > > config/meson.build | 5 +++-- > > drivers/meson.build | 20 ++++++++++++-------- > > lib/meson.build | 18 +++++++++++------- > > meson_options.txt | 2 -- > > mk/rte.lib.mk | 13 ++++--------- > > 7 files changed, 33 insertions(+), 28 deletions(-) > > create mode 100644 config/ABI_VERSION > >=20 > > diff --git a/buildtools/meson.build b/buildtools/meson.build > > index 32c79c1308..78ce69977d 100644 > > --- a/buildtools/meson.build > > +++ b/buildtools/meson.build > > @@ -12,3 +12,5 @@ if python3.found() > > else > > map_to_def_cmd =3D ['meson', 'runpython', files('map_to_def.py')] > > endif > > + > > +is_experimental_cmd =3D [find_program('grep', 'findstr'), '^DPDK_'] > > diff --git a/config/ABI_VERSION b/config/ABI_VERSION > > new file mode 100644 > > index 0000000000..9a7c1e503f > > --- /dev/null > > +++ b/config/ABI_VERSION > > @@ -0,0 +1 @@ > > +20.0 > > diff --git a/config/meson.build b/config/meson.build > > index a27f731f85..3cfc02406c 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -17,7 +17,8 @@ endforeach > > # set the major version, which might be used by drivers and > > libraries > > # depending on the configuration options > > pver =3D meson.project_version().split('.') > > -major_version =3D '@0@.@1@'.format(pver.get(0), pver.get(1)) > > +abi_version =3D run_command(find_program('cat', 'more'), > > + files('ABI_VERSION')).stdout().strip() > > =20 > > # extract all version information into the build configuration > > dpdk_conf.set('RTE_VER_YEAR', pver.get(0).to_int()) > > @@ -37,7 +38,7 @@ endif > > =20 > > pmd_subdir_opt =3D get_option('drivers_install_subdir') > > if pmd_subdir_opt.contains('') > > - pmd_subdir_opt =3D > > major_version.join(pmd_subdir_opt.split('')) > > + pmd_subdir_opt =3D > > abi_version.join(pmd_subdir_opt.split('')) > > endif >=20 > This is an interesting change, and I'm not sure about it. I think for > user-visible changes, version should still refer to DPDK version > rather > than ABI version. Even with a stable ABI, it makes more sense to me > to find > the drivers in a 19.11 directory than a 20.0 one. Then again, the > drivers > should be re-usable across the one ABI version, so perhaps this is > the best > approach. >=20 > Thoughts from others? Luca or Kevin, any thoughts from a packagers > perspective? >=20 > /Bruce Hi, We are currently assembing this path using the ABI version in Debian/Ubuntu, as we want same-ABI libraries not to be co-installed, but instead fo use the exact same name/path. So from our POV this change seems right. --=20 Kind regards, Luca Boccassi