From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E491A0093; Mon, 14 Nov 2022 19:33:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 42DC242D0C; Mon, 14 Nov 2022 19:33:08 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2079.outbound.protection.outlook.com [40.107.92.79]) by mails.dpdk.org (Postfix) with ESMTP id 0D62140150 for ; Mon, 14 Nov 2022 19:33:07 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g98EUWhqBv4stCaylT9Rb/6GaKoMVju2VQBM26dEYVgiwpFYEk1UuWBCX4UoJwhlJkw3ZJCtxg5wArDAAyMYD4OB4NIfo/J5Tq1oqR7o7paiS1EGAv6iinM9O0uQYiPrwVKmASnGA7ecDQhtSXx8GPluwn6+2bHAzLbxayodwSUhga+80R7jEK7N+3lpEooEP+eenhYlVxynUibBdx/UTJ01szUyF4K1c6Nl0DOJ4VMCVj7Ky/ARbEBuce5EVbCGUCUEY+B3jFi70hL2Fb2kGYdRjSU/INZ3M7NeDZIGxnZJT668fFRqt7H+3Jx9tfJLjRuMWxLLOotHPns6XzsNLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Htu6+LRxsx2pkN7Mq9uyPjhoerLiCV9B2WI/zTfzj0=; b=iuPrsPx3CLTgRDDgPLMWB6eK7rHvVERPD7X4lEydnyV2gufs+MxOx998QRNzuxrcmIcjk3e4H1Mpqe+mWrtwP5OjzQze24bmCoh1PxydwAYLCHRKuEtOznH2gB97zUQV0VgBsJU6i6gsUzoJWyXafWyngj85yZM0DfvpmsxfsrjbzZ37zNHkY3e+ObkszjSPY2wc41k6RA/OsXpGOiTarF2MDIzpKTs7T6/16nkz/sU5I120cKBnCgsFoqdUR48oSXJrPriw566Xo6N6Fz7fk5ZV+1E6Z7OExORjtYu66OZnsudaB3mS0D4FQ1IPhsOAK4+eGx6wTxY1e/R3QXbUQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Htu6+LRxsx2pkN7Mq9uyPjhoerLiCV9B2WI/zTfzj0=; b=zD/aH5SPft5mCPRgBefBtiCcorXM2pUEebQwNY1EVbnrUfCjOWZF8WV1h8dVQ0Yi7pjV9Rjj5rUVrUnBDmX038fNdIt5wjT0osR77CBT9yvLMCtNPJXSBLiz20SMxXN9Mjv8HIbLvtSIOH+oukSAuafplvSa8cbG37omZvxbxlk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BN9PR12MB5131.namprd12.prod.outlook.com (2603:10b6:408:118::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Mon, 14 Nov 2022 18:33:05 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::b482:d5bd:c7d0:3842%9]) with mapi id 15.20.5813.017; Mon, 14 Nov 2022 18:33:05 +0000 Message-ID: <5c99f8a3-48a4-22c2-ccdd-c97a274a7c7d@amd.com> Date: Mon, 14 Nov 2022 18:32:59 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v3 3/3] ethdev: document special cases of port start and stop Content-Language: en-US To: Dariusz Sosnowski , Aman Singh , Yuying Zhang , Thomas Monjalon , Andrew Rybchenko Cc: dev@dpdk.org References: <20221114181956.1052159-1-dsosnowski@nvidia.com> <20221114181956.1052159-4-dsosnowski@nvidia.com> From: Ferruh Yigit In-Reply-To: <20221114181956.1052159-4-dsosnowski@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0513.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:272::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BN9PR12MB5131:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cff2b34-169c-44c8-55c3-08dac66eab47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qO6ccEk9e2RhP4UXuUKvtoxWMZNCS2Wq0PEBFJtqOKAapex+JJQazpXqskKue5NLu+mkoniuuGKe/VIJjiPeUr1VU4OLuAhXSWxt6n/LeqqXT9MhzqLOR3DOoBu/slszqeKpBiI+EA9/3DLTTbFeANDoXwlkFX+fWk6TLlD1pyTHvuncERYsSdgb780TDmeMN+VUCI/dsBjax3NHAnjg1Ymk/UhQhm32/qNoIiwa09vtqbu2Z2qLH6uS39SIEvncFDa+jrkC0lSR4i08Cvi4ozdcBSfyooX5dp3kbfJhOhPhl3XVYvxepdzzYP8IEd0yf+Sanc5zSYT5Ps4c1yj3QfsOP1DKt4RVzqlgOVC4lBy/tFr9LwAiAPFwoTUvdmLJcAu96MgTkta9jZGdDR2VVk0/eBkxYbdpqJ/nwXGQTgJpDtmsBlvBCIUW7wrMWC1ZCaoBkz+rr0GR/k+1+49bQL6hwr7Ooo5I6TEbkf307YbKHe1JNZ1iV1qrlaIuLAOsGQZMdjnfyceS0J8HCn4sGRslvsYCv0BK9aKgvC+qiP0gH+OhD47Iu2BLyGGdcoSbCB3yhM0MDvjFNCi1oGYyhiKdqJInT7kta1aDGJy38ghFng4aUfVAn2bOjqjJYpMkhi5iwRCCzYZXRrB3XbR10PI7NssNXfAisd1O+9WraHL2mXUfd2edfkQ64zTa2b8ylFxOg22gBV26ktcQbeF9rhtfalaZJtnofby77r9cXA6Ru9eNueVPL1p7NIrp3l/hQzOH8Lpn4IMgu8LEcLmmmX+jiGqkPk942d2WbV9OwWQ= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(451199015)(2906002)(4326008)(6512007)(66946007)(8676002)(66476007)(26005)(316002)(66556008)(53546011)(44832011)(4744005)(186003)(8936002)(41300700001)(6506007)(2616005)(36756003)(38100700002)(31696002)(86362001)(83380400001)(5660300002)(6666004)(478600001)(6486002)(31686004)(110136005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmNBQjZqYzdjMExtNThEczdLbXFReitNbjdZdWozNUlnc3dGdFM4MDV6bEc0?= =?utf-8?B?d2swa1lVWmVncTFOUldKRVBJZVBwL1ZoVmhlWW9vYWtkaG9KM0wza3pPNmVi?= =?utf-8?B?SnU2TzNzdXBUMVJQcStxQTdKVGpEOURuWHFjMGJBWnp6TXJsc0Q0MnlIMkhV?= =?utf-8?B?MU9ud2piNjlwSzA4Q2cyZGZ5bFBNMmpPdWZvMC9ZUGdsQ0hobzF3ZDdtYjdw?= =?utf-8?B?MTlhRjJ1UFNnY2toRUpmUG4wVDMxcDBjaHUrVUpNK1AvOWFOeXMxYWdTUHcz?= =?utf-8?B?WU56Qi9qTWtRcWFxZ1ZPQ0dyTVpQMVVmaW5rbkdUQkUxQ3B5eDRkTzVtY2Iz?= =?utf-8?B?SVBINSsyVCtIUS93NWZwTWhxUjhQRlA4NlVpYWJXeEk0eko0dEhta0tCaWJw?= =?utf-8?B?RjN0UDRpamRxS0dQaEF3RnUwSG9UOHc1UDNyaWh5VUYvZ2V6dFcvYzI1Szlj?= =?utf-8?B?d0ZHRm1CTHdLK0c2dlR2S1VDcEVEZFEzekhZZFBlSXJtam5LcjNHT1hCemYw?= =?utf-8?B?elI1VkFPVUdGYk4yVThlY0xsNzNKbXJrQU5OMTM4TEZVbStpZUVoQVlHWTIx?= =?utf-8?B?MVNOZmJ0THU5czRuTmU0aDlqaUFFdWM2NzByQ2ZpREVWdWUydGFjQklnU09W?= =?utf-8?B?REV3bGhOT1g1YTNSQS8wL0IzZUwxZWczYlB0emxCUTFTbXhERWNrelVJUXM1?= =?utf-8?B?SS9DOC92U3RDU0E0dHpNVHN6RWRVb0prb3JFRlpGQnZrbUFEM1ptdm42SWZr?= =?utf-8?B?TUpHWTlmeDRUOWxPS0xRY2plMDJON1QzUHcxSjNzeE9Ma2plL3FZT21LR2RZ?= =?utf-8?B?ZkZnUVhCOENEZ2xmWHhYOHVjUDNOYWtPaHpMREkzbkROM3RVQktxK1YxU1Jw?= =?utf-8?B?VW5FcXFnMmM5TkdycFdWai92QzVjaFFGZmNhU29BYnYwOEpzL1hoREhpSXVU?= =?utf-8?B?WER0TEJCbGIvZHFsLytaYnp2QzJDQjdNRk5FditKOEVWYTB6dXE4Y01sN21j?= =?utf-8?B?OEVxSTBlTVhFU0o0U3ArY01JVjc0Rm1ObUgzcExZbldvcXppM3g1SU5OM3Zj?= =?utf-8?B?V0ZIb0pNQ3JXN1RYMW5UdzhscW9yRWpjYVA0OGhtNGNFYkhuWG5zaXlZcmlL?= =?utf-8?B?aW9WNWdNYitTcldSWk9uYStFR01qNVZlUFRnMFkwWW0yNFBNcnJueTdJUHlG?= =?utf-8?B?clNuMjhXTTJYT0ZJVzBNOS9hMlJBbTlvek5veHBvaVI2OVlrMWlRMXNsSnBK?= =?utf-8?B?UW1xMWVId3owOUVEVFBPWFcva01HNkpwa1dKMys4T0hMUnBNWm04cUhiRFBK?= =?utf-8?B?VllJQXlRK1FyUmk4MzZ4RVEwWTE1QTlQZUlHS0hSTjR3WHI2QXlVd2FnamZH?= =?utf-8?B?RGY2R1pRK25yYmJrL0NjNVdoZHo5WWovMkpsWDBlTnJZZUp1bXRNdEpqV3d3?= =?utf-8?B?Z2VsajJEYzNvTW93KzhIRm93QWt6Qy92a3pSdEdlVlVzZEt6SjlJcnJaekds?= =?utf-8?B?OVNoNUNKK0N6eTFqUUE4Z3JCOFpHbHpORTlpS3ZReENTNHRFRGFpZFgwWVZS?= =?utf-8?B?VEgxWVRiOGM2SnF2S1pqNU8xNWFwUUc0blBoUUQyK2o2SjYzYXRleHR0SnJm?= =?utf-8?B?NE9SZDZMRC9OTmp0S0hSM0VQeE51MjMyY2gvYkxycDVYNUI2NFRlWUYxa3Vj?= =?utf-8?B?Z2F1UjdLTVhEVzAxR0IxWHpwdFBlTW90SzRMdHlxUi9SM1R5TlZQUVNSWnVF?= =?utf-8?B?QVQwSDEwRldpNzFPWHFSS0RZUXd6Z1FjZTQvbVVKRkdhMkpwSnYzeExxMXAz?= =?utf-8?B?NUxWWG5uOXlJKzlzZnFXUlRSVkFxbnJ5THQ1RGcyQ3o3aGkzNnM3cEFBVi9T?= =?utf-8?B?L3ltZUR0dE1aQ2ZxOGRiQ1krNXNESzNIajZUb2xXY2RYQXQralZMUU1zeU95?= =?utf-8?B?UkJOa0NiOEFGUi8wNHFralNVR3phK2gyajY4N01lN0w0OU9NeE1oR2NkWGZ2?= =?utf-8?B?VnZwbnZGeHk2Qm5TeTZUb3dlZ3VaZjU4alE1OEowN1g4YU5TTXdkbXZUS3RK?= =?utf-8?B?bVdJdXFBT1VrdjgveGhsdWpUS0pJM3VsRzN5M0JkZ0pyMVhqMkdnSTN4SThj?= =?utf-8?Q?Fsp7Vpwi2rPLT3gYWJW11eF4/?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cff2b34-169c-44c8-55c3-08dac66eab47 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2022 18:33:05.0970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WB5JrgjGkDmXA01fntXasiqV28XrFWLLjvjrpMZ56jviyBrNfDL/qI47vX/IfBH6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5131 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/14/2022 6:19 PM, Dariusz Sosnowski wrote: > This patch clarifies the handling of following cases > in the ethdev API docs: > > - If rte_eth_dev_start() returns (-EAGAIN) for some port, > it cannot be started right now and start operation > must be retried. > - If rte_eth_dev_stop() returns (-EBUSY) for some port, > it cannot be stopped in the current state. > > When stopping the port in testpmd fails, > port's state is switched back to STARTED > to allow users to manually retry stopping the port. > > No additional changes in testpmd are required to handle > failures to start the port. > If rte_eth_dev_start() fails, port's state is switched to STOPPED > and users are allowed to retry the operation. > > Signed-off-by: Dariusz Sosnowski Acked-by: Ferruh Yigit