From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1DC6A0C55; Wed, 13 Oct 2021 14:14:56 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4566410DA; Wed, 13 Oct 2021 14:14:56 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id AC09E40E64 for ; Wed, 13 Oct 2021 14:14:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10135"; a="288283573" X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="288283573" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 05:14:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,370,1624345200"; d="scan'208";a="563078012" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 13 Oct 2021 05:14:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 05:14:53 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 05:14:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 05:14:52 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.108) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 05:14:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P1wfkauJW0qNZolzs7QwdFoytkIsmrGuBn02JZsBAKS0ZIlAlYrqJ3mUc5uMVNPsm0v1AbwLErdpG9b2B0qwIJwUtS7RWGwQcyas+d/xtNDT/drgGIfFPcxr1dJ/G1bw1Dr2cQEb0OC8Glk55rAQHHC8+AtvS7G09OTBeGR4xQT8kg1HWi8m5ucsPpaORL0M9UJa9TyP6xLjOwFRJvAWyk5ts/w4vz1qpCFHAIDhytA7cTUR3YEccWR8kF5UNyOv5aibvwAk4JWpK0i5ZiCWBnY8DO7ff5Gev+Jv6Ia1qFiJJO3L4fkK+N5oanxp2DWsE+B1+G2W5bLqG6aTzWCq8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7JPv8to8hi05Z9LB4MvkpNY2d4gXaWyqhJCaRcQKNk=; b=DNdL3Iizg2uht+6Oq2zO9r1sSMZJFJDwb70ySkxcZPKSvSEqWbB/1fVUnS0xBxUu7nK+Fsk7/D3WYKtV5Mp26mRfabVvmA3ZlZC/5ELxXFEwZNJoF7kxXp4bv59NNsdI05a/WA/cAZ58nw636DceM4F/HBIniE+9AA2E/MYpdFhzp85lsUwdeekI6+Thhgn+H8pfQnMopFkjZH0WLWJBlLf4X4WEKW4+QKv9PvbBs2MuWsH0xvA0e/oKkQ71tiWZaVAl6x0RXMl8Ul+/WbE0mB+JDK8FKU/+KJ+qxAdpO8i1EtZmiZ2oHI3NGhFJ0yAuq200qAg+Y0ShVsQZfWAXeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7JPv8to8hi05Z9LB4MvkpNY2d4gXaWyqhJCaRcQKNk=; b=gLU1DhhGsrZtnLuG7/houKnDjiZ+G+N+ifhwiIpjUtc9bdCUKhKRoVA0IVgog9qiEdpZljR15EjQXGmHdszFKB9Uo42F0LUHOdmGdr7vfQO1CPOU0QFiiDHSZ7yMbeN66xWmwjtHxkpm2/0ltD0XT0pMgzjNY+RRks9fu63ETc8= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5157.namprd11.prod.outlook.com (2603:10b6:510:3d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.19; Wed, 13 Oct 2021 12:14:50 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 12:14:50 +0000 Message-ID: <5c9bb399-630a-2e17-4a7a-97076b775a7b@intel.com> Date: Wed, 13 Oct 2021 13:14:43 +0100 Content-Language: en-US To: Gregory Etelson , CC: , , , , Bernard Iremonger , "Ray Kinsella" References: <20210527152858.13312-1-getelson@nvidia.com> <20211012122934.23659-1-getelson@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211012122934.23659-1-getelson@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR06CA0025.eurprd06.prod.outlook.com (2603:10a6:10:100::38) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR06CA0025.eurprd06.prod.outlook.com (2603:10a6:10:100::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.14 via Frontend Transport; Wed, 13 Oct 2021 12:14:48 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb2765df-b74b-4ec0-0da3-08d98e430e28 X-MS-TrafficTypeDiagnostic: PH0PR11MB5157: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sG6DQFFEfKzbmhVG2U8eGE6Br0PH0+/oTOv6ZfUBVuk1jy2wUlADBv7GaXdya0oMQiZmqWneRC1p8nuuHk/YK9GJXJUDEv/xubylpiVsMfxhuU3Xr8KJIAebM+mlOmpKaufhuMg+ti2oB7Zc9vEqRhxtPIJ7rOdiTJQSO3xtmGOiHnRQrHjzZEt32kfLkWLSrwdQig9jGbs/DIiKP+1dgDrQilUnc1YbHUU8V79dSOLWHjF0y+UQjHtifOfVLHTHRQMnk6wef16s4VzDbbuLI9LL8/85iKeuQaY0dEwilTt2Lhl+riyLRI8udgQjAArXDfgJF74etBN8RjBV1CiHDUZPqkIIo7qpNg6XVCL38J8FPtTJ22rfH+08YABucuyzNB06I5SYIsAa0i7pQg7dpv7KZvEB2AiLc914rjDDD707YCq7dWGEkSxSrgcYtNZtZs3vW3ciZ6c6JfcrZBFOain2IQxUOnRxFw/SGpgrZ42/OLQ3rCBa97tvvmNXnXp5kiQLyqiYyRVRDOv0HYqe0+IAfbue8Y5Mx56QMF/ulN043okiO34EeMe2KEyTFrDVkR00TvBoY7v38m2RjyJJwwUvHpHV/DBTWFmuEbb5ioyA7YKuv756p6Pz4hz602L3yQ8WH0nUJn+Y184N7TBq7eWX7Uee6DhSguuDzo+KQgs4pDiA/4nHH6bGe/MsqN4mhkFVm2C5gXWtymDipRKfWg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(186003)(6666004)(956004)(31696002)(16576012)(36756003)(2616005)(53546011)(5660300002)(2906002)(66556008)(508600001)(82960400001)(66946007)(26005)(54906003)(38100700002)(83380400001)(8676002)(316002)(4326008)(86362001)(31686004)(44832011)(6486002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YWZmelZOQituU0xXZHhLUnZwVnJmaENWclNheGRvbzFIbjNJaFJyZHRPRldo?= =?utf-8?B?QmV2S3d1eHZqbXZnUEg4dCtxNlZDZUFKRC9WeFkranJLK2dkYy9wOWgwekZu?= =?utf-8?B?REdDOUI0UE0za3U5aUZ1enR3TFBwSElIVWMxalA0WGpBMzhZZlg3NG44SEly?= =?utf-8?B?NnVMVG04cHREM0tTL29ZMnVXdFVCT0RKZG1DYklXYk9Db1lVUkNGeHJPTnpL?= =?utf-8?B?amt1eUhobFFKZFI1dm5SS0JPenJmcEtlQllSUFVYeThGd3dWM1pMRjUzbWty?= =?utf-8?B?K0ttdU1YWDhnV0ZEVHZVV3BTcWZVbVJQZzdZK0xGQldqcFFNbGN1QnQ0M2lO?= =?utf-8?B?RlpTZkcxRTJ2bjBJNlpvK3A0RVNtS1pvSHFrR3VVb3hPQWlQcG5iQnR6bldE?= =?utf-8?B?MUNGU0FUb2Zmaklwc00rS0duMEFWU0oxMTVPcHMrK3c3SnRRV1A1LzZ4blBx?= =?utf-8?B?czB0cVJ6NnFWMHZzdzVaSElSWG9qVzdMYy9IeThnTW00Y25Xc3phZVRCMm0w?= =?utf-8?B?RDh5N0M2MjA3TC8rNHhzTlIxNnk4WU1qV1BiV3JoUE94d1pxSndGT2V3Q0ZR?= =?utf-8?B?aFNhN2dqK0VzK0pSZ3hFZlZvcFNDeEc4UFRFdWVVTDNSN0hrczBWaktUbW9a?= =?utf-8?B?T2hObHh1SkFmZWJDakVBb21PbXpQcGdSa2I3Tkt4a0NLQVlYdXBVOFQzMjFC?= =?utf-8?B?citKQy8zUjhmWUgwUER3VGptSjdwMFRCUE4vZUU0dWJnN3pOc2RNZEJBQ0t1?= =?utf-8?B?YWI4RW45MzNHVU0wcVlvZWk2dWV4QjBPd1Mvc0FmMXZJb0RrN3dxYXBJN0dr?= =?utf-8?B?OHZjUzdLVlUyS2JmNlJoQ3BPaUx5WUd0QVJWcXR0Q0JDOTFTQlBaemwyd0hs?= =?utf-8?B?Q09Wb05sQi9ZYmxoTnNjTjVZalpMZkdmaUExYXVTQzcvZFg5ZUtXQmpJM0ox?= =?utf-8?B?RVlqWThMMGk1UHRjb0tsamcyaXBhNDRDcUZubzg1bDZjRitzc1hoOFc5UVdN?= =?utf-8?B?TnpPSHo3OTR2UkhFTlJnK0YrYVNqQUZFdk9ySGYzOHBRamsyaTdEZ1daQWZH?= =?utf-8?B?K3FibkgrdDhoOHBmV0h6NEQ4MGt1dEgwYlRsMDhJWFBoLzg2ZHlidExRaE53?= =?utf-8?B?b2lsREtnazExUVVHUGE5YXRPQXBraE9xQ2ZoQlp6b1FaUisxQXpMMTBvbVlt?= =?utf-8?B?Z3hXU0h5aHhBUmR1azl3MGVnaG9EbUROWVJGRUlBNTkrSnBqU0Q1aGp6MVox?= =?utf-8?B?UHdlcWh1WWhrS1dGTVB6RkExdXphc1BtYjA0LzFmdVhMcENYSkZVa3VVSEcx?= =?utf-8?B?dzNSajdiclBkTThwS2JkT2t1bWMwUXR5WCt5VE1VT042QnlkRUdWemN1M3BD?= =?utf-8?B?cURWVkxISHlRNjRmRXBoWnB4R1FncGcxaWlXaERHejRiTDkrTm5vMUhvWGFa?= =?utf-8?B?QVYrSlR0ajdOSi9wY0pnQXdwZHlRdU8rMFNLQ001Z2IzQ0JPbDZMdWRlQS91?= =?utf-8?B?Z3dWZmhjTXFjTVdMWkttajJvS1ZaMzRQbWJwbUl2NjE5NThjZUxTZWtDSlJV?= =?utf-8?B?VTZ4UFBQUU1WaDFkSWhWTi9jMDcrSWgrazJvaTkwdGg4T0RmVzloVlZKKzNs?= =?utf-8?B?c0w0VEE4VE15RXl5L3p6a2xsVXFhMTd3Z3lURXk1UHVSVUVrRExwY1hlaE8x?= =?utf-8?B?MGtBcUh0YlpES2dOVjlzR0ZWZnByZTYrTWU2VWVkbTJTZ2hvTHhWSlNkM1VO?= =?utf-8?Q?2xtjnFaZDxlyIYz7mnfkiIRgBncFo5SWN715ZIN?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb2765df-b74b-4ec0-0da3-08d98e430e28 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 12:14:50.5445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ur5Vc3mwtxPgrmPbmLqhhbKeo0fuAlxESleGv41JIkstFsVaOhoyZy6J2efWRB+MtkSO+RVjzKEtrw9iGl9wFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5157 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/2021 1:29 PM, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > create simplified code to match on the IHL value in a flow rule. > The original `version_ihl' structure member is kept for backward > compatibility. > The patch implements one of 2 announced changes to the > IPv4 header. > IPv4 header encodes fragment information into 16 bits field. > 3 bits hold flags and remaining 13 bits are for fragment offset. > 13 bits bit-field cannot be defined both for big and little endian > systems. > > Signed-off-by: Gregory Etelson > > Acked-by: Olivier Matz > <...> > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -167,12 +167,6 @@ Deprecation Notices > * net: ``s_addr`` and ``d_addr`` fields of ``rte_ether_hdr`` structure > will be renamed in DPDK 21.11 to avoid conflict with Windows Sockets headers. > > -* net: The structure ``rte_ipv4_hdr`` will have two unions. > - The first union is for existing ``version_ihl`` byte > - and new bitfield for version and IHL. > - The second union is for existing ``fragment_offset`` > - and new bitfield for fragment flags and offset. > - The deprecation notice for `fragment_offset` seems not implemented but removed. What do you think to remove the relevant part that is implemented in this patch, remove the residue in another patch explaining why it is not implemented?