From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 234EBA00BE; Wed, 29 Apr 2020 10:17:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DDC711D956; Wed, 29 Apr 2020 10:17:09 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 243001D940 for ; Wed, 29 Apr 2020 10:17:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588148227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=02h7F4wVHsspPO42/cWmjvq+8Jha83eY3x//xD6k180=; b=RE1EzsXG74vKAJAedDCi4xKH8vq+FEdAn+Q8JrlNn1ELgNVAthDqGSbqH23XAWOyFvr+Zj 72fZxKCQCk5lUETXGRnTE5/A4OumXW/tSgQH+8PPhL+TdEPQ7LZ++dok1LhJtsEnv7UQK/ PRxtVuuTjgsyzbTTnkmB2zENM18mThE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-303-TtKpYTfoM4OV1XBrogSPyQ-1; Wed, 29 Apr 2020 04:17:05 -0400 X-MC-Unique: TtKpYTfoM4OV1XBrogSPyQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 987FF800C78; Wed, 29 Apr 2020 08:17:04 +0000 (UTC) Received: from [10.36.110.63] (unknown [10.36.110.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26C545D776; Wed, 29 Apr 2020 08:17:02 +0000 (UTC) To: Marvin Liu , xiaolong.ye@intel.com, zhihong.wang@intel.com Cc: dev@dpdk.org References: <20200313174230.74661-1-yong.liu@intel.com> <20200429072822.102745-1-yong.liu@intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <5c9fd288-27fe-41fa-bec7-bb0d2d2476a1@redhat.com> Date: Wed, 29 Apr 2020 10:17:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200429072822.102745-1-yong.liu@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v12 0/9] add packed ring vectorized path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/29/20 9:28 AM, Marvin Liu wrote: > This patch set introduced vectorized path for packed ring. > > The size of packed ring descriptor is 16Bytes. Four batched descriptors > are just placed into one cacheline. AVX512 instructions can well handle > this kind of data. Packed ring TX path can fully transformed into > vectorized path. Packed ring Rx path can be vectorized when requirements > met(LRO and mergeable disabled). > > New device parameter "vectorized" will be introduced in this patch set. > This parameter will be workable for both virtio device and virtio user > vdev. It will also unify split and packed ring vectorized path default > setting. Path election logic will check dependencies of vectorized path. > Packed ring vectorized path is dependent on building/running environment > and features like IN_ORDER and VERSION_1 enabled, MRG and LRO disabled. > If vectorized path is not supported, will fallback to normal path. > > v12: > * eliminate weak symbols in data path > * remove desc extra padding which can impact normal path > * fix enqueue address invalid > > v11: > * fix i686 build warnings > * fix typo in doc > > v10: > * reuse packed ring xmit cleanup > > v9: > * replace RTE_LIBRTE_VIRTIO_INC_VECTOR with vectorized devarg > * reorder patch sequence > > v8: > * fix meson build error on ubuntu16.04 and suse15 > > v7: > * default vectorization is disabled > * compilation time check dependency on rte_mbuf structure > * offsets are calcuated when compiling > * remove useless barrier as descs are batched store&load > * vindex of scatter is directly set > * some comments updates > * enable vectorized path in meson build > > v6: > * fix issue when size not power of 2 > > v5: > * remove cpuflags definition as required extensions always come with > AVX512F on x86_64 > * inorder actions should depend on feature bit > * check ring type in rx queue setup > * rewrite some commit logs > * fix some checkpatch warnings > > v4: > * rename 'packed_vec' to 'vectorized', also used in split ring > * add RTE_LIBRTE_VIRTIO_INC_VECTOR config for virtio ethdev > * check required AVX512 extensions cpuflags > * combine split and packed ring datapath selection logic > * remove limitation that size must power of two > * clear 12Bytes virtio_net_hdr > > v3: > * remove virtio_net_hdr array for better performance > * disable 'packed_vec' by default > > v2: > * more function blocks replaced by vector instructions > * clean virtio_net_hdr by vector instruction > * allow header room size change > * add 'packed_vec' option in virtio_user vdev > * fix build not check whether AVX512 enabled > * doc update > > Tested-by: Wang, Yinan > > Marvin Liu (9): > net/virtio: add Rx free threshold setting > net/virtio: inorder should depend on feature bit > net/virtio: add vectorized devarg > net/virtio-user: add vectorized devarg > net/virtio: reuse packed ring functions > net/virtio: add vectorized packed ring Rx path > net/virtio: add vectorized packed ring Tx path > net/virtio: add election for vectorized path > doc: add packed vectorized path > > doc/guides/nics/virtio.rst | 52 +- > drivers/net/virtio/Makefile | 35 ++ > drivers/net/virtio/meson.build | 14 + > drivers/net/virtio/virtio_ethdev.c | 142 ++++- > drivers/net/virtio/virtio_ethdev.h | 6 + > drivers/net/virtio/virtio_pci.h | 3 +- > drivers/net/virtio/virtio_rxtx.c | 351 ++--------- > drivers/net/virtio/virtio_rxtx_packed_avx.c | 607 ++++++++++++++++++++ > drivers/net/virtio/virtio_user_ethdev.c | 32 +- > drivers/net/virtio/virtqueue.c | 7 +- > drivers/net/virtio/virtqueue.h | 304 ++++++++++ > 11 files changed, 1199 insertions(+), 354 deletions(-) > create mode 100644 drivers/net/virtio/virtio_rxtx_packed_avx.c > Applied to dpdk-next-virtio/master, Thanks, Maxime