From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AC6D43B65; Wed, 21 Feb 2024 19:02:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6945F40297; Wed, 21 Feb 2024 19:02:32 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by mails.dpdk.org (Postfix) with ESMTP id 198EB4013F for ; Wed, 21 Feb 2024 19:02:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b8QrxL21qREXE6toxtZZTzYuT11iXT5Q3wOxD9DHj1i2FfoN52e3qaWFlfeNnvu1g1+qo65ieAwZR4xbM9DuExEfeWnbVBcu8SMw8kXI63Ai8A+uXRBzaMNFz6sikHJjiovU4ZpwBTgsM6g6CUO99yMml0pGQGlI142GNxakKnRgin9HKPTOA6S9QOf7m4sAqW4IgnmQri1BiW1ts8ZiJridSIHQRsxYhyR52HCu5x2yw19yl8chLlbWD76XEvupxDBjArR2znMwAilPCZ+vRcCmQiI7fZOpFak1BzKpNch335iorgait6CBv19HWBDjIDMNpXbWQlUtWfOoD9GFNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vsY1RQCXYtI4bTzDZjA8jFQCEomnsQ99G2qUrKZRxwk=; b=Y193pdvUvnl0YhxPiVEKnfJOJvX7wEqPcrjgOeBK0I7ueipytC3aGvUem2o87RcdJYTbaW/eBdzk8QtEEfSbKyILncv74Wx7e5Sen7Aw22aFIipgbTfCNUcWNzRnh+wSU4bH1MqfPpcuAClK9YLblhy/mmow7ZtpmkL6nLn0LYs6oTw3X3/kqxqbYWmtG9Lpcn2H1Uv0SJdj4qSI6U5MRObcSa36w2ybmO+28DaXm/uexjAvCeWk3DbbjlyHXwUI5RFnZtfw4//LDxEvr2gngcHgmY3ErYa0fflxoH8QA5lflcubI2INogsATwEK/nlHN2BcQpnxMhMpLVdhvw+Bqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vsY1RQCXYtI4bTzDZjA8jFQCEomnsQ99G2qUrKZRxwk=; b=KRN5Sxek1FJB8tICxe9bnqZf1CVlFRmLBmZUW0T4wDzwAmVaE7zy5CisE6Ui0TvJbwHK7zLOlv/NE/X3Qsg+4nbMx7j6Fhf2aNMACA8WDhQ6+2vQgAghvOLRM0SFsty0XcheqkSpq3176lzhc9ThnChW2pR/dpDyrkvvbtHBTcs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB5343.namprd12.prod.outlook.com (2603:10b6:5:389::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Wed, 21 Feb 2024 18:02:28 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.018; Wed, 21 Feb 2024 18:02:28 +0000 Message-ID: <5ccd235e-aae7-4ac9-8eef-fa6e0483b1cc@amd.com> Date: Wed, 21 Feb 2024 18:02:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8] app/testpmd : fix packets not getting flushed in heavy-weight mode API Content-Language: en-US From: Ferruh Yigit To: Kumara Parameshwaran , hujiayu.hu@foxmail.com Cc: dev@dpdk.org References: <20240117195228.423261-1-kumaraparamesh92@gmail.com> <20240216034750.47539-1-kumaraparamesh92@gmail.com> <8c3d602b-b83b-4cb6-af04-f51576d72284@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <8c3d602b-b83b-4cb6-af04-f51576d72284@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P123CA0010.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB5343:EE_ X-MS-Office365-Filtering-Correlation-Id: 5057ba9b-e8f4-46c0-76b4-08dc330743f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rX+zzubi+L7QotJZfOMx/5lPkb9JDB/5VGmNSgHK0ljX3YCQfLxzsT+WixKCyPH1IHfPaX5uWaogscKJkJqApevYtUGzQH92W7KhhOsYQCBXU/rg5b3uELpSPFnYU9avBr9GckFPfu/PpW/ycivvLPYhaU/HDHaAXTz2lpoIhnpHeIc6qoud/FNMrnLXUXBemwvvdTryrJVXyUVdtZOGY/sNayplrJqsJ+MQLb4RbQGbf5K9UB/kz2lLoL4Vmn+oL5JkgFtqSRoozRiKnvtE/5OEd1xu9Q/VoeS588AlfT6asGimfabvpg5kB7a5Ms5uem8c6CdMVqge4Qkw4s8j8qmvuAfinEYAwnSp7BYCEbjPXfWMYL4RFGRlMD0Be6q7HpAT5EYFLMnIe//T1flWRGms5ZQfloLI3zyWrpG/V4y7SoQ9DN4hAX1dSxXXuPUV3bfrnTpl2AOJ1jL6oatYfb5a6Wm6yqQjwIOdoBzMAaZi9dj9QxX/LwSe11BBPa8LEdY/l24E7qvsasHro08nbqQOy7tJBCOWVK1e0ZMQ5eR8aq9/GEC+NASeUPFKCFpU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(230273577357003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUd6T2xnRWdzV3MrUUdMQ2xCNTVDU2llaFVSdGRMd3JNWWdZaDIzL1BUL2FB?= =?utf-8?B?MUNMbk9WMC9hK3RNYzJwMUl5dHMzaXJZRlpNZEdaZUE5MXFpaFhVcGtNbVk3?= =?utf-8?B?Qnp3bS9aeGRmcktwaklVNjhrTWtBS3ZleWJqSlhNKzBUV3NVaW1RZllIbzJG?= =?utf-8?B?a3VsT3ZDM2NRQXNTU0hsb01RL1JXM0pnUjROWHEvZzRmd1NST1I0UGVkM3gz?= =?utf-8?B?cEpRdG9tTVB5eFRWZ0pBaHhEeStWRW56Uk4xUUFJWnE0V3N0U2FDL1FVZVlG?= =?utf-8?B?Y1hyZitEdFBhS0JXbWhSWVRaNkFRZklyYklLTVZzY1RiYlZ3ODdMUCs5bUxG?= =?utf-8?B?NjY1RXVpbVVkQTlTOEU0bHBkZ0QzSVVmbzdSSVIvNEVYVndNUnNXK1JqV3lI?= =?utf-8?B?RThONmZkZUE2OHExT1VJcGROSHRkS21Bc295aHVILzlNcmhiMlhjRUhCSDRT?= =?utf-8?B?czk4cFJHYmQ2Nm1BVFdtMzFjRmF5WkRQZkVwUU5ZdHVUZHZEQTF0UEFkb2tW?= =?utf-8?B?KzVlemVlTzlLM3ZhQTQ3L1AyMkorNFhSalpHRUEwL3NJaGVYQmptU2hzT0s0?= =?utf-8?B?VTRJZnIwQWgxMHNmYmJpSFY2QUNkd2U3b28xOFZIczV6NUsvVm1mMm5yRjh4?= =?utf-8?B?RHJDdmVNRlNUekdFTnhHcHpLNG9hamo2RGk5UHFsYW96TGhnbCtiL0FkcHc0?= =?utf-8?B?VjNvM3A1amQ0MVRTK1dpYS9QV3ZKS1NUZi96b0ZhV1JGTnJ4akpJaHZZOXZw?= =?utf-8?B?NTlsV1NRcVNhMVJGUkQyV01SWVhLTWdxY3JRTFhBMEkwUTIyQXJGd05xaWcw?= =?utf-8?B?VEYvcVdxMUY1SDh1MlRWNEkwZTczYmZFTXVveTVRTXJtOE84bTZVY2QxUEhD?= =?utf-8?B?L0Vpd01EdzlzSktZS3lXTXltQkNaWW9FUXAyemkwNE8xR0dCUG9nQzVzSTF6?= =?utf-8?B?NFJjc2RVc0J5a2U2MjJJRWVJRW96cWg4K1JoUDVEOEYyQjEzbVpNZnRhTDNV?= =?utf-8?B?NEgyQ0xzaTlIdDN4RmVGYzFxM2pEQ2tDMTVPeXE5a3NIeGc1MFdLY3cwWE1m?= =?utf-8?B?OUNuTzc1Y0lZRmZTempQMjIvbmVrSEdaMDRCbEdNRHo1NlRkR2tTUFFSWHUx?= =?utf-8?B?bHBuSGZVaEh2a0I1RVI2bC9taWNLbktvcCs5bmtqaG1rZzQrZWF5ampsb0hu?= =?utf-8?B?WU8zTjdZcW1KdmhoM3N0S1l2am03ZEhxdGFGWkdyaDFjb21adVhnQlBNTUZM?= =?utf-8?B?dEs5SXBDT2RLaHY5WTRZNUJYN3oreFJRNzhwMzl1bG9OTU5NbUFVU2hhMEo5?= =?utf-8?B?OXl5ZjJJOE5seXdOeXNKeFc0Tnd0clFWZkduRFR4UnNEQllUWFZrS2ZoQmVl?= =?utf-8?B?K3lTMEVicTZUV0FzMG5oYzdNb2pWRFFyWmdENWI1eCtqMjBKa3RnM3Z5eEVs?= =?utf-8?B?c0hIL1lSYm5lMVZVQ1VVM3MyVWdiL0QvYWpMRzJRK0sxbnJsZVBGdHdIK3p3?= =?utf-8?B?OTJDblRnK3pEcFo0RzNmZ1E4OHBha2ZGMThoRHdTOC9EWGUwTjlpRnIrS05v?= =?utf-8?B?bURJOXhIekE3U3QxT2dZQllFaFNPcnFYVTNRY2xJNEVvZFc1ZHFyT2M3MTlH?= =?utf-8?B?WXZKNDBuVC9RbXcxRXN1eE5vMFNjczlJN29LSUNIaGxuK1ExM1lIMVVmU1NK?= =?utf-8?B?VHFQTVIxbm9meU9DUDBqRW9Na3FyL0N5cnhQQ2l3MEtSS0VIcEx6SUZxemVV?= =?utf-8?B?bnE5OWhrVWNGTEMzMnRmejdyMGRnclFab1E4OGc4L0kya2FwdE12dFYrclhZ?= =?utf-8?B?THdzb0tEV0hHbUpIZlFWK3FiUnlnT3l6c1ZuenFHV0dGUTZOSERCN0JRNEhx?= =?utf-8?B?WVpIYzB2YVBycTczU3JDb3FZVXI4NnErcDhhZ1NlSDhxemRWVFlnNXJCdUph?= =?utf-8?B?Nm1wL3ZETUkvbktPdnVxV1BqRDg4STlPZkQxVzFQUjFRWDdmOEZwbWVvVGsw?= =?utf-8?B?T0MxRE5mNVBsc3BnTGliRmpUcmUrUWRtdlF0QVlsZTIrcjQ5b01DSS9uVEEv?= =?utf-8?B?L0dZcVdEMGswblFFSzdVMXR3VWdrOWpQSFRFMTkzN3FFbjFXWGszbGVub1d4?= =?utf-8?Q?02U64CTjDPvB2LXtcj+Xovm0X?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5057ba9b-e8f4-46c0-76b4-08dc330743f7 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 18:02:28.0474 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xidIIsauN1+6nVdiY0k2ZfMQPYKTgLNlszYbaQWRXSR18K9juNB4BnsyFbWjhYdQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5343 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2024 1:56 PM, Ferruh Yigit wrote: > On 2/16/2024 3:47 AM, Kumara Parameshwaran wrote: >> In heavy-weight mode GRO which is based on timer, the GRO packets >> will not be flushed in spite of timer expiry if there is no packet >> in the current poll. If timer mode GRO is enabled the >> rte_gro_timeout_flush API should be invoked. >> >> Fixes: b7091f1dcfbc ("app/testpmd: enable the heavyweight mode TCP/IPv4 GRO") >> Cc: hujiayu.hu@foxmail.com >> >> Signed-off-by: Kumara Parameshwaran >> --- >> v1: >> Changes to make sure that the GRO flush API is invoked if there are no packets in >> current poll and timer expiry. >> >> v2: >> Fix code organisation issue >> >> v3: >> Fix warnings >> >> v4: >> Fix error and warnings >> >> v5: >> Fix compilation issue when GRO is not defined >> >> v6: >> Address review comments >> >> v7: >> Address review comments >> >> v8: >> Fix spell check warnings >> >> app/test-pmd/csumonly.c | 22 ++++++++++++++++++---- >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c >> index c103e54111..a922160f6d 100644 >> --- a/app/test-pmd/csumonly.c >> +++ b/app/test-pmd/csumonly.c >> @@ -863,16 +863,29 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) >> >> /* receive a burst of packet */ >> nb_rx = common_fwd_stream_receive(fs, pkts_burst, nb_pkt_per_burst); >> - if (unlikely(nb_rx == 0)) >> + if (unlikely(nb_rx == 0)) { >> +#ifndef RTE_LIB_GRO >> return false; >> +#else >> + gro_enable = gro_ports[fs->rx_port].enable; >> + /* >> + * Make sure that in case of Heavyweight mode GRO the packets in >> + * GRO cache should be flushed as the timer could have expired. >> + * >> + * The order of conditions should be the same as gro_ctx is valid >> + * only when gro_flush_cycles is not the GRO_DEFAULT_FLUSH_CYCLES which >> + * indicates light weight mode GRO >> + */ >> > > Updated comment as below to make it terse, what do you think: > /* > * Check if packets need to be flushed in the GRO context > * due to a timeout. > * > * Continue only in GRO heavyweight mode and if there are > * packets in the GRO context. > */ > > >> + if (!gro_enable || (gro_flush_cycles == GRO_DEFAULT_FLUSH_CYCLES) || >> + (rte_gro_get_pkt_count(current_fwd_lcore()->gro_ctx) == 0)) >> + return false; >> +#endif >> + } >> > > Another issue but also related to your patch, if there is no packet to > Tx after GRO block, should we add another zero packet check: > if (unlikely(nb_rx == 0)) > return false; > > To prevent executing GSO and Tx path code with zero packet, do you think > does this make sense? > > Patch looks good to me, with above comment update, but I am worried about side impacts of this patch that we might be missing, that is why I would like it to be in -rc1, so that it can be tested better. Hence, Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. (Updated comment as suggested above while merging.) Lets continue to discuss return on "nb_rx == 0" case after GRO block, incremental to this patch.