From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)"
<jgrajcia@cisco.com>,
"Yigit, Ferruh" <ferruh.yigit@linux.intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Konstantin Ananyev <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name
Date: Mon, 7 Oct 2019 16:21:32 +0100 [thread overview]
Message-ID: <5cd44dc0-512c-28f1-b0d8-3336220ff73c@intel.com> (raw)
In-Reply-To: <75c2d0a4d0d140bab4c8caca08c7a1da@XCH-ALN-004.cisco.com>
On 10/7/2019 10:01 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at
Cisco) wrote:
>
> Hi Ferruh,
>
>> Hi Jakub,
>>
>> While testing your zero-copy patch [1], I stuck to a bind() error [2].
>> When provided a socket length bigger than "sizeof(struct sockaddr)", bind()
>> fails. I am testing this on a Fedora system.
>> I wonder if there is a check in glibc related to the length.
>
> Zero-copy patch does not contain this fix, in fact, I can't find this patch in the commit log.
> It was supposed to be applied on 2019-09-13.
> http://git.dpdk.org/next/dpdk-next-net/log/?ofs=400
> Was there any problem with apply? Maybe because the patch is RFC?
No zero-copy patch doesn't contain it. It is already in the repo. I hit the
issue while testing zero-copy, other than that there is no relation to zero-copy
feature J
The commit is in next-net tree, it is not released yet:
f018cfa797eb ("net/memif: allow for full key size in socket name")
Briefly, I am having issues with that commit, bind() fails, but it has your
Tested-by tag. Can you please confirm it again?
>
>>
>> What was your test platform for the change?
>
> Ubuntu 18.04
So you are on Linux as well, I wonder what is the difference.
>
>>
>>
>>
>> [1]
>> https://patches.dpdk.org/patch/57817/
>>
>> [2]
>> memif_socket_create(): NULL: Failed to setup socket /run/memif.sock: Invalid
>> argument
prev parent reply other threads:[~2019-10-07 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:06 [dpdk-dev] [RFC] " Stephen Hemminger
2019-07-16 17:18 ` [dpdk-dev] [RFC v2] " Stephen Hemminger
2019-07-16 17:20 ` [dpdk-dev] [RFC v3] " Stephen Hemminger
2019-08-30 7:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-09-13 18:47 ` Ferruh Yigit
2019-10-04 12:41 ` Yigit, Ferruh
2019-10-07 9:01 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-07 15:21 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd44dc0-512c-28f1-b0d8-3336220ff73c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@linux.intel.com \
--cc=jgrajcia@cisco.com \
--cc=konstantin.ananyev@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).