From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E09243BC7; Fri, 8 Mar 2024 12:18:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 410DE40298; Fri, 8 Mar 2024 12:18:04 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062.outbound.protection.outlook.com [40.107.93.62]) by mails.dpdk.org (Postfix) with ESMTP id 3F51140291 for ; Fri, 8 Mar 2024 12:18:03 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q6FZfMx4UNm8cKM7tCLv2R2y5iXmqZQ0MUbJ9f036X3WyWXoAt75PQuW2w/CF8kmvP9mDxZJJbESq0uKvSfvmKPyRfI5ALDl+0gbBcCKqw5lODv15rvoZVo6mz92D7y7af50IuG7MpbS3K2HsZqeQzWMVSAqbGuao6IiD0hy0ZcooXD3wkuRz7RpEmSKmi4USLeSBxUwPCm//0zcGfSGuobQd8VU7sA5cQwvYzrZt2J5UQEvzUUmo4IJMUF49u+uu+Sro8L7EasKmCRDNGwQPg9MgJDKpExF+xMlUOeETOrQMd0ofEuBH+4kQq7yfWDsxN/AENdPKd+DcVBeeBushw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gfF6+cndXtx0QC7PjKPlV0P6SHbC11x+YqCo1J2vRBg=; b=dsTZSn2Qjfpcy2HIjPpw6a/q4NuTXqBjvzC4OFlg7+eV8wtqdmV4tn66RYyi3u0kotqVsK99rZbuwUOyEsSeD72Yj4HsJ0v919FLMGOb+gz1BAOFpdRt1ErgrR3FLDohwiPay1RNQkFSbUzny4ymvrSuF5/iEHUHhcA/9xJZXkAa+IMMtW8MGncsq1cs+COvrlHvXSZeGPkuIvZmJwT8MtsbLKQVgIJ2jt+wtR1itdtXc5EfOkIfrO/PqzmNP/ENJmzOumJovStN7p97FzqdQFg2GbIb5kNpUz3IoBmLVmS2oS2DoKrQl3qOTcpt2DY3EjeWyaXhI8s8+4olzQEUew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gfF6+cndXtx0QC7PjKPlV0P6SHbC11x+YqCo1J2vRBg=; b=Rahiktz1s0/aN3EZc/rB5L0VG/i2+tFJSCdgblxn6ue3N5mJxRvZiZo5klxg5UmN+MX/NWuXHWx5q7rO/falIM4H4PrjaMqF3iLkaMql2VLB1nJfWA4gC8hPKEy/gWkF9K1vOjJRfVguvC7dQAIaHcihode+Rc2iQ3uEe3iqXMs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB7552.namprd12.prod.outlook.com (2603:10b6:8:10c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Fri, 8 Mar 2024 11:18:01 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.028; Fri, 8 Mar 2024 11:18:01 +0000 Message-ID: <5cde2436-7105-40fa-b322-92411bf60066@amd.com> Date: Fri, 8 Mar 2024 11:17:57 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 26/33] net/ena: cosmetic changes Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org References: <20240306122445.4350-1-shaibran@amazon.com> <20240306122445.4350-27-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240306122445.4350-27-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0430.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::34) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB7552:EE_ X-MS-Office365-Filtering-Correlation-Id: 3eaa4f85-d63c-4826-2771-08dc3f616aa6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u9PxznuZ5jPk0FTaGTN3yH82uL3bmYsX39f4M5WWxjmO4rUc7MHzSQagI8kLk54S+cWaWZ2AxCafezhPUUFcMnHZQ60RQcbKdbqY4sjIA/o7MPcInxt4n6m04xJDSOH6tzvUL70YsPR7UWwU/lsDSOQMWC4goXkplgXUZ/OPcaSYktQzxV/hjMm7O6JM834RKngX12ZzEFo1837lhjn3Hx9jxmEbIVfj60ju1rYTWUAyGMP3X1m5eKldtdKNxbQdYzTSinyc7nFbcrfGyhTZDcOglDZauE7NJTI3vIFRwL8hcIPqb28ahBBRi82ULNGQpNaBYek5YaAJD4nDNlN04QmvjFxEGmCd2M2fJql9O/Isgp3r/AMYCY2poQNozTK4gpKxS7HSbbbS7aH+WyUEB8Lt3oZqMKBSzukokEJa1dGBJenM/W6WnMOaIvd04S2fEW1+caOTZzxPltXZGVmu9A503ywuljVfrdpWX8G6vwR6UiKCUYkCxtoKVff/QhK4wbKv7lPnD8DpN9KvKYu3kgHmQwiIl67Eev/hIt6sfErQUTWXnmNE4O1Chvq6+CGPlu06wIMoQY2ziE7fz9C9qnMFTeWl7JrjVhDK8a9KaBJvRcRqYSy866/6oyYvJXrzf0DxQpZ4x7BFzTcap/3yKSZTdMx3uc6p0ehZJOKZEMY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1VQb0o4TXUyRWJCV3R3Wi90TE9GZy9RbjJYOU53b2ZyczVkbXllclB2Zjcr?= =?utf-8?B?OWs4VjZGSkkzbklIYitleDNFREw4Rkxkdm9DeklSZC93SXBmN01tTDIxbWlV?= =?utf-8?B?R2g5S1JTR1NlaG1IY1dtWDFPVkxVUG9yYk83VGNONHZXU3dpT0JRUzYrYll3?= =?utf-8?B?cUhFOUNmbFRhbk52OWVTR2ZWUUJ6Q3Vnb3M1UGtiMWdsMEJ2dTlvNnRzUTg4?= =?utf-8?B?blFKUFdGTzVNbHNBNFJMTkJwWVV3eU16cXN5aEdZU2RkNGpDNXNrVmNWOG1j?= =?utf-8?B?d29NQ0hCQmVXRE1zYnQ2N0JTamlwVXBWSmJMNzdNU0RuTHJGRjl0bGlCMFU2?= =?utf-8?B?YVVnVTV3eUgrYklDMHI0RUlwUmlBTUM1Vkc3R0VXNHNOZ2hMKzIzcmFJaUxv?= =?utf-8?B?OVE1am9zWkVZZjRlczNKNWh1ZHB0ZzBLdFJHRXRTL3NKcDJCVmVvMnd2d1Vp?= =?utf-8?B?NE5ZUzVuc01qWWFRNVN6dGpNRjc4ZUN0VUVINDBKYWdqM1IwcEdycWxlU3ZV?= =?utf-8?B?MUJqVkdBR2lqZEkwSUdSNFBPaG40OTEwMytRcWlCZkwwaUFjZVJDYXpsV3Bn?= =?utf-8?B?QXpOclpOVFBTZ28rR3A2am55ZG03ZnR5bjRTUjNtVUVMa280aHBEMlE0aytj?= =?utf-8?B?MVdYdVpWNC9BVFM2UUZIMXNDb2psZnA5Ly9uNVpOVmVFR1pKV0dtcGlXR1BS?= =?utf-8?B?ei9WTDlWdXJuUE5rSzJzQzJONTVuamZ4NEM4a2Z0VzZWME81Yk1BeHY1Wk1w?= =?utf-8?B?b0ZhMG9mK3BUYnJIMVQyT0piWnFCVEZhYmZMaTE0bkRUWWhuRWY3dVpwTmIw?= =?utf-8?B?elJ4L0g3VTJJUUNIZ0RGV2hCekxtTFppa0RtTTEza1JGOFNpbXF2Nm5MaUhZ?= =?utf-8?B?aWV2S1N1eVVNRG9MRDJhcWw5K2xWN0V6WVFMRDMxd0xpeSt1YnhaSFNZRUJD?= =?utf-8?B?YzhOeDJpTzlENXorcCtKOGVXZmlCOEZ1YUxoRnFzWkpvNWxxdlNoS2trZHBW?= =?utf-8?B?R3lPczlZdkh2cXh6bUhQNDlGOTd0RjZrZzVJVk9hQW01RkFHb05KY0lmWVVT?= =?utf-8?B?Q1JBT3pMaXRyT3U4Zjg1NExSYlRhd0VHMXVYVjU3TVdUWjVITFJMaEtFaUdh?= =?utf-8?B?dWo5STNVWjdSNGpFQW51QXpjekxlYzZ0cUpxemE3TkZGdW1FaDIzQ0tYTGRJ?= =?utf-8?B?b0MwUWVRZGp2NzVBc0lFZnljMTJRZlNaZFRHWDZGQ2w2NnI1QndrM0hEZS9p?= =?utf-8?B?Z0tPK05wRFV3cVh2SDFDeXBsNjc5OVVRQ1R3c2dKVFZNSlA2d3F3bWNjUWNY?= =?utf-8?B?Mm1PUWw3QjFpZjVtSEU4YStyVUo3a21XTVAwaWxlSzZrZTJ0VTMzakZCYkd6?= =?utf-8?B?Z2pmVzc3OWFva2VaU2JNdG0wNXh4dEFEeHV3MlJnTXh4dG5Eb2V5clVWQzVL?= =?utf-8?B?SzYzSE9wd21kNnZvcnBrSWozVnlYM21qZE93eThraFpNNDdENkVNeFRnRzRr?= =?utf-8?B?MzBkUTRPR2hpRVJRbXpvR0xNZVI1RGVFelNZMnR2bk13a2pmWGRyYndmeFNE?= =?utf-8?B?eld6OWcvd1oxVWx2U1FDc3c0L0lpUXlzeEdYZGJ0UVcyMFJ3Nmd0bDNGSVcv?= =?utf-8?B?czVFZzU2WVRSN25aV1Y3MW5hUEF1K05kS1QxcnBrQnZvbjk4Q1hsRXp6Znky?= =?utf-8?B?eUtBanlteEJ4MVFjaXhjeDQ2dHdsVzFpSHkwQXBsYWdmSU1NZ1RWNGlqTjZJ?= =?utf-8?B?cVlMUTNmK2FkYnpob0lDalF4VHNEZUJldVpPOXNLOUcva1Ard2RZa2p5U2Nu?= =?utf-8?B?K2gyY2ZlWDJ2RnRJbG52a052Y2hpSXgzb0NjZ1RjTGxidkQyZXhMcmV1aGRC?= =?utf-8?B?QjQ5M3YvdW9JR01LQ3llTzYzbFc5WjhvRSs3YUpxRGk4ZXpodys0VUh5OGFP?= =?utf-8?B?Sjg3dWtHYzlpbFFMY3FJRi9EWmcyUEVlWVZqN0JjYjlqcG9aWGM1YUJvZnRK?= =?utf-8?B?bTUzRE1TSE9vVXBoRUt2c2tlT01EOGJGYjd4cmRWMUlOald6bXBtbFp2MTNj?= =?utf-8?B?NmNuZkhDMDhWQ0ZYdWgzL2FzaS9KU09Nd0V4dUFyWDVTT2N4Z2dPemtlaXdE?= =?utf-8?Q?bQqr1Gcnpm/EQWsfUr3egwRdr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eaa4f85-d63c-4826-2771-08dc3f616aa6 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 11:18:01.4855 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qVida/V9PM8NkCwXzBmCmntGXijr+ch4MxgLsIXp1aTQNx/+CSkcYoge6GRjm/jO X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7552 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/6/2024 12:24 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > This patch makes several changes to improve > the style and readability of the code. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > --- > drivers/net/ena/hal/ena_com.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c > index b98540ba63..2db21e7895 100644 > --- a/drivers/net/ena/hal/ena_com.c > +++ b/drivers/net/ena/hal/ena_com.c > @@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp) > > /* PHC is in active state, update statistics according to req_id and error_flags */ > if ((READ_ONCE16(read_resp->req_id) != phc->req_id) || > - (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) { > + (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) > /* Device didn't update req_id during blocking time or timestamp is invalid, > * this indicates on a device error > */ > phc->stats.phc_err++; > - } else { > + else > /* Device updated req_id during blocking time with valid timestamp */ > phc->stats.phc_exp++; > - } > } > > /* Setting relative timeouts */ > @@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *ena_dev, void *data) > timestamp = (u64)aenq_common->timestamp_low | > ((u64)aenq_common->timestamp_high << 32); > > - ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIU64 "s]\n", > + ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIu64 "s]\n", > 'ENA_PRIu64' is not defined yet in this patch, so patch by patch build fails.