From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2DDE41B8D; Tue, 31 Jan 2023 10:30:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37F5D40E28; Tue, 31 Jan 2023 10:30:49 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2060.outbound.protection.outlook.com [40.107.237.60]) by mails.dpdk.org (Postfix) with ESMTP id 8692540DFB for ; Tue, 31 Jan 2023 10:30:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ckk0I58v2/zGnaul9lWn2JIEr+WU+8G4zh0pTYMMi+YJIQgY+21EIUlNVHMH7Ltg4x0nJdcuyK4qmi/+Ku4DvKTcw5xuDT3hlGqKgriToajlIGtMy1387ZcX3ZMSqvABacW7DR0IYvE9n3WXZGhkEcfrBjYq/H8pblry/3vTWcgT9EunaWOcBkdjE+HzausIj+4JFwvKCNy9jvZnVKY31rzc1eh69ACm6d532ht8kU/ETBtfTImuT4PKHphZbv8M2Ari4tATTxe281tMZzRViZ9Hp4yimy5d7C6+VDUspUlXhHNloy7O3utPJ9qqxbDUpzTEdbsyUfKO/ArngCWgDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bCpkAaPztAJ1L/RZOIDV31jduNv0SFmrZIhqBbxOddQ=; b=huKY/QYuBHE5kJ7arpWwAKj1CCiSokXloG2PYVXJFg3n4A0cFqbCmfyorygbZO71La25uoEotfH8t4BtQeAjeG+E4mon2DxGQPyaCgQqdLmVRjxL1gtg41z/JdioZ9in1MXdGf68JSyWS7feTF7oYfTSOKygr4J+zvINWfywYk5A0JruixS/qXYe9kyNyTPUjkoGrwwiud3Uka9gnJ154CihHGrWfKluG9vVvetBPQQjWnvOg9YoU3grUB7WiRXupMuJe2Z6i0J3P8RsY0+Kjv6t3Ew43pHdCY3cFbRsJPG6hGQP6uKEpUmlEJesLp0IUOK+KhOGX8l2bcxAP6zXWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bCpkAaPztAJ1L/RZOIDV31jduNv0SFmrZIhqBbxOddQ=; b=cUcLA13gEBAfoUZFwXjT+P9dlB5RhSzIDLIsQXkUBp+yrm7YXSjHxQA/oHQjJaCCG0wxDYTOZRYmiJgsKGTERgDtL/fTqW4mkDNwysqKl6dUHE+tKMBBQai3c4CxDVA/se1US9/x3Ze/WgVnUjTd5gvj5sM2o8LEubSHLlnWCCo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB7567.namprd12.prod.outlook.com (2603:10b6:208:42d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 09:30:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6043.038; Tue, 31 Jan 2023 09:30:45 +0000 Message-ID: <5ce6edae-21e4-57fa-69ae-b3d7faa4275c@amd.com> Date: Tue, 31 Jan 2023 09:30:39 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v10 2/2] testpmd: cleanup cleanly from signal Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org References: <20221014172328.185219-1-stephen@networkplumber.org> <20230130200914.22049-1-stephen@networkplumber.org> <20230130200914.22049-3-stephen@networkplumber.org> From: Ferruh Yigit In-Reply-To: <20230130200914.22049-3-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0264.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:37c::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB7567:EE_ X-MS-Office365-Filtering-Correlation-Id: 0b8090bc-343d-4f1b-dbba-08db036dd480 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rrHylvainXZWQe9mLAeld3V787n9X6nci9pe7qUlLpCdn51pd5U7RznCtFdK22upUsFWWxVq91E1RgSO+ra1ZaUMSQvCiwPFINSWaH+YL6aIOEGamyrkMg0kJICzyxZS1qPMhFrihlnBFij0XnoyBEQ8GftnxoniRg0XMhCo+alSNo0vNUePQ3qSgJng9+jPfCoaWlFgw1FskvlCKdvTjQnSE1MINdxhjKShN+iS3ewEFL+DGBXXesgQEJlC5lbbEILFbhhzRWpfKbdTUoddQ3Ua/piuM0PQy/1H5ocRvAq68wyyj3ZKO1LwoNK2Yzw7v0/5DUoe5/Hdo9FoWoIyNFFuHezvER7A76P7biPMXCDMDGdJlWervBBt//sjwhTI+wcFZpiHkUp8ntQqdpRTUrC0iUE58uihZIuzyvcRX/2lkBqq52h2NH8TvNctXf7WUKilRalqq1WCJxZ2aPv17fVO2g0j3P/u9p9xJocuJ3yxZp7NZR7cYF5QRaOugDn63MHvhJbYlulaLKgwPsrD732VBKMNeFG3iP3ve7oOR56XxG3mnDnAN1qIORecn+ZSVJGoUcNmMmD9t707/Z73IxubhY3E1LP2Wd1X6R4xtSP/FJRNYe3x0WyMjwLLUZ4hgt5jC8oFf3HIa7pm7mAm7+4xUaEO/y+2g9Ybx3xd9XAJgAuEY0ziM68MZVhkvx8LNZDedp8H7S4Cd0dw4V6ErIzxVyo6LE1AA1gLUxsr9C4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(451199018)(86362001)(36756003)(31696002)(83380400001)(6666004)(6486002)(316002)(478600001)(26005)(6512007)(2616005)(6506007)(53546011)(186003)(38100700002)(8936002)(5660300002)(44832011)(66946007)(4744005)(66556008)(66476007)(8676002)(41300700001)(2906002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUl4UTNkZUF5SEtHUmowMTBGTnVyTGEwbXVOZ0lvMDIxY3djUmlSaEpsd1Az?= =?utf-8?B?RHdBZEEyNGdLOVpyOWQ2eFNaVmhHZm9QZFNxMTFZbjRUWGpZN0o4NUdWQ1ZT?= =?utf-8?B?WDJrYzhwTDJOQ3RKWEVGUkFzQTdidGpxTDh1dGtPZkxBaUV5eURGeStUb29l?= =?utf-8?B?V2pCeS9OdlZLcjN4YXc5YWtMWWg5Q3lPelQwbE1sK1I0R3FubkFyTXRqbTVE?= =?utf-8?B?c1Yvc1kyUk5mN1pwcFMySm1kUFMwSzQ4RDNpSXZUZ1lwTEgxazdobEVMOWFp?= =?utf-8?B?bnlFa2h2ZlZqVW1zTnJJU1NFZnpOZ2RzTlN4dmZKZFFyQW4xcDB2cmpKeXNu?= =?utf-8?B?UXVveWxjbUtHMU1iWXpyKzB0ZkhGUVR3bUF0eDEvY0JMb0dlRlFUNS9xU3ZE?= =?utf-8?B?YzFrdTRSN0duaFd5ekVDS21SWDd4SUlIbEJhbStmbE42RktRTGxxSUZSajhs?= =?utf-8?B?UjZLRlZBSzJWbCt1ZHJJMUhuT25oR2FvbnRMNU9JZ3hIQmV3cHFGUzB4VGdp?= =?utf-8?B?cjA4R0g5U2JSeUVzS0xDaTFUdGQwcWdaVTdlU0pJd3VybFBtblJ6Umlwa3BP?= =?utf-8?B?RTNxWUNhUE5URzhORUtVNUs2TE5OQkhKZzF3U3gvbWJKRVd1OVNTdVpjUDB4?= =?utf-8?B?OEtZL1pDL3dZMFowdVJoR00xeUpDN1E4NFMxZkFuRnhKVktoeFdybThIS2JS?= =?utf-8?B?TFA4ZGZIaVpsbldKVDhucjlZUi80dG9MNHdOYUU5ME9nQmxkczlVS2FnOU0r?= =?utf-8?B?OVNMdyszZHV3NmxHRmcyVmF3VWNSd0dnVHI1ajNjVjE1dzlkUVM5MStlcVpW?= =?utf-8?B?SmxrOTRyUEFBb1ZsK0gvSEpyN1pIcXhERkxNM1pVN0xqb0YwaWZlcTNSZU5Z?= =?utf-8?B?QmJXM2tRVGVEVXl1S21ocEN6UkFjV1ZsSGd5N0ozRmVldE1SVUNkbFlGclVk?= =?utf-8?B?ZmpZUXNQL0dpU1dUSU5EV1M1R205VFJKNzdFOGMxY3JUNnNmM0xwc0NIbStD?= =?utf-8?B?RWlEN2taMHZ6Mkgzc0VmOGZVQ2ZPdTN5VFJMTGpBd2pFZVAvbEdsTGlqQ3dm?= =?utf-8?B?WWF1REZYUXJaNUd0a0x2KzBmeis5QzJwazl6dDQrMUx0MWhjL1Z4VWs5Z1JR?= =?utf-8?B?bEl3WFQ3Z0RTd2h3NVJnTmJlbUtnWDN3Q0YzSnFkNGF0RnllVHpNTU5Wa1lh?= =?utf-8?B?ZGt0dy9vc2liMVhZOGlyTmlmd1QvMjN0aW9UZ1lMSTVoMFBYN3VtaTArWVRx?= =?utf-8?B?Mzl0R2pjbVZ4bktzQ2Zic3ViaHpLNW5jUGlPU0c5MFpQVDJDdWtyb0NPTWpN?= =?utf-8?B?VUpuQ3Vxd3pSZkcwRVVPdm8vT0JNcm5iQkdHM3MrQy8zakI2clFPc3NRV0tR?= =?utf-8?B?QUR6V2t6YWhNVlY0bVJCcEpESk5ETXp4RVFCTnNsNDZJaVRLZjBkU1JEUUFp?= =?utf-8?B?N01VY2lwb0FKdFZFak0xQ3dNU1RQRVlSemdPOXJwTmFzZlNGUkc2L1Vwa3A1?= =?utf-8?B?T0lzVkVQUGlNcE5FQ2o3N1pzWG1XR3NnMDFnZ3VpZTRqdDhITkZrSVJmQ1FD?= =?utf-8?B?bmVmbVJsb2tSZmY2djNoTUI5b3ZGcWZIVzdDd2pjclVvanBMUXNFNlo5RTd6?= =?utf-8?B?WHplUmNjbFVjRkUrek00QVRxU2JIZ0FGcVI2T0twSWcyeURFUDZsTmNTZ2xN?= =?utf-8?B?TDFlQlFOVlcyTnVKVFcwVjVFQnJPRzBWUFFzc0dLRlNTVVNVcW1FUWdmMERk?= =?utf-8?B?MWw0UzI4Zmx4QzVmeVRMTW5ONFlGTE1aSGV1TXBmZFYrK3Q1WUtIN0dqbVE3?= =?utf-8?B?a2tyMVFnVlNGeVIyVUNGTlN4QlBUR0RBajBHZ0dlMHdsVWNFOEhqNkZDelpv?= =?utf-8?B?elc0V3JwenYyNzZKV0tlUzl2aTFnc1FJeVRiY1lBYVpUeERrR0QyQ2NQaWFL?= =?utf-8?B?UUdtT1BHU3BxVG9EeHI2NTBjQ1FnTnlZVDFiVTh0N000aGRMdHc5VHMzRUsy?= =?utf-8?B?ZlI5eCtVL2t3TjV0RklxUnFOa0N0RVJ6ZXRSQ3VWVSt4SVpBcC9XTVppR1k3?= =?utf-8?B?SDF1QTloQVp6VktkbXZ0VytpMi9TQnpLaFVCM0ZyMlo2N2IxRVRwbTdWbThr?= =?utf-8?Q?DZFjbrA0d0vEtWIVwtdyohgU2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b8090bc-343d-4f1b-dbba-08db036dd480 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 09:30:45.7871 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MetEKlxZXG1/gNJCcjfAIWCQHaVMmEk1DZYh4+zNaCI8FzKduwKSOMQu69ilFXZr X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7567 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2023 8:09 PM, Stephen Hemminger wrote: > Do a clean shutdown of testpmd when a signal is received; instead of > having testpmd kill itself. This fixes the problem where a signal could > be received in the middle of a PMD and then the signal handler would > call PMD's close routine leading to locking problems. > > An added benefit is it gets rid of some Windows specific code. > > Fixes: d9a191a00e81 ("app/testpmd: fix quitting in container") > Signed-off-by: Stephen Hemminger If cmdline commit is agreed on, testpmd changes looks good to me.