From: Ferruh Yigit <ferruh.yigit@intel.com> To: Jiawei Wang <jiaweiw@nvidia.com>, wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, orika@nvidia.com, viacheslavo@nvidia.com, thomas@monjalon.net, rasland@nvidia.com Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd packets dump overlapping Date: Fri, 20 Nov 2020 17:50:13 +0000 Message-ID: <5ce906d3-3790-a076-0744-309a8c860e85@intel.com> (raw) In-Reply-To: <1605893733-84486-1-git-send-email-jiaweiw@nvidia.com> On 11/20/2020 5:35 PM, Jiawei Wang wrote: > When testpmd enabled the verbosity for the received packets, if two packets > were received at the same time, for example, sampling packet and normal > packet, the dump output of these packets may be overlapping due to multiple > core handling the multiple queues simultaneously. > > The patch uses one string buffer that collects all the packet dump output > into this buffer and then printouts it at last, that guarantees to printout > separately the dump output per packet. > > Fixes: d862c45 ("app/testpmd: move dumping packets to a separate function") > > Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com> <...> > @@ -74,13 +85,16 @@ > uint32_t vx_vni; > const char *reason; > int dynf_index; > + int buf_size = MAX_STRING_LEN; > + char print_buf[buf_size]; > + int cur_len = 0; > > + memset(print_buf, 0, sizeof(print_buf)); Should 'print_buf' cleaned per each packet below, if not can we drop 'memset' completely? <...> > + if (cur_len >= buf_size) { > + printf("%s ...\n", print_buf); > + break; Why break here? Wouldn't just append some chars to indicate trancation and continue be OK?
next prev parent reply other threads:[~2020-11-20 17:50 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-12 8:36 [dpdk-dev] [PATCH] " Jiawei Wang 2020-11-12 16:44 ` Ferruh Yigit 2020-11-13 16:30 ` Jiawei(Jonny) Wang 2020-11-14 12:01 ` [dpdk-dev] [PATCH v2] " Jiawei Wang 2020-11-17 12:06 ` Ferruh Yigit 2020-11-18 18:09 ` Jiawei(Jonny) Wang 2020-11-19 10:30 ` Ferruh Yigit 2020-11-20 17:35 ` [dpdk-dev] [PATCH v3] " Jiawei Wang 2020-11-20 17:50 ` Ferruh Yigit [this message] 2020-11-23 6:13 ` Jiawei(Jonny) Wang 2020-11-23 10:22 ` Ferruh Yigit 2020-11-23 11:03 ` Jiawei(Jonny) Wang 2020-11-23 8:29 ` [dpdk-dev] [PATCH v4] " Jiawei Wang 2020-11-23 11:00 ` [dpdk-dev] [PATCH v5] " Jiawei Wang 2020-11-23 14:20 ` Ferruh Yigit 2021-01-06 14:13 ` [dpdk-dev] [PATCH v6] " Jiawei Wang 2021-01-06 15:54 ` Stephen Hemminger 2021-01-08 8:31 ` Jiawei(Jonny) Wang 2021-01-06 15:55 ` Stephen Hemminger 2021-01-08 8:31 ` Jiawei(Jonny) Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5ce906d3-3790-a076-0744-309a8c860e85@intel.com \ --to=ferruh.yigit@intel.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=jiaweiw@nvidia.com \ --cc=orika@nvidia.com \ --cc=rasland@nvidia.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git