From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Thierry Herbelot <thierry.herbelot@6wind.com>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
Harman Kalra <hkalra@marvell.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse()
Date: Mon, 11 Mar 2024 14:56:40 +0000 [thread overview]
Message-ID: <5cf12222-bc42-4e75-874c-92477596f040@amd.com> (raw)
In-Reply-To: <20240311125518.2714496-1-thierry.herbelot@6wind.com>
On 3/11/2024 12:55 PM, Thierry Herbelot wrote:
> Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes
> the following variable initialization in rte_eth_devargs_parse():
>
> memset(eth_da, 0, sizeof(*eth_da));
>
> Restore the memset, as this causes regression in ixgbe PCI probe.
>
> As the listed commit introduces a new argument: nb_da, the memset
> takes it into account.
>
> Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs")
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
Thanks for the fix,
Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied to dpdk-next-net/main, thanks.
Patch title and commit log updated as following while merging:
```
ethdev: fix uninitialised representor devargs
rte_eth_devargs_parse() stops initialising eth_devargs variable to zero,
which causes regression in ixgbe PCI probe.
Restore the memset for fix.
As the listed commit introduces a new argument: nb_da, the memset
takes it into account.
Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs")
```
prev parent reply other threads:[~2024-03-11 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 11:44 [PATCH] " Thierry Herbelot
2024-03-11 11:51 ` [V2] " Thierry Herbelot
2024-03-11 11:57 ` [V3] ethdev: restore eth_devargs " Thierry Herbelot
2024-03-11 12:55 ` [V4] ethdev: restore eth_da " Thierry Herbelot
2024-03-11 14:56 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf12222-bc42-4e75-874c-92477596f040@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=hkalra@marvell.com \
--cc=olivier.matz@6wind.com \
--cc=thierry.herbelot@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).