From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 709ED43C88; Mon, 11 Mar 2024 15:56:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 479504067B; Mon, 11 Mar 2024 15:56:49 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2082.outbound.protection.outlook.com [40.107.220.82]) by mails.dpdk.org (Postfix) with ESMTP id 9A0DC4026B for ; Mon, 11 Mar 2024 15:56:47 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h72EcfQu9+NTiA0X8umwtc+TVRG1FGKlrUNn0hY2Dk1nva08lb8f/G7n8dD4Ptb0JWiAT9V0xFC2XFyePwHTghwolH5x3WzzOoUXcjZaVYygUgsQ1h4U0yhno1SwgVGR0kaIfwPqpxnrzCOHm9W3ZyKZ7LrkAxJTrG5C8zaLvZ6CvsVaAgAGee44CVxh1N768R9tPbxVFO79BDFPl91UaS1But4O1yqntK/mJcuI0dXQWWxuw0tm95/A/xgOYF3wpPXXeFnArcCfBnCsaQUxDiqnUlrxL0dAkLBuvHOfhT8Up1iC8eVnKw/px21vaaP6Jk43U2ZejXs3uhWbklnUSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mlt5KLkz8TCLuzwKtZMdqUFkyjwxh4bTjDYFDbF2f/4=; b=ZT9ShParsRkhsxrT/HMjt9VOwsovy8LcZp7U6ltO87v7HO4BOYdIbQ7kR6WUVaG2V8L8WGuoarQvzPCdjuWCcFuxfLNrTvviZbibysatFuJXjbaa07AYXOObL0tRVcxecRaZHMTBbGAg0zHmA0mWte8FEWsOsvDBCVH49vl/W5+q76Yg4YswQgqSXxW8DGaKxYwhne3xe3ZXv3nMxrfDZ6MvwBmRZ+1Urjr0o7IOsIhbGyAibZYyFK0egP+ic0iFVnG7OsHblOfvwbXQ5bqT1nu4Q6XI4YKRBz0bL2OxhAhylIXAF3AGJG436+0DG5IkFtC2RqRaouS3Yzcwiivhqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mlt5KLkz8TCLuzwKtZMdqUFkyjwxh4bTjDYFDbF2f/4=; b=jJy1PC8XEOz2lR8hx3bxi5s0eboC+ZqViGkfEscmSI1y73avYSUcm5IIqS4C+JXNpxgaE6ogxIx9tu3XIHO7GuLhbTU8EeTwb/z3W0kLOtngO+PGQYOxePnEyo66PsDwsMHpEoIXPbJ0p1uXNidXc+o9h0P3Ad/COLy301SXpSo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM4PR12MB6110.namprd12.prod.outlook.com (2603:10b6:8:ad::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 14:56:45 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Mon, 11 Mar 2024 14:56:44 +0000 Message-ID: <5cf12222-bc42-4e75-874c-92477596f040@amd.com> Date: Mon, 11 Mar 2024 14:56:40 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [V4] ethdev: restore eth_da init at startup of rte_eth_devargs_parse() Content-Language: en-US To: Thierry Herbelot , dev@dpdk.org Cc: Thomas Monjalon , Harman Kalra , Olivier Matz References: <20240311115722.2708497-1-thierry.herbelot@6wind.com> <20240311125518.2714496-1-thierry.herbelot@6wind.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240311125518.2714496-1-thierry.herbelot@6wind.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0082.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM4PR12MB6110:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cf42521-ac4a-4ed2-f074-08dc41db780c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WxayRt4//xn0EbRam1fZVG28kkiHU3XJiRFAZBQl/Xr6vXE3ED6jKAJfJdi/7eYNTFqAfXpowr/oKxwZ8cPq+UfFUxsJ526qtDfMaDaZ91yTMDrlnCbtGLoeBSfkaAapzbyL3aG9wkLc5iJjv2w+zXwsGb6U+jxSg2Rp4CKRpCCQF62KfdUIvt1ift7g+w4wukOLtePEqivvfpSXcl67V/XUuNKwP5hMcsNRcU8zQZaZ8SpiWhnwurQh9p1oZAyPhXa0jt9VFM7cqGyBGm1x5ith3FXT8m+imf6u2v415Y1rS2v2AIPtTH3pnXsKNdet+6ixS6y4KBa9EwoPRzgdbYYJ6zGlx6efzW35gUsvJ7Ih9eYAMV5g8XNHmcyjYkQ1gXkXbYwcwtX1T3JiEVsL5/3+9ptlA1mfgTiZ8YtmDZHcTJV6sNz/pAGgl9c5GyDV+Po8QMAqg4FKQpydj0hHzkoSAhJUdnCATUkSM3L7nYYWAuJsIoSRvciQm5h4NOzxjMqgQ98hoTfbQn0JYDNQ1ZOCgoM5aDhYAMCiNl8IE9ar+mdFdSIU8h4rPn5RuPeSqdZsF7ZSnCXRO7aVQCAHeYsc7Mbf9Du9wBFaLl40UMQr+QF16tSJBjkbLWANDMmDO33x5An9KBfkGh3648zchcyKou+Ab6GgV0zzFhvM1T8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXc5QUowSUx4REpYamVPWk1PYVB0Q1REZW1XTzU5SUtuVk9NOHcvUHVtWnd2?= =?utf-8?B?azdzMmRsekdqdGNCVWZBZDQyU2x3SkFuWnFhY3FVY3gyeDZQeldPZWd2bWtD?= =?utf-8?B?RTNUdG80bGtQcmhaR3RwVkpVdU8rS1ZFeWI0cDg4S0JUZHMxTXV0UEhYZjYx?= =?utf-8?B?QkZEc2g3cFhwbmZ5bWh5SmVhdktZdjVHUlQva3MyK1RpNmxEZ09rcjlwY2Iw?= =?utf-8?B?dlNjT1JLSWsyS0ppZlcrQ2NIeTJrK0pjUTJlb2VyYklZcTZQZCtFOTBqei9p?= =?utf-8?B?aDUvT3k2NmVMazVucFU4NXRJWEdiZWQ1WTNWMUVGOHU0MTd0cGtoeDhOUnZP?= =?utf-8?B?aExJeHJnS1lqelRJcTZtVlVOdFVWcjY4RGRWcGZIb2xrelpqVGg2OUxVQ0N6?= =?utf-8?B?TjFkMlhHR2phUEFHZEZvTE5oQ0VBZWdaZmlFZ0EwemVNMG1Qa2RFL0RPL3lx?= =?utf-8?B?N3JjUFY1cFJNUERza1FSS29qcFlYWUFRRlo4OXo5TytObExrQVBIdWdDQVlm?= =?utf-8?B?cnA3YWZoMXVHUkVscUhadVhlNXphV0I2Z3FBTXhuZWY4dVZOMkRjUTRzY1FI?= =?utf-8?B?NW1qcVNkZS9tbC8yNGhYdjZZZWk1NUlvdlE2QXllNHJpQ2ROY1lCMkcySGlo?= =?utf-8?B?Z1ZuSXlCSmRUeFhPakFSQnJtb3dZU3padkpOYmh3eGhDbDJZMEhnaVBsdzFX?= =?utf-8?B?Sys3T0psWlEveEhSNjZTaGg5bGJlSHZ4eENMTXNFUVpWNWEyTk9ESU9nVGRW?= =?utf-8?B?ODM2L0JZU2tqOFNwaVVyc3ZzSENxak5CT3dndEphTnZ2eFR0ZmRWWGRSVXdq?= =?utf-8?B?RWtRYndacDdkaFRHRTI0bFJoa0owc3RQVDNFVlB6Tk9RMVpwYWdVdmVXYU9E?= =?utf-8?B?aGU2alQ0OFMxQXBSckdYNDd3NWlOSnBkVWVrejNGVGp1MnlRMWltNDRtZnJu?= =?utf-8?B?N0lpYnAwNC82QXlocFFqWW5WQkxEdVc4eEV5TE1vdlUreFpyUWdDL1ZTS0sw?= =?utf-8?B?VU9oSzFSUHFSWWV1bC9Sd0pIbGlFQjRSVkxISmwrVTZEM29TNThKL09ORThl?= =?utf-8?B?YkVyQnh1bExFbEFKNkthRUp2cmN3L0x6ZWZOZ01VQ09hNkhyRjdGSXpnMStp?= =?utf-8?B?aDQ1bWpQRjRTY2xkZ0pQbUM3c1hiSkljbkhUKzVBbVVzUzJ6SmJ5SlRpSGQ4?= =?utf-8?B?bHVoRnlGVWJvbVhXOUptUnRjMGZSbm1FdnMvbTM2dlZRYmxtMFR3SjVuZUs1?= =?utf-8?B?N2xMbDlRbjN0NndHcjAwN2tIeTlHNmVDbUxYK3kwaXR0Z2I5UmpNcnkwUVVw?= =?utf-8?B?bHU4cFF0alZpc29yanlza1FEQXVoSmF2RHJ1cW5hSDRWcU80NmFJaWNSYjNR?= =?utf-8?B?bk5BZ3ROMGIzMk5iM3RsSFljazVaN2Zic0NzVmFwSTFKVi9IM1R4Qy9JOWgz?= =?utf-8?B?bGN2NFp6US85cHByY1VvSjZFWnNCS3NsRGlFdGVzNS9PQ01XL05QMUdZVnJE?= =?utf-8?B?WmNnTkRQNWpueGtyeFdjOXVoaU5OazRkWllibTRIRHFjZi9TaS9McnBpN2lr?= =?utf-8?B?YXRkemU3ZjRHWjdqSWdxUks5YmZtNzNWamJxdVdrU0xWeXpoblIyMVNGSGY3?= =?utf-8?B?RUJjUkFRTk4wV2hMblRWNDFGaGk1TmgxNkp4SFc0RWdFK2l6OGNYMGo2WXZO?= =?utf-8?B?cFpyNk55eFo0WDM1aUlwMm43MTRhUVFUSFpFVll3UHpKOXNtdnZxNTZBalRG?= =?utf-8?B?SDMrWThSQ1RPcENIYUVjbStraXQyY2YvR1A0ZkRwMUxlTVlqUGJDd3NoQ1pn?= =?utf-8?B?dS9mQmxsZUVrSlIwNmdmMFFpN09VeUxwUkVUamNpUHZjTFRsT04vRnhtemo5?= =?utf-8?B?M21DbEFRcGU0V05IY1d2Ym1hODNIYjVpeVVrbHVPZUptMWZtZVVUNzJmRGl4?= =?utf-8?B?a3VyNG5iVzdGaFdlMWFUYU13ZTNKM1BtekcrVHlDQndONHFNWmlzK1k3OWdh?= =?utf-8?B?R3NQOFZIRnkwVEVPaE9CdGtJZWc2MExRb2FNcFlwQlVIUlNmWkpTeGk5ajZz?= =?utf-8?B?TU5XSXdULzI4NVY0eDF3V0N4THN6RCtLUGlwa012SFcrRWdKRFZmcXJSb3l6?= =?utf-8?Q?Hi+AGMyGaTMQnoDx4joMcRsEc?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cf42521-ac4a-4ed2-f074-08dc41db780c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 14:56:44.8353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1FM/eVVGuDHM+KDfZ3dv8oeIFtfe6pwdOJhll5jVTw/3kI9sAZYW9rdKlPGGZdVs X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6110 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/11/2024 12:55 PM, Thierry Herbelot wrote: > Commit 9a9eb104edf6 ("ethdev: parse multiple representor devargs") removes > the following variable initialization in rte_eth_devargs_parse(): > > memset(eth_da, 0, sizeof(*eth_da)); > > Restore the memset, as this causes regression in ixgbe PCI probe. > > As the listed commit introduces a new argument: nb_da, the memset > takes it into account. > > Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") > Signed-off-by: Thierry Herbelot > Signed-off-by: Olivier Matz > Thanks for the fix, Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. Patch title and commit log updated as following while merging: ``` ethdev: fix uninitialised representor devargs rte_eth_devargs_parse() stops initialising eth_devargs variable to zero, which causes regression in ixgbe PCI probe. Restore the memset for fix. As the listed commit introduces a new argument: nb_da, the memset takes it into account. Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") ```