From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, Chenbo Xia <chenbo.xia@intel.com>,
Jianfeng Tan <jianfeng.tan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/virtio: fix virtio-user Rx interrupts with multi queue
Date: Tue, 14 Sep 2021 10:39:14 +0200 [thread overview]
Message-ID: <5cf210a0-5ef2-b5ca-9a22-8fd850120219@redhat.com> (raw)
In-Reply-To: <20210831155411.17672-3-david.marchand@redhat.com>
On 8/31/21 5:54 PM, David Marchand wrote:
> The callfds[] array stores eventfds sequentially for Rx and Tx vq.
>
> Fixes: 3d4fb6fd2505 ("net/virtio-user: support Rx interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index 16c58710d7..89f8b2271f 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -416,7 +416,7 @@ virtio_user_fill_intr_handle(struct virtio_user_dev *dev)
> }
>
> for (i = 0; i < dev->max_queue_pairs; ++i)
> - eth_dev->intr_handle->efds[i] = dev->callfds[i];
> + eth_dev->intr_handle->efds[i] = dev->callfds[2 * i];
> eth_dev->intr_handle->nb_efd = dev->max_queue_pairs;
> eth_dev->intr_handle->max_intr = dev->max_queue_pairs + 1;
> eth_dev->intr_handle->type = RTE_INTR_HANDLE_VDEV;
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2021-09-14 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 15:13 [dpdk-dev] [PATCH] net/virtio: reconfigure LSC handler when required David Marchand
2021-08-31 15:54 ` [dpdk-dev] [PATCH v2 0/2] virtio-user interrupt fixes David Marchand
2021-08-31 15:54 ` [dpdk-dev] [PATCH v2 1/2] net/virtio: reconfigure LSC handler when required David Marchand
2021-09-14 8:36 ` Maxime Coquelin
2021-08-31 15:54 ` [dpdk-dev] [PATCH v2 2/2] net/virtio: fix virtio-user Rx interrupts with multi queue David Marchand
2021-09-14 8:39 ` Maxime Coquelin [this message]
2021-09-14 11:27 ` [dpdk-dev] [PATCH v2 0/2] virtio-user interrupt fixes Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf210a0-5ef2-b5ca-9a22-8fd850120219@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).